Received-SPF: pass (google.com: domain of linux-kernel+bounces-152003-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d7ff7dd609cd1b9a50e5ffa882d05b90.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <3287993.aeNJFYEL58@radijator>
References: <20240402-pxa1908-lkml-v9-0-25a003e83c6f@skole.hr> <de4c56a8-488d-4cdb-9d6c-e9d6e63b22b9@skole.hr> <58b23157c088cb4774d579cc8700de85.sboyd@kernel.org> <3287993.aeNJFYEL58@radijator>
Subject: Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver
From: Stephen Boyd <sboyd@kernel.org>
Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej <balejk@matfyz.cz>, David Wronek <david@mainlining.org>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
To: Catalin Marinas <catalin.marinas@arm.com>, Conor Dooley <conor+dt@kernel.org>, Duje =?utf-8?q?Mihanovi=C4=87?= <duje.mihanovic@skole.hr>, Guilherme G. Piccoli <gpiccoli@igalia.com>, Haojian Zhuang <haojian.zhuang@linaro.org>, Kees Cook <keescook@chromium.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Linus Walleij <linus.walleij@linaro.org>, Lubomir Rintel <lkundrak@v3.sk>, Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>, Tony Lindgren <tony@atomide.com>, Tony Luck <tony.luck@intel.com>, Will Deacon <will@kernel.org>
Date: Fri, 19 Apr 2024 15:24:42 -0700
User-Agent: alot/0.10

Quoting Duje Mihanovi=C4=87 (2024-04-19 07:31:14)
> On Friday, April 12, 2024 4:57:09=E2=80=AFAM GMT+2 Stephen Boyd wrote:
> > Quoting Duje Mihanovi=C4=87 (2024-04-11 03:15:34)
> >=20
> > > On 4/11/2024 10:00 AM, Stephen Boyd wrote:
> > > > Is there a reason this file can't be a platform driver?
> > >=20
> > > Not that I know of, I did it like this only because the other in-tree
> > > MMP clk drivers do so. I guess the initialization should look like any
> > > of the qcom GCC drivers then?
> >=20
> > Yes.
>=20
> With the entire clock driver code in one file this is quite messy as I al=
so=20
> needed to add module_init and module_exit functions to (un)register each =

> platform driver, presumably because the module_platform_driver macro does=
n't=20
> work with multiple platform drivers in one module. If I split up the driv=
er=20
> code for each clock controller block into its own file (such as clk-of-
> pxa1908-apbc.c) as I believe is the best option, should the commits be sp=
lit=20
> up accordingly as well?

Sure. Why is 'of' in the name? Maybe that is unnecessary?

>=20
> > > While at it, do you think the other MMP clk drivers could use a=20
> conversion?
> >=20
> > I'm a little wary if the conversion cannot be tested though.
>=20
> I'd rather leave it to someone with the hardware then, especially since t=
he=20
> only reason I found out about the above is that the board I'm working on =

> failed to boot completely without the module_init function.
>=20

Ok, sounds fine.