Received-SPF: pass (google.com: domain of linux-kernel+bounces-152069-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 20 Apr 2024 09:39:18 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Conor Dooley <conor@kernel.org>, Inochi Amaoto <inochiama@outlook.com>
Cc: Vinod Koul <vkoul@kernel.org>, 
	Kishon Vijay Abraham I <kishon@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Jisheng Zhang <jszhang@kernel.org>, Liu Gui <kenneth.liu@sophgo.com>, 
	Jingbao Qiu <qiujingbao.dlmu@gmail.com>, dlan@gentoo.org, linux-phy@lists.infradead.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Add Sophgo CV1800 USB phy
Message-ID:
 <IA1PR20MB49536E7548B65B41F4F33FDEBB0C2@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <IA1PR20MB4953780F4617823F7173B6D6BB042@IA1PR20MB4953.namprd20.prod.outlook.com>
 <IA1PR20MB4953040232A4D41E41F2D2A9BB042@IA1PR20MB4953.namprd20.prod.outlook.com>
 <20240419-harmful-neutron-d0db367cf659@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240419-harmful-neutron-d0db367cf659@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|DM4PR20MB4967:EE_
X-MS-Office365-Filtering-Correlation-Id: 9f12efef-5274-480d-0114-08dc60daa465
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	A5ssivpbUONLCnpnGrdOzdYsKxuEIZ6DaR1iXPTYSpwDWbObzGBc0SvnBu3iTXyFIyMKfU4LvnzN0lVYcBmj1pgZaulgJRXsjIaCv8W2IkGUjBvLVVdoT7rY0J7SLxECYXqBGC1JgFjc9tq/QgN2FEag1hZgn9keovihUvLdKPYZ+0MyS8P4/gkQbkp5+JF9WVCqVOXGi2Vbpyb5vA8V8jaJnPt+SCx6nkaaEz5JnETCx/IpuIn69gm/X5EUTSAeVz8T9BMySrWYNTYCLAn2aLHFPY8MiLNVD6odCTwYOloOCmnMIvt0zOI/sF3UU6PSj6ICEEdYIRvhLJZd/Fa7hEQwI7MMjyclTJHgbFBOoqKWWZr5ZogJncU+QuFUI3cL2eEWmhBZqBrAeg0OtLOXeVpux+7HZ9TFqPfPaS1JaQnVsdx43E4HLXonIe/X90OLoZkU3faptjVMJraxamFYbOD7SmSWxqEjpnLtqiUAemed99ZhSLBQiG22nMnGA1TJlF+Kscy5HLBNw8fz99BdXFJk7Qj0ZEIbolATiRpHdZbUihdX5Si6BH6OuTx+n3SB3JJVAf2bi5HKcMyfd+1nMalePGgmGcQ0/byZGHXAxJFGpm4NFqhU8tBz4pjif6fisb9XyuGhGwADCjDm3qWVtIVDFZ2n+31OuSMVi6/yol6HwpWQUaE5zt/E6x6rnmusr27YOJ6kgkT2EcHpMLX+3Q==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m+gB/jjgxOV60I+UQhWA7JorxWNDaat6h57XAYozAvFnnix/dpjsjgN32ZlV?=
 =?us-ascii?Q?RTrGbV7lBACb/x5v6Jq38Nd6dRL//RUvXbIZLaCq3C1NHQW9xdOj23JVG7Lj?=
 =?us-ascii?Q?/LNt3qiHZO3RHMRgNC4djyZ/j5Vx/VsR+1wilc0ZCB1Qs7LT+JgbCNmhkjNp?=
 =?us-ascii?Q?JIf5MXnwy3iyQG55s2A8U3IFFICRYlic4ZGG26JZsTLz4VcObjvfPknpuY2J?=
 =?us-ascii?Q?+2z46JDx8oAGIeW7cDtLA08jFTC/U6NydHoWCefiL7katLC3Op+Gx17HiQj0?=
 =?us-ascii?Q?iIhJkuOrVZlAdYc2cH/mK+V9Vbt250gjp65i94nWW8H1KPuBBL3f3bXYyw9k?=
 =?us-ascii?Q?/vlB63h6W92JG1Hjl0gQ7o9uA+SvPquHmG49VzxR/5/s+yj48CRx8vj47rqV?=
 =?us-ascii?Q?v1EADXAj8RChn0X6k3z9NGfWnU///YYbYBDVz4/cD1DGcz/lvFiJmbqFx9lX?=
 =?us-ascii?Q?EyINizsj80/xFFqbjJa2BbGd1psIxhurSnoofwBzLn35EKm9frdmc6r9OWTn?=
 =?us-ascii?Q?wXS9h+qdYYqd39/GIjNDc1pgEG6rMB+eOvrM21CZSWQmjcHYGmn1t6uZqrAr?=
 =?us-ascii?Q?459M1QV69DzpTPurx/yxGC8djqzADnTz6C8phvRsW7RKvB6AbMm4NS+EcRRx?=
 =?us-ascii?Q?wpvwtoV8bmoBI0ilroET9HCBwdlgkxGJAlF21aUHtYiPsAQL+msKp4JlHHe3?=
 =?us-ascii?Q?tkETcdh7EP/8D6h8faK6o4PNWExcR+0xiTDkfN26oUbKadSLIdUv7c5wiIUP?=
 =?us-ascii?Q?w6QKh8rdUJ2z3p5eAcPaoP5aXB77XZQbC9DZn4TyeHguTS+wn2h4jX/XYchZ?=
 =?us-ascii?Q?6nGoC4uqPlMmt+LHqb6GqpXh7C0qcMXXXr+yBnozs1+p1waiCrVYLXbS/8fk?=
 =?us-ascii?Q?P9veiItUtMcZaYNPETM92aa0MJnztETkacEHJd/ADPqjSruiv9GYC8Xu/u6h?=
 =?us-ascii?Q?SQtxjm7EfZR8e5awDr1EaQUN+l5h+CnPt4YrRb8NPKIve06ASKLc/xkwqYxy?=
 =?us-ascii?Q?WMYpZA29oEEVCfUXe7cK1aIvFLr3BGdxJsUkOwa0pjldZtod0T+cKgJdPK38?=
 =?us-ascii?Q?XRamy4muuqlgcYHS0P4z/lZot6dsR/agBi5pv0ia6AKfoI//0My/Ol8h25Ha?=
 =?us-ascii?Q?4Zyre/6DGwWpenM8XIZ6yb0+oU01dBLOmm5PBIeUUbOmdYNIg2PBrz4jCiUC?=
 =?us-ascii?Q?MiVKdw5V7TblpjlezUyabEPkuareGssV37qiLn4YBhgmI2RQUSnCmCR7IM91?=
 =?us-ascii?Q?HYb0JYm7yjsXNgph2sEJ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f12efef-5274-480d-0114-08dc60daa465
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2024 01:38:56.0428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR20MB4967

On Fri, Apr 19, 2024 at 03:26:53PM GMT, Conor Dooley wrote:
> On Fri, Apr 12, 2024 at 03:22:24PM +0800, Inochi Amaoto wrote:
> > The USB phy of Sophgo CV18XX series SoC needs to sense a pin called
> > "VBUS_DET" to get the right operation mode. If this pin is not
> > connected, it only supports setting the mode manually.
> > 
> > Add USB phy bindings for Sophgo CV18XX/SG200X series SoC.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> > ---
> >  .../bindings/phy/sophgo,cv1800-usb-phy.yaml   | 90 +++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/sophgo,cv1800-usb-phy.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/sophgo,cv1800-usb-phy.yaml b/Documentation/devicetree/bindings/phy/sophgo,cv1800-usb-phy.yaml
> > new file mode 100644
> > index 000000000000..cb394ac5d8c4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/sophgo,cv1800-usb-phy.yaml
> > @@ -0,0 +1,90 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/sophgo,cv1800-usb-phy.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sophgo CV18XX/SG200X USB 2.0 PHY
> > +
> > +maintainers:
> > +  - Inochi Amaoto <inochiama@outlook.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: sophgo,cv1800-usb-phy
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#phy-cells":
> > +    const: 0
> > +
> > +  clocks:
> > +    items:
> > +      - description: PHY clock
> > +      - description: PHY app clock
> > +      - description: PHY stb clock
> > +      - description: PHY lpm clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: phy
> > +      - const: app
> > +      - const: stb
> > +      - const: lpm
> > +
> > +  dr_mode:
> > +    description: PHY device mode when initing.
> 
> "initing" isn't a word, "initialising" is the correct word. Or
> "initializing" if you speak American. But if it is just the value during
> initialisation, why do we need to know - we can just overwrite it in
> software, right?
> 
> Are you sure that this is limited to initialisation? I would have
> thought that it describes the configuration that the board is in, and is
> a fixed property of the system?
> 
> > +    enum: [host, peripheral, otg]
> 
> Rob, I know this is a phy rather than a controller, so referencing
> usb-drd.yaml doesn't really make sense, but there are several PHYs using
> dr_mode so it feels like there should be something to reference here
> rather than defining the property anew.
> 

Yes, you are right. Using dr_mode in initialisation is not necessary.
We can just let it go and using the default mode. In fact, for most
boards with this SoC, host mode is just enough. And it is just easy 
to overwrite the mode value in the driver if we want another mode. 
For the OTG, it can just check the `vbus_det-gpios`. I will remove 
this property, thanks.

> > +
> > +  vbus_det-gpios:
> > +    description: GPIO to the USB OTG VBUS detect pin. This should not be
> > +      defined if vbus_det gpio and switch gpio are connected.
> 
> I don't understand the second sentence here.
> 
> > +    maxItems: 1
> > +
> > +  sophgo,switch-gpios:
> > +    description: GPIO for the phy to control connected switch.
> > +    maxItems: 2
> 
> You've got two items here, they should be described. /But/ the property
> above says "switch gpio", which is singular. Which is it?
> 

`switch-gpios` is gpios to controll USB switch connected to the
phy. Sophgo recommends that phy use a switch to separate device
port and host port if it supports both. I know this is weird,
but many board follows this design, such as Huashan PI and 
Milkv Duo S. As for item number, it is just an array of gpios
to process one by one, I mark it as two just because Milkv 
Duo S use two gpios to controll the USB switch.

For vbus_det gpio description, There is because the design of 
Milk-v Duo S, which connect the switch gpio and VBUS detect 
gpio. In this case the OTG function is broken and we can just 
change the mode by toggling switch gpios. So I suggest not 
defining this property.

> Cheers,
> Conor.
> 
> > +
> > +required:
> > +  - compatible
> > +  - "#phy-cells"
> > +  - clocks
> > +  - clock-names
> > +  - dr_mode
> > +
> > +allOf:
> > +  - if:
> > +      properties:
> > +        dr_mode:
> > +          const: otg
> > +    then:
> > +      required:
> > +        - vbus_det-gpios
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    phy@48 {
> > +      compatible = "sophgo,cv1800-usb-phy";
> > +      reg = <0x48 0x4>;
> > +      #phy-cells = <0>;
> > +      clocks = <&clk 92>, <&clk 93>,
> > +               <&clk 94>, <&clk 95>;
> > +      clock-names = "phy", "app", "stb", "lpm";
> > +      dr_mode = "host";
> > +    };
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    phy@54 {
> > +      compatible = "sophgo,cv1800-usb-phy";
> > +      reg = <0x54 0x4>;
> > +      #phy-cells = <0>;
> > +      clocks = <&clk 92>, <&clk 93>,
> > +               <&clk 94>, <&clk 95>;
> > +      clock-names = "phy", "app", "stb", "lpm";
> > +      dr_mode = "otg";
> > +      vbus_det-gpios = <&portb 6 GPIO_ACTIVE_HIGH>;
> > +    };
> > --
> > 2.44.0
> >