Received-SPF: pass (google.com: domain of linux-kernel+bounces-152080-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Subject: Re: [PATCH 0/2] block: support to account io_ticks precisely
To: Yu Kuai <yukuai1@huaweicloud.com>, ming.lei@redhat.com, hch@lst.de,
 bvanassche@acm.org, axboe@kernel.dk, mpatocka@redhat.com, snitzer@redhat.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
References: <20240323035959.1397382-1-yukuai1@huaweicloud.com>
 <513db882-ebe1-7287-99dd-3783c2c9b90f@huaweicloud.com>
From: Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <7d044376-0ef9-ffdf-87c6-781259f3d388@huaweicloud.com>
Date: Sat, 20 Apr 2024 09:49:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <513db882-ebe1-7287-99dd-3783c2c9b90f@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

在 2024/04/06 15:57, Yu Kuai 写道:
> Hi, Jens!
> Hi, Ming!
> Hi, Christoph!
> Hi, Bart!
> 
> Friendly ping ...
> 
> The 'util' reported by iostat is very important for users, they don't
> have much choise to get disk status, while 'util' has been inaccurate
> for a long time unnecessarily. I really think patch 1 is meaningful.
> 
> Patch 2 also tries to fix a problem by our customer that util can
> sometimes be huge. The root cause is that 'inflight' is account from
> blk_mq_start_request() while 'io_ticks' is account from
> blk_account_io_start(), there is a gap. I let 'inflight' to be account
> from blk_account_io_start() as well, please let me know if this is not
> good.

Friendly ping ...
> 
> Thanks!
> Kuai
> 
> 在 2024/03/23 11:59, Yu Kuai 写道:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Yu Kuai (2):
>>    block: support to account io_ticks precisely
>>    block: remove blk_mq_in_flight() and blk_mq_in_flight_rw()
>>
>>   block/blk-core.c  |  9 +++++----
>>   block/blk-merge.c |  2 ++
>>   block/blk-mq.c    | 36 ++++--------------------------------
>>   block/blk-mq.h    |  5 -----
>>   block/blk.h       |  1 +
>>   block/genhd.c     | 20 ++++----------------
>>   6 files changed, 16 insertions(+), 57 deletions(-)
>>
> 
> .
>