Received-SPF: pass (google.com: domain of linux-kernel+bounces-151973-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Apr 2024 22:32:40 +0100
From: Al Viro <viro@zeniv.linux.org.uk>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: David Laight <David.Laight@aculab.com>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] seq_file: Optimize seq_puts()
Message-ID: <20240419213240.GE2118490@ZenIV>
References: <5c4f7ad7b88f5026940efa9c8be36a58755ec1b3.1704374916.git.christophe.jaillet@wanadoo.fr>
 <4b1a4cc5-e057-4944-be69-d25f28645256@wanadoo.fr>
 <20240415210035.GW2118490@ZenIV>
 <ba306b2a1b5743bab79b3ebb04ece4df@AcuMS.aculab.com>
 <5e5cde3e-f3ad-4a9b-bc02-1c473affdcb1@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5e5cde3e-f3ad-4a9b-bc02-1c473affdcb1@wanadoo.fr>
Sender: Al Viro <viro@ftp.linux.org.uk>

On Fri, Apr 19, 2024 at 10:38:15PM +0200, Christophe JAILLET wrote:
> Le 16/04/2024 ? 22:56, David Laight a ?crit?:
> > From: Al Viro
> > > Sent: 15 April 2024 22:01
> > ...
> > > No need to make it a macro, actually.  And I would suggest going
> > > a bit further:
> > > 
> > > static inline void seq_puts(struct seq_file *m, const char *s)
> > 
> > That probably needs to be 'always_inline'.
> > 
> > > {
> > > 	if (!__builtin_constant_p(*s))
> > > 		__seq_puts(m, s);
> > > 	else if (s[0] && !s[1])
> > > 		seq_putc(m, s[0]);
> > > 	else
> > > 		seq_write(m, s, __builtin_strlen(s));
> > > }
> > 
> > You missed seq_puts(m, "");
> > 
> > I did wonder about checking sizeof(s) <= 2 in the #define version.
> 
> git grep seq_puts.*\"[^\\].\" | wc -l
> 77
> 
> What would you do in this case?
> 2 seq_putc() in order to save a memcpy(..., 2), that's it?

Not a damn thing - just have it call seq_write().  Note that
	if (s[0] && !s[1])
which triggers only on single-character strings.