Received-SPF: pass (google.com: domain of linux-kernel+bounces-152103-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Apr 2024 20:04:53 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Jeongjun Park <aha310510@gmail.com>
Cc: syzbot+8e03da5d64bc85098811@syzkaller.appspotmail.com,
 ajk@comnets.uni-bremen.de, davem@davemloft.net, edumazet@google.com,
 linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH net,v3] net: hams: Fix deadlock caused by unsafe-irq
 lock in sp_get()
Message-ID: <20240419200453.13301f29@kernel.org>
In-Reply-To: <20240419191438.30724-1-aha310510@gmail.com>
References: <0000000000005e18f00615207de6@google.com>
	<20240419191438.30724-1-aha310510@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 20 Apr 2024 04:14:38 +0900 Jeongjun Park wrote:
> read_lock() present in sp_get() is interrupt-vulnerable, so the function needs to be modified.

I was going to make the same comments as on the other submission 
but then I realized this doesn't even build.

Please don't spam the list with completely untested code. You can
submit patches to syzbot for testing without CCing the list
or developers.

> Reported-by: syzbot+8e03da5d64bc85098811@syzkaller.appspotmail.com
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Jeongjun Park <aha310510@gmail.com>
> ---
>  drivers/net/hamradio/6pack.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
> index 6ed38a3cdd73..fee583b1e59a 100644
> --- a/drivers/net/hamradio/6pack.c
> +++ b/drivers/net/hamradio/6pack.c
> @@ -373,11 +373,11 @@ static struct sixpack *sp_get(struct tty_struct *tty)
>  {
>  	struct sixpack *sp;
>  
> -	read_lock(&disc_data_lock);
> +	read_lock_irq(&disc_data_lock);
>  	sp = tty->disc_data;
>  	if (sp)
>  		refcount_inc(&sp->refcnt);
> -	read_unlock(&disc_data_lock);
> +	read_unlock_irq(&disc_data_lock);
>  
>  	return sp;
>  }