Received-SPF: pass (google.com: domain of linux-kernel+bounces-152162-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 20 Apr 2024 12:41:07 +0530 (GMT+05:30)
From: Shresth Prasad <shresthprasad7@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: daniel.thompson@linaro.org, deller@gmx.de,
	dri-devel@lists.freedesktop.org, javier.carrasco.cruz@gmail.com,
	jingoohan1@gmail.com, julia.lawall@inria.fr, lee@kernel.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org
Message-ID: <fe7df45c-b61f-4e8a-a13f-1e6a85cf83bf@gmail.com>
In-Reply-To: <yelspf4hfmmj3lnk3exyc6tm2lrsqlet623q2s5zrm2unba6nw@43ewuqdzckdg>
References: <20240419111613.GA12884@aspen.lan> <819a56c3-bbaf-4d5e-87de-78c1312c56d1@gmail.com> <yelspf4hfmmj3lnk3exyc6tm2lrsqlet623q2s5zrm2unba6nw@43ewuqdzckdg>
Subject: Re: [PATCH][next] drivers: video: Simplify device_node cleanup
 using __free
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

20 Apr 2024 1:13:42 am Dmitry Baryshkov <dmitry.baryshkov@linaro.org>:

> On Sat, Apr 20, 2024 at 12:22:41AM +0530, Shresth Prasad wrote:
>>=20
>>> Please fix the subject line to be "backlight: <driver>: ...". I came
>>> very close to deleting this patch without reading it ;-) .
>>=20
>> Really sorry about that, I'll fix it.
>>=20
>>> Do we need to get dev->of_node at all? The device, which we are
>>> borrowing, already owns a reference to the node so I don't see
>>> any point in this function taking an extra one.
>>>=20
>>> So why not simply make this:
>>>=20
>>> =C2=A0=C2=A0=C2=A0 struct device_node *np =3D dev->of_node;
>>=20
>> Looking at it again, I'm not sure why the call to `of_node_put` is there=
 in the first place. I think removing it will be fine.
>>=20
>> I'll fix both of these issues and send a patch v2.
>=20
> Just a stupid quesiton: on which platform was this patch tested?
>=20
> --=20
> With best wishes
> Dmitry
I tested the patch on a x86_64 qemu virtual machine

Regards,
Shresth