Received-SPF: pass (google.com: domain of linux-kernel+bounces-152226-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 20 Apr 2024 11:23:47 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
Cc: David Lechner <dlechner@baylibre.com>, "linux-iio@vger.kernel.org"
 <linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org"
 <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 "Hennerich, Michael" <Michael.Hennerich@analog.com>
Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
Message-ID: <20240420112347.6bd1daa4@jic23-huawei>
In-Reply-To: <PH0PR03MB7141B4F4DBF3D77F7384B555F9082@PH0PR03MB7141.namprd03.prod.outlook.com>
References: <20240412032102.136071-1-kimseer.paller@analog.com>
	<20240412032102.136071-4-kimseer.paller@analog.com>
	<20240413162640.77c6fc56@jic23-huawei>
	<PH0PR03MB7141B4F4DBF3D77F7384B555F9082@PH0PR03MB7141.namprd03.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 16 Apr 2024 14:18:23 +0000
"Paller, Kim Seer" <KimSeer.Paller@analog.com> wrote:

> > -----Original Message-----
> > From: Jonathan Cameron <jic23@kernel.org>
> > Sent: Saturday, April 13, 2024 11:27 PM
> > To: Paller, Kim Seer <KimSeer.Paller@analog.com>
> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring
> > <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> > Conor Dooley <conor+dt@kernel.org>; Liam Girdwood
> > <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; David Lechner
> > <dlechner@baylibre.com>; Hennerich, Michael
> > <Michael.Hennerich@analog.com>
> > Subject: Re: [PATCH 3/4] iio: ABI: add ABI file for the LTC2672 DAC
> > 
> > [External]
> > 
> > On Fri, 12 Apr 2024 11:21:01 +0800
> > Kim Seer Paller <kimseer.paller@analog.com> wrote:
> >   
> > > Define the sysfs interface for toggle capable channels.
> > >
> > > Toggle enabled channels will have:
> > >
> > >  * out_currentY_toggle_en
> > >  * out_currentY_raw0
> > >  * out_currentY_raw1
> > >  * out_currentY_symbol
> > >
> > > The common interface present in all channels is:
> > >
> > >  * out_currentY_raw (not present in toggle enabled channels)
> > >  * out_currentY_raw_available
> > >  * out_currentY_powerdown
> > >  * out_currentY_scale
> > >  * out_currentY_offset
> > >
> > > Co-developed-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> > > ---
> > >  .../ABI/testing/sysfs-bus-iio-dac-ltc2672     | 30 +++++++++++++++++++  
> > 
> > You can only have per device ABI defined if that is the only user
> > of the ABI.  That may actually be true here but given I've asked you to
> > generalize
> > the voltage equivalent, I think we've shown this is general enough that the
> > current
> > version should also be raised to sysfs-bus-iio-dac  
> 
> I'm still getting familiar with ABI documentation. If I understand correctly,
> generalizing the documentation to cover both parts would also mean we remove
> the overlapping sections from the ltc2688 ABI. Is that the correct approach?
> 
> 

Yes.  To test this build the html docs. IIRC that will complain about duplicate
ABI definitions.  I'm sure there is a way to test just ABI docs build but
I've never really looked into it.

Jonathan