Received-SPF: pass (google.com: domain of linux-kernel+bounces-152248-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Josua Mayer <josua@solid-run.com>
Date: Sat, 20 Apr 2024 13:23:01 +0200
Subject: [PATCH net-next v2 2/2] net: phy: adin: add support for setting
 link-status-pin polarity
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240420-adin-pin-polarity-v2-2-bf9714da7648@solid-run.com>
References: <20240420-adin-pin-polarity-v2-0-bf9714da7648@solid-run.com>
In-Reply-To: <20240420-adin-pin-polarity-v2-0-bf9714da7648@solid-run.com>
To: Michael Hennerich <michael.hennerich@analog.com>, 
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
 Rob Herring <robh@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, 
 Alexandru Tachici <alexandru.tachici@analog.com>, 
 Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, 
 Russell King <linux@armlinux.org.uk>
Cc: Jon Nettleton <jon@solid-run.com>, 
 Yazan Shhady <yazan.shhady@solid-run.com>, netdev@vger.kernel.org, 
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
 Josua Mayer <josua@solid-run.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d2JaV3NBbE5KdnhuRXA4MXl3SzhKZTdBSUhBNlhzd1EyNnFTdDJUckNCVlRI?=
 =?utf-8?B?Q2F4T3ExS0VuZ3ZjN0lrRnBSRUNMd04yRE5nRVFPQ1JVeWwveDIyZlhVbDJj?=
 =?utf-8?B?NXBNb0V4RHpybk9COFdGeFVicU9QMldyZHhxRHRlUDRLTjBoVGhxcHpLbkxh?=
 =?utf-8?B?Y2RSYTZ5RFpsWU5xakVwMEhwN1ZOd2lwMXNSRy9GaG1xWXl1Y0pYeUJaV0do?=
 =?utf-8?B?V0dGUlN5clZ1KzdyTFRKZ3JMUXRBcDNvSGs1K0ZtdnE5OHFXVEtBZEtWdlhK?=
 =?utf-8?B?QzhaWHhzVW1KcTVIdW9wSFloTWUzWkhoOVBqOE02YkloZHZ1TGNGR2RkMGlp?=
 =?utf-8?B?a3I5cWJKZG5FbWRaVm14SUJENm1tZmhVQUZZWlh2S2VyazB4L1ZqTVFCekoz?=
 =?utf-8?B?SWRLNEhIZVhQT0ZBcEdPWUVwenhtTnFaWjI4SVF5eXNkRHRBbGNKUmpCMGhP?=
 =?utf-8?B?eGh4S09MUWl0TUZiNmtUb21IeGJsVGp1U1p0ek4rK2xwMTI4RHdKSDZFU2w0?=
 =?utf-8?B?aldwK1JEUlhWckJ3VkNDYUk4U2swWHBrVnphN3AxQnh6RmxxTkt6VDVjRUU5?=
 =?utf-8?B?MUR5UWlnN2ZhMXFkM0ZZejFjYXVLOVBZbGtiM3BKNVVlRU1LQUhVZDhiWExr?=
 =?utf-8?B?T3Z5UnVFQWNRSUJyL3VrZGpxcHJOR2c0ZU9ncmxBZlk2YTdReFd6VU42N2lx?=
 =?utf-8?B?UFhrVmVQOUJDTStHOEpveXBkazhwdThPN1hIODlUdjJDYkxsUWM5bmJnRTRx?=
 =?utf-8?B?YXNpKzIvbTdFZy9MMXd4S2UwSitRQVAvNkp3S2pPRFZGdyt6MkpSbVRldWsz?=
 =?utf-8?B?aVljaWcyMUI0VmZ0UTNNTDhOQUx3c3Q2eFBPZHBOSU9OanZwU2ZFZnF6V2ZW?=
 =?utf-8?B?ZEtBTXZNM0xjbmd0TUhkMlBlZUFBNzgwaW83YXBjQ1VEQTc1Z0haRGliQzF5?=
 =?utf-8?B?UDRZaHB4Qk5aQlhlZEw5Q2hYV0tBVkJQVXdYcURLT2VGc1NIMllOYkk3Y0Jt?=
 =?utf-8?B?dzVoaW1UWDJGQ1BuNFFXcnAzejZXSUxEN1F6V0hoLzZKUkxVS0FFbUd4Q0NP?=
 =?utf-8?B?cWcxYmZZWW9LZUtuSDFQNFFmTTJ3eEdvdCt0YW1HamZrSUFFYytEWE1YUjJ4?=
 =?utf-8?B?am9ZL25nQUxHekZwc1RxcWxYVlNraGluTUxKZEhpMjY5SlRwNFRvK3dwNkhr?=
 =?utf-8?B?TlR6c0RRUlEwQmVtS2tZS0VuZHdFbng2V2pPQWt0UWcveTFYSFRqbzI2cWhn?=
 =?utf-8?B?MWtzSlNDaXJSWkwvTHRDUTlyc0ptM2k1c3dWSkEwZ1UxZmFPT0hPRXBJK0Fk?=
 =?utf-8?B?bzF1K1ZNNFk4QnBYWWhVV2xBL3dyZDlFcUJhbkJxd3B3YjJhaEtsL2JCNERK?=
 =?utf-8?B?L09XZ0FuMVhBSW5FOE9rd1FsRGU5RmFaMlo2dGJtRm5OVUtpTDBwOTRFYXZ6?=
 =?utf-8?B?Z2kyeFI3U3pJOTQ5bXltSm5GeFdPUHNkSzVMRWdkZzREdHVlMFRmMDlLTVBm?=
 =?utf-8?B?VEx6MCtRUDBJQjF2dFRVVlJCelFYNy83Y1RrZFVOYXN1QXFUMXcrUDZ5bldy?=
 =?utf-8?B?ZFM0a1ZtbklvMW9LQzBNVFdKK1lEUkNOYS9zU003ZjRvWnhuVWt0S1VKOU45?=
 =?utf-8?B?OVFNV1B2RkdoRm16NjdLdTRjR0FRelpGZDRwODJFMDZvS3g3bHRjNllFNlg4?=
 =?utf-8?B?RmZqeGN6YjJYeWd1ZE9Idm1FOEVaQndzZkpLNEJGU3FwbjN6RFZXMHRYeDNO?=
 =?utf-8?B?R2VKbHhQd2oyTWVHYWVCNWtreTNuQ3BLbmY1YVdzZUVYODAwOFpRdlNVSUdx?=
 =?utf-8?B?a3ptUS9FTkFjZUhtQnREdXg0Y3ZkVDdLN2JOa1A3L1NNYWR0U1l1d3Vpd1dm?=
 =?utf-8?B?dE4xZ1g4T1lmelpjUzFUU29kdTVmRkkyNExBekJsTVp1WXlQVGRDQ015UEVQ?=
 =?utf-8?B?QUhQdVZ4ejd4MEx0eDhSd0ptenl1U0ZvV3JNYmNCZ01ERWVpblRhblFXaTFk?=
 =?utf-8?B?UXdlYmxXemhwRHUyOHhBNkJlQ2huSXVVM2FSbnVSWjJvbDdTb3FQNmtqMUZS?=
 =?utf-8?B?aUJHbXdpMjFiUEZydVN3VDRzaE85V0lPeFMrbWlBRlp0ZThBRkRJQ1ZhTHVZ?=
 =?utf-8?Q?KfvPjv5q7i0Y91njJ1Bg+ZAld?=
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 034ee085-5dd0-43b8-c5c9-08dc612c4133
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB7586.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2024 11:23:08.1284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ue5glX+Q2IEpZsTtLwJiwlC/TSe7mbx8wn7r0GyhiNH22NGLWoSmdSS2CTbn8DCnb/5V5YZ79A3iGDfffNYQOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7588

ADIN1300/1200 support software control over pin polarity for LINK_ST
(link-status) pin.

Configure the polarity during config_init based on device-tree property.

Polarity is only set if specified in device-tree, otherwise the phy
defaults to active-high during reset.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 drivers/net/phy/adin.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 2e1a46e121d9..a533932afcb8 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -158,6 +158,9 @@
 #define ADIN1300_RMII_20_BITS			0x0004
 #define ADIN1300_RMII_24_BITS			0x0005
 
+#define ADIN1300_GE_LNK_STAT_INV_EN_REG		0xff3c
+#define   ADIN1300_GE_LNK_STAT_INV_EN		BIT(0)
+
 /**
  * struct adin_cfg_reg_map - map a config value to aregister value
  * @cfg:	value in device configuration
@@ -522,6 +525,28 @@ static int adin_config_clk_out(struct phy_device *phydev)
 			      ADIN1300_GE_CLK_CFG_MASK, sel);
 }
 
+static int adin_config_link_status_pin_polarity(struct phy_device *phydev)
+{
+	struct device *dev = &phydev->mdio.dev;
+	int ret;
+	u32 val;
+
+	if (!device_property_present(dev, "adi,link-st-polarity"))
+		return 0;
+
+	ret = device_property_read_u32(dev, "adi,link-st-polarity", &val);
+	if (ret) {
+		return ret;
+	} else if (val > 1) {
+		phydev_err(phydev, "invalid adi,link-st-polarity\n");
+		return -EINVAL;
+	}
+
+	return phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+			     ADIN1300_GE_LNK_STAT_INV_EN_REG,
+			     ADIN1300_GE_LNK_STAT_INV_EN, val);
+}
+
 static int adin_config_init(struct phy_device *phydev)
 {
 	int rc;
@@ -548,6 +573,10 @@ static int adin_config_init(struct phy_device *phydev)
 	if (rc < 0)
 		return rc;
 
+	rc = adin_config_link_status_pin_polarity(phydev);
+	if (rc < 0)
+		return rc;
+
 	phydev_dbg(phydev, "PHY is using mode '%s'\n",
 		   phy_modes(phydev->interface));
 

-- 
2.35.3