Received-SPF: pass (google.com: domain of linux-kernel+bounces-152343-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sat, 20 Apr 2024 13:13:38 -0500
From: Bjorn Andersson <andersson@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>, 
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: defconfig: qcom: enable X1E80100 sound card
Message-ID: <6sfk3n65fbq444ezbuj53litc3lizuhqbmk6mwyngja3orw4fu@ez2bqiub5235>
References: <20240403094422.15140-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240403094422.15140-1-krzysztof.kozlowski@linaro.org>

On Wed, Apr 03, 2024 at 11:44:22AM +0200, Krzysztof Kozlowski wrote:
> Enable the sound machine driver for Qualcomm X1E80100 sound card, used
> on several boards with X1E80100 (e.g. X1E80100 CRD).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

I'm completely lost on your strategy for these sound card drivers!

Why is x1e a separate driver when we're shoehorning in qc*6490 into the
sc8280xp?
Why does Srini answer me that the compatible should contain the device
name (qcom,qcs6490-rb3gen2-sndcard) while you're at the same time adding
a platform-based compatible for x1e.
 
PS. The only answer I get out of `diff -u sc8280xp.c x1e80100.c` is that
we're going to blow some speakers on X1E devices. (And is this
limitation applicable to qc?6490 devices?)


Obviously unrelated to this patch, which I will pick.

Regards,
Bjorn

> ---
> 
> The driver and bindings were posted here:
> https://lore.kernel.org/alsa-devel/20231204100116.211898-1-krzysztof.kozlowski@linaro.org/T/#t
> 
> Resending because I did not Cc Bjorn/Konrad/MSM.
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 94e677800899..4df6a724349f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -956,6 +956,7 @@ CONFIG_SND_SOC_SM8250=m
>  CONFIG_SND_SOC_SC8280XP=m
>  CONFIG_SND_SOC_SC7180=m
>  CONFIG_SND_SOC_SC7280=m
> +CONFIG_SND_SOC_X1E80100=m
>  CONFIG_SND_SOC_ROCKCHIP=m
>  CONFIG_SND_SOC_ROCKCHIP_I2S_TDM=m
>  CONFIG_SND_SOC_ROCKCHIP_SPDIF=m
> -- 
> 2.34.1
>