Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1445280lqt; Sat, 20 Apr 2024 16:16:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCVuE0fZ8q2FL07QTPlpufz+AiQOFP7xzbxB+AMfXOM7Pi4ZwO0/SMk6fET/oBN64yOujxLMrO1gAXoxu/V8aspjmuFNqZTvGwrBJkyA== X-Google-Smtp-Source: AGHT+IHk5KTnYIX0ZKbwQag/hAaJZE6VxS5HRdWVHrwX1kmMtE4HxznWi4dhG0l7WaIrAYGR9HZa X-Received: by 2002:a50:9fe1:0:b0:568:c6a2:f411 with SMTP id c88-20020a509fe1000000b00568c6a2f411mr4892509edf.32.1713654971033; Sat, 20 Apr 2024 16:16:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713654971; cv=pass; d=google.com; s=arc-20160816; b=d7KXtQXr+dRhKtBRpgOmnnGxqBkaULTxw7zdIHIM+miNeF8Nu2KigLCABWVizeUG9t HsMgMu2Uf4FTHuBPyWHIIMXO4J2VhJXkCkKqR4xnZY5O2+6DSqOjnwg1eMgbU9AdsXDQ Mt47LVmt4M2aEQsjgQo5lTH/Qa4AG0Llq9zIcfPIhG3fcX56zw3/lcZchH7bRjMb4B6l xvUxrBSz5TGyckjhBFsrgA6BHBS0pYtvQeJ6RQGu0ShpHO7pH12ciSEkrflSrl1ueIw2 oOGOLp+0PahkxKkOBN0UzqvTOAvj5HpkSjjaiAWLGnhqwR5yM66zY7R6nqwtqtLNXaYd w6kQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; fh=7uI9/dlQ3OQvqo4Z35IQZWWA5HwsQnS2zZtJEnCrk40=; b=FtV9u4MiQQ47t2UNW5Muri2PJx7m5vPjg4aviiAmMCW+fNZfp1n3VtPT8jDGznYU1s JS5TJRFFyOze539N2McvEikvEAOg5X64+sFE/jPzCQAVHvexiXQYziL/zl5L3zVjCgPK sKnWvdeuXjjrKmwwloIkcLNYz2kTSgWPKNIaUkS41te5B/b0Kk4mxQJShXHMSr1woWjD 8piysCpDW3bC5PpVeAeNt0gKT5gyEVk+lJ+QJx3GApCelywc0NoPFYcgj4NUuHeExxTO a2fu8VeczjWC3USPNoBJrRnWrfEul8+br2VrMtC6wJ0Rmo4WRU31EwVwYc4zaeTO17yi Ts7w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v6+3JRzm; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-152390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152390-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ay8-20020a056402202800b0056e0dffc7casi3933512edb.19.2024.04.20.16.16.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 16:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v6+3JRzm; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-152390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152390-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C0CDB1F214F0 for ; Sat, 20 Apr 2024 23:16:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E77344F217; Sat, 20 Apr 2024 23:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v6+3JRzm" Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7548495F0 for ; Sat, 20 Apr 2024 23:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713654960; cv=none; b=SVeh5NWZQAOiZm0YZKCHCQZY/KbcZn4su2tSDe7eF2yqmat9lTVo2rBsBey4jMXspij0vSFXb+cP7cnxY9Ay1qXLh4Q4MsVIplIda4ei4mn3dvB/TcmNGNDM5jqjMdTbxo+42pPOSBNoll+ea97Bmhd4B2tZkcJC9+pTHsPynfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713654960; c=relaxed/simple; bh=NUrvewJBcU9hHyp8pm+RCmXt1n//pDwbkcHy0aq0J3A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RToEJGL84eCsgxc6Q3gOgphlrYrGE3KdN8nmB4PEdG6JEvCW5iNaMlhW8PNMdBwzrJJzLM1U4zDCGbNK4fRiWPQHlaktkfAIo4cb6r/gnqdpAwMS8GyoNq5sYcOLkZLI5U8z4vPNnvuMZQFZa9ckuLq5YG31M5drOGecI+MGquk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=v6+3JRzm; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-419c8236b34so14354105e9.0 for ; Sat, 20 Apr 2024 16:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713654957; x=1714259757; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; b=v6+3JRzmtZlF+fMxn4yPWdPkxe9+IDYvgKjQsqCMLIqLJTN0zNjmgfIW4f7uTgO2mg pKKX3wYdzXHmJvwqOoGVxwkQsCV5eNprtZAPwZrONK6v3vYsBeVqQLIwX7DmaMDLO5R4 p9JENYQ9nTmaPsgPWd1nNpVsAjl8hQvH3+nOqzjx6ZHaT5qamlOkIjMAM65wtTFzCNBo CaoQPhPG9+BmB9gYZbMdsbIhhY/afD8YvGVwzvyb5RjegAqY/8MEsFjK0Yk2+lSICIE0 MkmsUPXSJ1Kex6Qc+Mu/IsTyi1tzkED8FyZFfhKRWnpD0YseWwkyyU8PCmD2ZfnzR8T3 7DEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713654957; x=1714259757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; b=hHIsbtwTKrtOpItpjcS+TwIdvtdkQ0YWYa4mh8lAPHfbMuq/EoFlJGBwKS+PEkUve9 bHc7FuO+xa1j+0m7CSO4scQxgxDJ9eq76BnYW/Wb7jB/xaOM6lDLHDc/qzXQQmVITcUK FC2firB9rGj4EY/8UitJCOrCN4vpu/gV1+gsrzqM+RMhDnmO5dWGBWE0bnEPILpyEWdw jbn1RPFQoI36EDDvd8fxtFPDtDfQieEm2kTRuD21UJLdM0e8v288stgxVXwCUkZfGo8A PN0ne17VaNz8+uNlFRowBB8t7VbQYlmmB2oNdBaNBFpRCXTVMwAk4GWzGh8Hi434DaR/ n8Qw== X-Forwarded-Encrypted: i=1; AJvYcCU1aHtSWL0l5YsESuGxfJuFqCuHa9d+WFkvXqnWwFdYQP8G65Ixxkdy1BdCciRWmUfj6JdAtW6woEwaysedN0zWOUa+LiwdOz6e7mqT X-Gm-Message-State: AOJu0YwKbAyC3ZhIiN6PId7bVmqEkV4YGqy+lm3DA4cXuwnwNympyfTM K0uG0Spg20Mf7ON9ti0d66Kskz9WSmajfAeO8yx8Put8O7epfq1jEBAYye2yDp0= X-Received: by 2002:a05:600c:5486:b0:419:f497:632f with SMTP id iv6-20020a05600c548600b00419f497632fmr1710464wmb.29.1713654957220; Sat, 20 Apr 2024 16:15:57 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id q2-20020adfab02000000b00349d8717feasm7913040wrc.56.2024.04.20.16.15.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Apr 2024 16:15:56 -0700 (PDT) Message-ID: <124e35b3-5b0d-4bd7-848a-5c848b339157@linaro.org> Date: Sun, 21 Apr 2024 00:15:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/26] media: stm32-dcmipp: Remove redundant printk To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/04/2024 10:47, Ricardo Ribalda wrote: > - if (irq <= 0) { > - return irq ? irq : -ENXIO; > - } You're dropping the original intent of the driver author there no ? when irq == 0 they want to return -ENXIO. --- bod