Received-SPF: pass (google.com: domain of linux-kernel+bounces-152400-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <b6f3d628-077e-486a-97f2-267324a76e9c@gmail.com>
Date: Sun, 21 Apr 2024 06:13:58 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] remove indentation for common path [linux-next]
To: Joe Perches <joe@perches.com>, heikki.krogerus@linux.intel.com,
 gregkh@linuxfoundation.org, neil.armstrong@linaro.org,
 dmitry.baryshkov@linaro.org, u.kleine-koenig@pengutronix.de,
 christophe.jaillet@wanadoo.fr
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
 skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com
References: <20240420164927.15290-1-prosunofficial@gmail.com>
 <a51f703d4f8dc3b0917002c520ea6608ac642b75.camel@perches.com>
Content-Language: en-US
From: sundar <prosunofficial@gmail.com>
In-Reply-To: <a51f703d4f8dc3b0917002c520ea6608ac642b75.camel@perches.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/04/24 22:37, Joe Perches wrote:
> On Sat, 2024-04-20 at 22:19 +0530, sundar wrote:
>
> 
>> ```
> @@ -321,35 +321,37 @@ static int nb7vpq904m_parse_data_lanes_mapping(struct nb7vpq904m *nb7)
>   
>   	ep = of_graph_get_endpoint_by_regs(nb7->client->dev.of_node, 1, 0);
>   
> -	if (ep) {
> -		ret = of_property_count_u32_elems(ep, "data-lanes");
> -		if (ret == -EINVAL)
> -			/* Property isn't here, consider default mapping */
> -			goto out_done;
> -		if (ret < 0)
> -			goto out_error;
> -
> -		if (ret != DATA_LANES_COUNT) {
> -			dev_err(&nb7->client->dev, "expected 4 data lanes\n");
> -			ret = -EINVAL;
> -			goto out_error;
> -		}
> +	if (!ep)
> +		return 0;
> ```
> 
> 
> Not equivalent code as the out_error:
> 
> 	of_node_put(ep);
> 
> isn't done
> 
> 

Hi joe perches,

If ep is null,  I believe we dont need to call of_node_put.  Because 
passing null pointer to of_node_put() make no difference.

In of_node_put() definition, if pointer is null, there is no operation.


Thanks,
Sundar