Received-SPF: pass (google.com: domain of linux-kernel+bounces-152436-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240420232505.2768428-1-shakeel.butt@linux.dev>
In-Reply-To: <20240420232505.2768428-1-shakeel.butt@linux.dev>
From: "T.J. Mercier" <tjmercier@google.com>
Date: Sat, 20 Apr 2024 19:12:05 -0700
Message-ID: <CABdmKX2r14J_OD-0HDgfg6ZqnZwtR0+pi6JYq9sJHrsKBbAxWQ@mail.gmail.com>
Subject: Re: [PATCH v2] memcg: simple cleanup of stats update functions
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Michal Hocko <mhocko@kernel.org>, Roman Gushchin <roman.gushchin@linux.dev>, 
	Muchun Song <muchun.song@linux.dev>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 20, 2024 at 4:25=E2=80=AFPM Shakeel Butt <shakeel.butt@linux.de=
v> wrote:
>
> mod_memcg_lruvec_state() is never called from outside of memcontrol.c
> and with always irq disabled. So, replace it with the irq disabled
> version and add an assert that irq is disabled in the caller.
>
> Similarly mod_objcg_state() is not called from outside of memcontrol.c,
> so simply make it static and change it's name to __mod_objcg_state().
>
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: T.J. Mercier <tjmercier@google.com>