Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1574983lqt; Sun, 21 Apr 2024 00:12:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUO8PGdO9pI6ZbNC7n7P4W4PE6aT8SlZwnPXq6lizbj1+TSJsiexMqQGOH/84VdgIl/JRSj6NCucP/HiW7ZDhtzhDmyTqK9CY24yOHYmw== X-Google-Smtp-Source: AGHT+IGW28o9bjjuh69ITpqdU3jQFxxrDbvMLdhyCY8r6aLu6utm8nDDSI7WKkm2OVXprKRsof++ X-Received: by 2002:a05:6a20:1588:b0:1a7:aa73:ca24 with SMTP id h8-20020a056a20158800b001a7aa73ca24mr15082672pzj.13.1713683576173; Sun, 21 Apr 2024 00:12:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713683576; cv=pass; d=google.com; s=arc-20160816; b=nsxOod5jEGK2wcNb0E2YbcJ3qRmMVoWp9eNOqvXWfPsSnFUfX1oC3JAxT61vF0A5I0 Mw05hwtJ/vs5LJnvF6PnxRHlN76BUsuJxa98+I1OlUY/IsM6OHsImHwqOMVXC8OCKp4M kvR3M1lCMUHoNJlvExNHExqnlhS4HPTYt1z/d5Vgv0wvuNrPJO8zne1EUqoMSCDdiJih enswXOuz4TxRYsnE/qKOlpWnIHzPHdU4IWxii3ESv+iL5c1oFrXcE7QxyOI5b1YPtBZl ZNbnCuSpoprfnsR9dwCZD2bTjb84QSrK3CM0PjtQIcZNUVzNe1VgCwPGGmT+E4ej/KGz fevw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=ABMbuCzUgRcvgXAgAo9VcSGCNGz/v10vBxViR6/P0PA=; fh=yOXSm0E/8tOfmRnhk0JfE6MKLQieMwDr2DHng9Fw+Y4=; b=bUXiIWwrE9dzY+TxiOpvWRg7EL/fhONh3Ef5S+o13d62O3aqb0LbfjALCpyjTTKbQq U7icNMjIvKZtDLlGEPp1tqOSA3zkU07EnDkUOD0wtJMh49eTlPdcw9VBRMuKqIDkVet6 /rUB/tnFTACnkN/NfK+VzRX6yaelmZ8iSZCpG2mUPFMUzzQcOE54V1VJL3oOrHNRNwfi Lt2miv95F28TT0Fu/GM6AG6nEzFccZy1JyeNS7WKTx5tTTveASZKpmpJCa1moy5P8JEk HCAHedj+Kew646E/kZb7tplf7GAUv9LzGwwoEsPm2LzG+9j9BJnwRduhrEpFFm5bQbj5 I6OA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-152456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id e19-20020a656793000000b005dd565d7626si5746022pgr.900.2024.04.21.00.12.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 00:12:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-152456-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152456-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A0C61B20BD3 for ; Sun, 21 Apr 2024 07:12:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 92FD2D53F; Sun, 21 Apr 2024 07:12:46 +0000 (UTC) Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E6CA4437 for ; Sun, 21 Apr 2024 07:12:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713683566; cv=none; b=ughIO/t7J/bEUY3kBwRQ/YuuBrcelTgxfa8JOVCtie6zLaPHjODdw8eof4tyl6Rwr6t7Nl5YpfNwdPGQO8zSZj2YECgeyjf1uIpkC/+1vKK6w/AmsylUORVAopc3r2ayb5GWvtgkFVAU86kggKLliHkDymzlKKNup8sut/bsnWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713683566; c=relaxed/simple; bh=nWWxXOfco+rjROpQCpzO0Q5BfhYTwDjKeSNYYJlrPC4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gd0P7xwew+PADfNFmFMoH9+EJVTJxcfNEpHDhRYR3dRxGwpj4Q3GERzk09ppRABS9ezlsqmkCfcJX5Jh9HGjq6tXr+bUAWZVrToT6TUxEe7CIu5XRqkPRnCONVApDyWRThrhiRs1W+jPI58lczge8vucMGg0MQ7o8r9GHBYzU9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id EEE2C40E0187; Sun, 21 Apr 2024 07:12:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id u6V1THR8SB5r; Sun, 21 Apr 2024 07:12:37 +0000 (UTC) Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 25EA040E0028; Sun, 21 Apr 2024 07:12:23 +0000 (UTC) Date: Sun, 21 Apr 2024 09:12:22 +0200 From: Borislav Petkov To: Tom Lendacky Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev, svsm-devel@coconut-svsm.dev, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Dan Williams , Michael Roth , Ashish Kalra Subject: Re: [PATCH v3 02/14] x86/sev: Make the VMPL0 checking function more generic Message-ID: <20240421071126.GAZiS8HoAn5sFLShnf@fat_crate.local> References: <1b0d8ec8e671ad957a2ad888725ce24edeedf74a.1711405593.git.thomas.lendacky@amd.com> <20240417114658.GHZh-2sk47TZgCp4Mb@fat_crate.local> <505dcf34-93ff-643c-b149-8ef9ce90c023@amd.com> <20240417205048.GHZiA2KGbFFTQFyTAM@fat_crate.local> <36453f2f-3a2f-ae8b-215f-da9972f14d6d@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <36453f2f-3a2f-ae8b-215f-da9972f14d6d@amd.com> On Thu, Apr 18, 2024 at 01:38:49PM -0500, Tom Lendacky wrote: > I think I'll just eliminate the function then and call rmpadjust directly, > that should make it clear. Your call. However, if we're anticipating more uses around RMPADJUST like that we might as well design the interface properly from the very beginning. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette