Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1652114lqt; Sun, 21 Apr 2024 04:13:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWu1TgH+sVS2NCbCj4ZK16J+nKgcOUYBZh6OqlSJ2T4AShbTFBb3drg1tMg2N3Fvj96HQnys1W325+WhiJtMk1zIWltA9GlSY9lrROxkg== X-Google-Smtp-Source: AGHT+IFoTONL0xaWTbt55pboj95M2tDZpj2ZoRdc7HdKEayc9R/xYqvFHPMF2nQpVuR9ES7UqnIn X-Received: by 2002:ac8:7d0a:0:b0:438:d78e:5e92 with SMTP id g10-20020ac87d0a000000b00438d78e5e92mr8906172qtb.64.1713697997427; Sun, 21 Apr 2024 04:13:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713697997; cv=pass; d=google.com; s=arc-20160816; b=sImVhBdV9fo8s67+XB3GQ8lO1lh9Xs710bWPR+pi2R7J0TsuCAYT5i7e56M06+RxsA rRLdy+/VQhPe5vYKKbqtvCRjBpQOY7mU/mYDWfei/UYiFuRXjUIu+8RsOhATNz/L3kWS sgEJc7CmNAvC/cfhZMbkKfboREnI3t8XlThB4m90QjJBJMf6omWzR4lD/omDw0nGI5Ez C9FIvWRg1lUoZ7zMEwlRHTtOKtsiZb6OEFj4ncRcacPC5TVwTIzkLHNwRrgjd99mK40N rnZLNrYYpvT8QViduhHT2ORhgjnTldx1MRNJY6fdrYPcoid5WfbcMUJ7Y7QbZjzp5yMe pO0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=WMcEqaXduoUyIXuDkaiAuKCUUwmoJ8AXPRqVr9EczQw=; fh=oQbvuNnOUeIuBT5siQdg+euUHNNdn+CeEwAg69/1RSo=; b=Grs242a13/v5YWQqUAh7qkKCRtcZeN8wilbCyqnSCFAPjem6CRcw1/pNVAy7R6EFp8 ohcbx2Uoq+TFwhtSc4mu8D1+ZSZs+EgboOFFoSrsA9yZLlWOfELjfQf5i2TkOFrnqTKm UDJ4OyE+aNmWhx8i1RUT2Ik7CladZ1IJwqAKB69pGEgFVC827qlHjvtFDMofS932tmOw TYDiqQ4O5Y0455i1VbAKeRLEeF5MmS1b2v9ZAFGAtwY5kJpqVcoBtksHhlsV0r0QpRC1 usth03uhFxYuaAFX/kpCgVWGSl3J5NDwD/s8mevPqLJ7aA/ksC/XzxbRKQK6uLSSzJ3g VUcg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hZjfMy0G; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-152478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152478-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id oq48-20020a05620a613000b007906cf26b63si1353411qkn.582.2024.04.21.04.13.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 04:13:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hZjfMy0G; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-152478-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152478-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 246271C203DE for ; Sun, 21 Apr 2024 11:13:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC7EB111A2; Sun, 21 Apr 2024 11:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hZjfMy0G" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDD86AD7; Sun, 21 Apr 2024 11:13:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713697990; cv=none; b=MoGzItVwvzBumnT9iG5pRGq+sNd3jnSdfj7rMThqWucA5VMMEhLhfGK7ge9E3hkc2AIC/tXmDR/MghunUP7IsdaA96M2IW3nIiXstUi6ZeqLr9BmI6oPNxHjklb/+MwG9rh+yL7dUFhsiRnGQ9lSqKJyD9bH6w6KdSNSVQBDlYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713697990; c=relaxed/simple; bh=T8R3zSpNO6LtvSfdpaSEY3m6wVK/7bVFcSFRC8miPRY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=VbFS//gIywGBGHAxoaupaZdv/uSaC6VvKr/GcIBu9dkk0W7yShkhoDlVO5G/bussvsC1Lm06ez1sqg6ScAM/GytkAMCcSThmGBR1Wu3C4Ymp+V4dg37SSWOnlQJItWh5PgDSr09/fy06Chq9Cv/zaFipYGHjJ0ME/jBBj+WWRlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hZjfMy0G; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73E8AC113CE; Sun, 21 Apr 2024 11:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713697989; bh=T8R3zSpNO6LtvSfdpaSEY3m6wVK/7bVFcSFRC8miPRY=; h=From:To:Cc:Subject:Date:From; b=hZjfMy0GSSO+b6ajLntEc9d0sWwU3mLGx+AUaQtrbs4Pon83+0//CAxHGvsHmSL8c XMxo/9nA0w0niBUHtxt7VYKG9P9Yt8EsGdtV4zIOxo1am0evJVVJKH+ka6LUd/nSmN Rvi4rGcfz8yMqsXsAJbZeVvv4dZyUZIJDmLIBZAWlrwBOEn266Ak5z5vz/stBIkQ6p 5i2NCtTn1ro0vfFKnVaZ7fTRP6RJKl9T2cDqi6fZ3DTUcrYfyOzifGgS0M/uHbI0Op 2yWAw2T+WpA4lqH9J+KbcZ12JEkEHe4Lc9My6ZU837gVnSMprR/cZ4Ja0rw2blkSvu e58gwU6SDCrDA== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada Subject: [PATCH] kconfig: remove unneeded if-conditional in conf_choice() Date: Sun, 21 Apr 2024 20:13:02 +0900 Message-Id: <20240421111302.2712135-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All symbols except choices have a name. child->sym->name never becomes NULL inside choice blocks. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c index 965bb40c50e5..0156ca13f949 100644 --- a/scripts/kconfig/conf.c +++ b/scripts/kconfig/conf.c @@ -497,9 +497,8 @@ static int conf_choice(struct menu *menu) printf("%*c", indent, '>'); } else printf("%*c", indent, ' '); - printf(" %d. %s", cnt, menu_get_prompt(child)); - if (child->sym->name) - printf(" (%s)", child->sym->name); + printf(" %d. %s (%s)", cnt, menu_get_prompt(child), + child->sym->name); if (!sym_has_value(child->sym)) printf(" (NEW)"); printf("\n"); -- 2.40.1