Received-SPF: pass (google.com: domain of linux-kernel+bounces-152503-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
Date: Sun, 21 Apr 2024 15:54:32 +0200
From: Dragan Simic <dsimic@manjaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
 linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
 conor+dt@kernel.org, linux-kernel@vger.kernel.org, amadeus@jmu.edu.cn,
 FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Correct the descriptions
 for Radxa boards
In-Reply-To: <20240419-triumph-cheddar-77fc2f6948b0@spud>
References: <1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org>
 <1888572.CQOukoFCf9@diego> <20240418-attach-tigress-bc2b9f844fc7@spud>
 <c3c4a6ad48fbd62b44991c9bfd81570a@manjaro.org>
 <20240419-triumph-cheddar-77fc2f6948b0@spud>
Message-ID: <a3930b26634a78888c9fe3013284563c@manjaro.org>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit

On 2024-04-19 16:09, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 07:12:35PM +0200, Dragan Simic wrote:
>> On 2024-04-18 19:04, Conor Dooley wrote:
>> > On Thu, Apr 18, 2024 at 06:59:42PM +0200, Heiko Stübner wrote:
>> > > Am Donnerstag, 18. April 2024, 18:26:19 CEST schrieb Dragan Simic:
>> > > > Correct the descriptions of a few Radxa boards, according to the up-to-date
>> > > > documentation from Radxa and the detailed explanation from Naoki. [1]  To sum
>> > > > it up, the short naming, as specified by Radxa, is preferred.
>> > > >
>> > > > [1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/
>> > > >
>> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > > > Signed-off-by: Dragan Simic <dsimic@manjaro.org>
>> > > > ---
>> > > >  Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++----
>> > > >  1 file changed, 4 insertions(+), 4 deletions(-)
>> > > >
>> > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > > index fcf7316ecd74..ae58e25c29ec 100644
>> > > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> > > > @@ -767,22 +767,22 @@ properties:
>> > > >            - const: radxa,rockpis
>> > > >            - const: rockchip,rk3308
>> > > >
>> > > > -      - description: Radxa Rock2 Square
>> > > > +      - description: Radxa Rock 2 Square
>> > >
>> > > I may be just blind, but what changed here?
>> >
>> > There's now a space before the 2.
>> 
>> Exactly.  That's part of the Radxa's naming convention, which may be
>> seen as somewhat similar to the general rule of spacing out values and
>> their associated units, e.g. "2 MB" is in general preferred over "2MB"
>> in nearly any kind of a formally correct document.
> 
>> As a side note, there's even so-called "half space" as a typographical
>> convention for spacing out the values and the associated units.  That
>> makes formatted text with such spacing a bit nicer. :)
> 
> Let's not introduce half spaces into the bindings though :)

Of course. :)