Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1773711lqt; Sun, 21 Apr 2024 08:58:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWMYlN0mTyf6csoZPU3j8hlrD//4z2rzs1DjLEJkLR9m1s+xn0XYIy0E+/a2j3UR6tzNZylTydnk5breuzdPofuI6cD85jL9+JvK9Y+wg== X-Google-Smtp-Source: AGHT+IEtZK8bRvJDcEiNj3oAPvOMP74O07DyQl/QHddME34xTYMoedXLOA/L+tISgDMa63gpDocz X-Received: by 2002:a05:6a20:9e49:b0:1a7:1e1c:3031 with SMTP id mt9-20020a056a209e4900b001a71e1c3031mr10771245pzb.36.1713715114159; Sun, 21 Apr 2024 08:58:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713715114; cv=pass; d=google.com; s=arc-20160816; b=ck5syVHYr2owHDBUq1c2LIS0I9SE8tFJ3EhguytvS74QzirgSxOys+tI1plSwjnAdZ mpXA61KHSJgzunPednyGgmNwBGIw9+ZyaIDXjbmXwiprnRmmkIHl9HBipAEmU/uEk+Uc T/4XFpsjQQQF4WCF3f1vAOOs1BHa2g1XkLNkuajMAvXJ9+NA24hRM+TQ4Z10NPM1nDL7 FMMsijTNwPlSIGr1EGvhYDgt0zRt0TplbnZz/YjQBfYzgNCh6LrnDclArFpjIq5yYI5i BPcAp1RZisRa95icca+P7fE+1mvjKnl2CUXTVOGg5K93Ii8/GRS5Zb6LWCBnpCF1Bq6j zhvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature; bh=T2yeg4Kk5JddOKyLCDf0kTIZCbqFu1omxNzC1RUPP2k=; fh=yUvXEjOyRTxru6UTuYb6SbqUKWOu9unlDRQTthKS1Cg=; b=aWoYZpiihAZn4y6YP2Dsj6mHavyG6NPNQBLE3fYxvMF1JVN+P2ywhci8/J2jtVQNUL ZqyPzaw3dxFKSBvkhifpYzqcjUkgQHs5wtSCiADfmpqzdzyZpFhB2t/T8G6unzOifHoO PBmvnFFLA2x3Le9BdUq2LZXYBszbOAN2YgCet7ZUa1hQ5T5Hm4+Yz98DhgyLC9l0XLBG srxc62zIJUlQUcgX/g6FNdNSNHec1VQJ5usp4ZG7NZZ1i2QkDJedsZPuHHFlsR4ErlYN n3h1+KEwSLlA7pzPQo/bBd00FTpl28NW9TP1iHQ/ATibJNaX1p0YYiOVTFzn7JZfW3IW 2Akg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ssi.bg header.s=ink header.b=Q8KrmCo4; arc=pass (i=1 spf=pass spfdomain=ssi.bg dkim=pass dkdomain=ssi.bg dmarc=pass fromdomain=ssi.bg); spf=pass (google.com: domain of linux-kernel+bounces-152523-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152523-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ssi.bg Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f12-20020a056a00238c00b006e6bcbccd85si6539087pfc.22.2024.04.21.08.58.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 08:58:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152523-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ssi.bg header.s=ink header.b=Q8KrmCo4; arc=pass (i=1 spf=pass spfdomain=ssi.bg dkim=pass dkdomain=ssi.bg dmarc=pass fromdomain=ssi.bg); spf=pass (google.com: domain of linux-kernel+bounces-152523-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152523-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ssi.bg Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BB5E6281A03 for ; Sun, 21 Apr 2024 15:58:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB7A01BDD5; Sun, 21 Apr 2024 15:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ssi.bg header.i=@ssi.bg header.b="Q8KrmCo4" Received: from mg.ssi.bg (mg.ssi.bg [193.238.174.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30CF91BC2A; Sun, 21 Apr 2024 15:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.238.174.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713715104; cv=none; b=hdW3WHocENoQrgfiujqWb5XSuHlbDjbKOXLcuqJ+0ntmftHK0NKP7wM8XA9WDnzDxIQ+oD9nxwM55JFXU31UJyz/cDTRqTX8E5fPAFdCWG/4p0gnaV6yAlVSCK3AXrxNGmgHantA8qkje634HU/He36te0faHnt+Y8GnpL3Y9Xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713715104; c=relaxed/simple; bh=O3g/dwNbPOlGeREP5DLztRfYyrPB9K8uTpS/h1FUspI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=fzW6aHJJif4oxZoP8tof90u12W+L1oA7Q531NmKodcoU/+db1yRWVrUaAdWJEx305q1L5CcOOtd3hOMexX8E7vn4VRaZ5UnidwLcmXyi/axHI/B/2V6trbVlafn+qfSPJa/aWulUG6xHGc15QSIHlAC7GPHX+vZaFsINU1wSOas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ssi.bg; spf=pass smtp.mailfrom=ssi.bg; dkim=pass (1024-bit key) header.d=ssi.bg header.i=@ssi.bg header.b=Q8KrmCo4; arc=none smtp.client-ip=193.238.174.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ssi.bg Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ssi.bg Received: from mg.ssi.bg (localhost [127.0.0.1]) by mg.ssi.bg (Proxmox) with ESMTP id 708C122CE3; Sun, 21 Apr 2024 18:58:18 +0300 (EEST) Received: from ink.ssi.bg (ink.ssi.bg [193.238.174.40]) by mg.ssi.bg (Proxmox) with ESMTPS; Sun, 21 Apr 2024 18:58:17 +0300 (EEST) Received: from ja.ssi.bg (unknown [213.16.62.126]) by ink.ssi.bg (Postfix) with ESMTPSA id 8C3AB9003A6; Sun, 21 Apr 2024 18:58:13 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ssi.bg; s=ink; t=1713715093; bh=O3g/dwNbPOlGeREP5DLztRfYyrPB9K8uTpS/h1FUspI=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=Q8KrmCo46WvXg/DCTE8uZcW0Aq6r5YH34HeegfnQhfFrYiPvEB973HpGOXl5uRAYx UFlzKg6UomPiBjDgm+W78HUPI1r585vxhkAHn+SZtJwZQVPOPAp+Ben1O54k2AlaGN xVG7fOODeJnQIryRCz+BrgXSkEhSLKkmcSUvzzoA= Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by ja.ssi.bg (8.17.1/8.17.1) with ESMTP id 43LFwBYu079854; Sun, 21 Apr 2024 18:58:11 +0300 Date: Sun, 21 Apr 2024 18:58:11 +0300 (EEST) From: Julian Anastasov To: Ismael Luceno cc: linux-kernel@vger.kernel.org, Firo Yang , Andreas Taschner , =?UTF-8?Q?Michal_Kube=C4=8Dek?= , Simon Horman , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets In-Reply-To: Message-ID: References: <20240418144434.16407-1-iluceno@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hello, On Sun, 21 Apr 2024, Ismael Luceno wrote: > On 21/Apr/2024 14:01, Julian Anastasov wrote: > > > I'm guessing what should be the Fixes line, may be?: > > > > Fixes: 90017accff61 ("sctp: Add GSO support") > > This seems like the right one. > > > because SCTP GSO was added after the IPVS code? Or the > > more recent commit d02f51cbcf12 which adds skb_is_gso_sctp ? > > That doesn't seem related at all. > > Do we need to check .gso_type in cases like this? Just skb_is_gso(skb) ? IMHO, this should work. Regards -- Julian Anastasov