Received-SPF: pass (google.com: domain of linux-kernel+bounces-152536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <e696e720-0cd3-4505-8469-a94815b39467@I-love.SAKURA.ne.jp>
 <CAHk-=wjEZvnn51dhhLqBKUd=cuFhbYA47_OyfUOPB-0zKToL7Q@mail.gmail.com>
 <CAHk-=wjzqaqcicTtWfBtXyytJs1nqjJNved2JFsLVsVLYgVkuQ@mail.gmail.com>
 <CAHk-=wjW3PdOZ7PJ+RHUKRc8SqQhcWXCACOvmwBkKUKABHKqwg@mail.gmail.com>
 <6103a212-f84f-4dad-9d33-a18235bd970a@I-love.SAKURA.ne.jp> <CAHk-=wgjZ0DJgeo5Sk-Kc5vw8TXGuxXftPV79Wv221ncstk1tA@mail.gmail.com>
In-Reply-To: <CAHk-=wgjZ0DJgeo5Sk-Kc5vw8TXGuxXftPV79Wv221ncstk1tA@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 21 Apr 2024 10:18:31 -0700
Message-ID: <CAHk-=wg+hJ9Y8AKjp9qD7E_-pgBFdWGLiqzi1qth8LNpuST1cA@mail.gmail.com>
Subject: Re: [PATCH v2] tty: n_gsm: restrict tty devices to attach
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, 
	Andrew Morton <akpm@linux-foundation.org>, "Starke, Daniel" <daniel.starke@siemens.com>, 
	LKML <linux-kernel@vger.kernel.org>, 
	linux-security-module <linux-security-module@vger.kernel.org>
Content-Type: multipart/mixed; boundary="0000000000008c371006169e83f6"

--0000000000008c371006169e83f6
Content-Type: text/plain; charset="UTF-8"

On Sun, 21 Apr 2024 at 09:04, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> The only option is to *mark* the ones that are atomic. Which was my suggestion.

Actually, another option would be to just return an error at 'set_ldisc()' time.

Sadly, the actual "tty->ops->set_ldisc()" function not only returns
'void' (easy enough to change - there aren't that many of them), but
it's called too late after the old ldisc has already been dropped.
It's basically a "inform tty about new ldisc" and is not useful for a
"is this ok"?

But we could trivially add a "ldisc_ok()" function, and have the vt
driver say "I only accept N_TTY".

Something like this ENTIRELY UNTESTED patch.

Again - this is untested, and maybe there are other tty drivers that
have issues with the stranger line disciplines, but this at least
seems simple and fairly easy to explain why we do what we do..

And if pty's really need the same thing, that would be easy to add.
But I actually think that at least pty slaves should *not* limit
ldiscs, because the whole point of a pty slave is to look like another
tty. If you want to emulate a serial device over a network, the way to
do it would be with a pty.

Hmm?

                Linus

--0000000000008c371006169e83f6
Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_lv9siqw80>
X-Attachment-Id: f_lv9siqw80

IGRyaXZlcnMvdHR5L3R0eV9sZGlzYy5jICAgIHwgIDYgKysrKysrCiBkcml2ZXJzL3R0eS92dC92
dC5jICAgICAgICB8IDEwICsrKysrKysrKysKIGluY2x1ZGUvbGludXgvdHR5X2RyaXZlci5oIHwg
IDggKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp
dCBhL2RyaXZlcnMvdHR5L3R0eV9sZGlzYy5jIGIvZHJpdmVycy90dHkvdHR5X2xkaXNjLmMKaW5k
ZXggM2Y2OGUyMTNkZjFmLi5kODBlOWQ0Yzk3NGIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdHR5L3R0
eV9sZGlzYy5jCisrKyBiL2RyaXZlcnMvdHR5L3R0eV9sZGlzYy5jCkBAIC01NDUsNiArNTQ1LDEy
IEBAIGludCB0dHlfc2V0X2xkaXNjKHN0cnVjdCB0dHlfc3RydWN0ICp0dHksIGludCBkaXNjKQog
CQlnb3RvIG91dDsKIAl9CiAKKwlpZiAodHR5LT5vcHMtPmxkaXNjX29rKSB7CisJCXJldHZhbCA9
IHR0eS0+b3BzLT5sZGlzY19vayh0dHksIGRpc2MpOworCQlpZiAocmV0dmFsKQorCQkJZ290byBv
dXQ7CisJfQorCiAJb2xkX2xkaXNjID0gdHR5LT5sZGlzYzsKIAogCS8qIFNodXRkb3duIHRoZSBv
bGQgZGlzY2lwbGluZS4gKi8KZGlmZiAtLWdpdCBhL2RyaXZlcnMvdHR5L3Z0L3Z0LmMgYi9kcml2
ZXJzL3R0eS92dC92dC5jCmluZGV4IDliNWI5OGRmYzhiNC4uY2Q4N2UzZDEyOTFlIDEwMDY0NAot
LS0gYS9kcml2ZXJzL3R0eS92dC92dC5jCisrKyBiL2RyaXZlcnMvdHR5L3Z0L3Z0LmMKQEAgLTM1
NzYsNiArMzU3NiwxNSBAQCBzdGF0aWMgdm9pZCBjb25fY2xlYW51cChzdHJ1Y3QgdHR5X3N0cnVj
dCAqdHR5KQogCXR0eV9wb3J0X3B1dCgmdmMtPnBvcnQpOwogfQogCisvKgorICogV2UgY2FuJ3Qg
ZGVhbCB3aXRoIGFueXRoaW5nIGJ1dCB0aGUgTl9UVFkgbGRpc2MsCisgKiBiZWNhdXNlIHdlIGNh
biBzbGVlcCBpbiBvdXIgd3JpdGUoKSByb3V0aW5lLgorICovCitzdGF0aWMgaW50IGNvbl9sZGlz
Y19vayhzdHJ1Y3QgdHR5X3N0cnVjdCAqdHR5LCBpbnQgbGRpc2MpCit7CisJcmV0dXJuIGxkaXNj
ID09IE5fVFRZID8gMCA6IC1FSU5WQUw7Cit9CisKIHN0YXRpYyBpbnQgZGVmYXVsdF9jb2xvciAg
ICAgICAgICAgPSA3OyAvKiB3aGl0ZSAqLwogc3RhdGljIGludCBkZWZhdWx0X2l0YWxpY19jb2xv
ciAgICA9IDI7IC8vIGdyZWVuIChBU0NJSSkKIHN0YXRpYyBpbnQgZGVmYXVsdF91bmRlcmxpbmVf
Y29sb3IgPSAzOyAvLyBjeWFuIChBU0NJSSkKQEAgLTM2OTUsNiArMzcwNCw3IEBAIHN0YXRpYyBj
b25zdCBzdHJ1Y3QgdHR5X29wZXJhdGlvbnMgY29uX29wcyA9IHsKIAkucmVzaXplID0gdnRfcmVz
aXplLAogCS5zaHV0ZG93biA9IGNvbl9zaHV0ZG93biwKIAkuY2xlYW51cCA9IGNvbl9jbGVhbnVw
LAorCS5sZGlzY19vayA9IGNvbl9sZGlzY19vaywKIH07CiAKIHN0YXRpYyBzdHJ1Y3QgY2RldiB2
YzBfY2RldjsKZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdHR5X2RyaXZlci5oIGIvaW5jbHVk
ZS9saW51eC90dHlfZHJpdmVyLmgKaW5kZXggNzM3MjEyNGZiZjkwLi5kZDRiMzFjZTZkNWQgMTAw
NjQ0Ci0tLSBhL2luY2x1ZGUvbGludXgvdHR5X2RyaXZlci5oCisrKyBiL2luY2x1ZGUvbGludXgv
dHR5X2RyaXZlci5oCkBAIC0xNTQsNiArMTU0LDEzIEBAIHN0cnVjdCBzZXJpYWxfc3RydWN0Owog
ICoKICAqCU9wdGlvbmFsLiBDYWxsZWQgdW5kZXIgdGhlIEB0dHktPnRlcm1pb3NfcndzZW0uIE1h
eSBzbGVlcC4KICAqCisgKiBAbGRpc2Nfb2s6IGBgaW50ICgpKHN0cnVjdCB0dHlfc3RydWN0ICp0
dHksIGludCBsZGlzYylgYAorICoKKyAqCVRoaXMgcm91dGluZSBhbGxvd3MgdGhlIEB0dHkgZHJp
dmVyIHRvIGRlY2lkZSBpZiBpdCBjYW4gZGVhbAorICoJd2l0aCBhIHBhcnRpY3VsYXIgQGxkaXNj
LgorICoKKyAqCU9wdGlvbmFsLiBDYWxsZWQgdW5kZXIgdGhlIEB0dHktPmxkaXNjX3NlbSBhbmQg
QHR0eS0+dGVybWlvc19yd3NlbS4KKyAqCiAgKiBAc2V0X2xkaXNjOiBgYHZvaWQgKCkoc3RydWN0
IHR0eV9zdHJ1Y3QgKnR0eSlgYAogICoKICAqCVRoaXMgcm91dGluZSBhbGxvd3MgdGhlIEB0dHkg
ZHJpdmVyIHRvIGJlIG5vdGlmaWVkIHdoZW4gdGhlIGRldmljZSdzCkBAIC0zNzIsNiArMzc5LDcg
QEAgc3RydWN0IHR0eV9vcGVyYXRpb25zIHsKIAl2b2lkICgqaGFuZ3VwKShzdHJ1Y3QgdHR5X3N0
cnVjdCAqdHR5KTsKIAlpbnQgKCpicmVha19jdGwpKHN0cnVjdCB0dHlfc3RydWN0ICp0dHksIGlu
dCBzdGF0ZSk7CiAJdm9pZCAoKmZsdXNoX2J1ZmZlcikoc3RydWN0IHR0eV9zdHJ1Y3QgKnR0eSk7
CisJaW50ICgqbGRpc2Nfb2spKHN0cnVjdCB0dHlfc3RydWN0ICp0dHksIGludCBsZGlzYyk7CiAJ
dm9pZCAoKnNldF9sZGlzYykoc3RydWN0IHR0eV9zdHJ1Y3QgKnR0eSk7CiAJdm9pZCAoKndhaXRf
dW50aWxfc2VudCkoc3RydWN0IHR0eV9zdHJ1Y3QgKnR0eSwgaW50IHRpbWVvdXQpOwogCXZvaWQg
KCpzZW5kX3hjaGFyKShzdHJ1Y3QgdHR5X3N0cnVjdCAqdHR5LCB1OCBjaCk7Cg==
--0000000000008c371006169e83f6--