Received-SPF: pass (google.com: domain of linux-kernel+bounces-152548-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <80d969b70038f5c0de6f2d912cb1f6b395eea94a.camel@physik.fu-berlin.de>
Subject: Re: [PATCH 1/2] sh: convert the last use of 'optional' property in
 Kconfig
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Yoshinori Sato
 <ysato@users.sourceforge.jp>,  Rich Felker <dalias@libc.org>,
 linux-sh@vger.kernel.org
Date: Sun, 21 Apr 2024 19:51:17 +0200
In-Reply-To: <20240421120824.2713923-2-masahiroy@kernel.org>
References: <20240421120824.2713923-1-masahiroy@kernel.org>
	 <20240421120824.2713923-2-masahiroy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

Hi Masahiro,

On Sun, 2024-04-21 at 21:08 +0900, Masahiro Yamada wrote:
> The 'choice' statement is primarily used to exclusively select one
> option, but the 'optional' property allows all entries to be disabled.
>=20
> This feature is only used in arch/sh/Kconfig because the equivalent
> outcome can be achieved by inserting one more entry as a place-holder.
> This approach is commonly used, for example, LTO_NONE, DEBUG_INFO_NONE,
> INITRAMFS_COMPRESSION_NONE, etc.
>=20
> The 'optional' property support will be removed from Kconfig.
>=20
> This commit converts the last user.
>=20
> Note:
>  The 'default CMDLINE_OVERWRITE' statement does not work as intended
>  in combination with 'optional'. If neither CONFIG_CMDLINE_OVERWRITE
>  nor CONFIG_CMD_EXTEND is specified in a defconfig file, both of them
>  are disabled. This is a bug. To maintain the current behavior, I
>  added CONFIG_CMD_NO_MODIFY=3Dy to those defconfig files.
         ^^^^^^^^^^^^^^^^^^^^^^
     This would be CMDLINE_NO_MODIFY as used in the actual Kconfig files.

I am fine with the change per se, but could you rename CMDLINE_NO_MODIFY to
CMDLINE_FROM_BOOTLOADER as it's used on the other architectures such as arm
and powerpc, preferably using the same help text.

Also, I usually prefer the first word in the subject to be capitalized, i.e=
.

	sh: Convert the last use of 'optional' property in Kconfig

Thanks,
Adrian

--=20
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913