Received-SPF: pass (google.com: domain of linux-kernel+bounces-152679-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8a304a97-7825-4b02-a716-f25d0e9d4718@intel.com>
Date: Mon, 22 Apr 2024 10:06:54 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 3/6] PCI/AER: Enable RCEC to report internal error for
 CXL root port
To: Dan Williams <dan.j.williams@intel.com>, Terry Bowman
	<Terry.Bowman@amd.com>, <rrichter@amd.com>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240313083602.239201-1-ming4.li@intel.com>
 <20240313083602.239201-4-ming4.li@intel.com>
 <7172ec2f-7cba-460b-a6c6-9fff45ba938b@amd.com>
 <b4a721c2-567d-4ab3-8a85-963e3f323e61@intel.com>
 <91ddd182-cc71-480f-a1b2-e7c31b29a549@amd.com>
 <f0b85a37-ead0-4954-b7e0-dd09cbd9ab09@intel.com>
 <662134e290d89_5eec229450@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Language: en-US
From: "Li, Ming" <ming4.li@intel.com>
Organization: Intel
In-Reply-To: <662134e290d89_5eec229450@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Si9ZZmtsSzBESUdwUnJMbmlVYnpGbERZSlY4WFdLYzVFWWRSRXlZT1VTVWQ3?=
 =?utf-8?B?K3VERVEzM1gydlpwcEVhejBBYTQxcy8vNVVWVkpERDJRN3k0cG9sWEMrTVdi?=
 =?utf-8?B?Y0diVnk2bFdaUlpWMUdXazFjcU9BUG1VV1JtZzdEYy9tbTYxUDBReU9iSVl5?=
 =?utf-8?B?cFVNS2MwR1FoSFZEcWluV2NmQXNxT25BRTlZL2F5V0ZFVTVvcVNDbUxycWp6?=
 =?utf-8?B?TmNoc2VBVmtHcWx2b1R5TTQ2dXdVNlZHcEUyUEZ4WVB3SytPdVRqaEZ0cy9R?=
 =?utf-8?B?ay9WbWpRcXBLV2NYVDVJMWpITjVnMmMvcVRUc3JiQ0hUa2o0N2hlcDR2L0xG?=
 =?utf-8?B?Z1N5QUYzU3h3M200WmVKcysySTlZZHdkSURKdjdESFlNOTZuU2lSeTR0Z2l2?=
 =?utf-8?B?cnNNdlBET3IxNlB4clZOVFBoQmZNcGtBN0hTRzJram9VMHRydm5iQTdoVXlL?=
 =?utf-8?B?TGpxWHRIQmJhQkxFbXNZNnZMRzc4djNLbVdjQ3IwUldsVE9WQlpERzR5T1dN?=
 =?utf-8?B?eWJUUEphNGZwY0hYOWwxc1poVS9sY1JVTmx6ZmVBNjA5a3FCSllFWGlXVXYw?=
 =?utf-8?B?Rk9OY1d1RlVLWnZMYXI5c0g3bExsQlJDWU1jM25xZkc2Sng5SmtpSmdZSm9q?=
 =?utf-8?B?RGdQaDNDV2JXdEJ0ZldqMmNlTktHWXFnZnE5cXJTUTNrVWpYVGNVQ2RaNE16?=
 =?utf-8?B?UU5HR0VmQzJYQ2NBOVhjMDQxZVd0L05iSDRDVm8wZnplOXBaNE15d3ppdWtQ?=
 =?utf-8?B?TzhjT09kaVRhamV6ejQxaHhFRGw5R2F1V1JuTFNFc3dwYVR6eVRycU1YK3lY?=
 =?utf-8?B?TWVLR2RjaTRRanE0cmRWR3dPZHBhdmx3Q0hHZGtJQlovN2RhczhhVXRLQ2w5?=
 =?utf-8?B?aEhnVmZOQTQ3OVMyajZTRXpLYVJ6TjdjbjR1VlB2SWtUSVRWcXBOWkJGc2M1?=
 =?utf-8?B?Wld6cmxWdllvZFRhOHk5MC8xOW92Vi9XdVp0SjFUbVF4cHFNOG0vTloyamR6?=
 =?utf-8?B?cmZiZytsalREc1dFQ3M2MW1Lak9ERVd4K0tpKzlPMkFGU2dGQkVnVnFHRmxZ?=
 =?utf-8?B?bEhVVWdiZGhCT0tPckw5MEFsTnA2UFhOT2x6WlNiamhNTUVhWlpxd01ET2tn?=
 =?utf-8?B?YWUxU1ZnMm5veDFBd3cwU0dPYUlWRXBBdVAwNDFxOXdySTdkSW93dG9qUlls?=
 =?utf-8?B?dXRkRVU2WjlCTEVzV25Kbmx3RjFtazNCZ2l1a1kvamp2dlBvTmdWRmlhZzRq?=
 =?utf-8?B?QStMK2k4eXZ6STRFbk9YaysvK0gvb0FheUp5b1Q0czFJYlIxWFQrd2poc3Jt?=
 =?utf-8?B?VVhmRXpGMis0TCtiOVlEbS9tc05hT2g2YllqM2hMRSszVlRSclU3OUZHb3JI?=
 =?utf-8?B?bHJvM2VvY0J6eWFDNERUNUxQYlNKTWFGLzM4ODlka3BUc0w3RnJlODR0ZzF4?=
 =?utf-8?B?c0FTdW5salQzM2xwZmVFSW1tZnQxZjhxT3FkR0hSRCtJeW1RNmtsRTZNN3Z0?=
 =?utf-8?B?MVpra3NvcjA1cWp1M09ORnNtb0V2N0pOQitoSU5COXlsckNvSW40SEZtT0Fx?=
 =?utf-8?B?TWw5Y0tWdXpWVGVPcC8vL0xxTUhCRDIzWGdkL3dScTFGTGJhVUFGbXoveks2?=
 =?utf-8?B?VGlNeW8xeHVOV2lWdkorV0pQMUVyL3lrWmJER2JwU2Z4ZDJINngrTS9WNklX?=
 =?utf-8?B?MGFqTVA1dG92UW8waldyV2VMdHNqcEJvcloyVnhZcU80ajMxUHRWYk8xb1cz?=
 =?utf-8?B?YTd2NytpK0FHSUN0Y2d2cSszRFp1UUdQVi9OWDNhWjlERStOREc5SVdQTGVx?=
 =?utf-8?B?OGpvNG9sSmtNQWJXZlN0SFA2MGJxU2txSWgzWEFVWGM4N25sVXhrTVMxNytF?=
 =?utf-8?B?MjFGeHpGazlwb3JSNXhIbjBoRkxYTEtOV05aRlJlYlhWZGRaZUIwMzhWM21j?=
 =?utf-8?B?TDd5K3pYaHNpVjBoZzd6S2Nwb1NxMTNXVVA1b09WbzhaS2IwbzZub1RnSXJG?=
 =?utf-8?B?RmZLOU1uejZ2UHl4SHE1WEVkMGUwVC9xRTI5ZjJudDhpNEpldERpZXVmeDN6?=
 =?utf-8?B?ZDFIeisybE1YaU1zRkxlNVFDTVIwb0FXWDU0SC9TT3hIWVVFSHB1TVM2ajVv?=
 =?utf-8?Q?S5Qb85+1OOe22YOEtCIVVKFmI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 29f97ee5-3eed-4c6b-0632-08dc6270e60f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7200.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 02:07:01.8764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7egTlO68/F+CATF9OSOIswO1HeSvqCHFdRqHfgjnhnAGAeYia/uWjZDsHeDMcIn+Vq0o9CxaVPBYBYImPe4InQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7280
X-OriginatorOrg: intel.com

On 4/18/2024 10:57 PM, Dan Williams wrote:
> Li, Ming wrote:
>> On 4/16/2024 10:46 PM, Terry Bowman wrote:
>>> The driver support is much simpler if RCEC does not handle VH protocol errors. Is there 
>>> a reason to forward root port VH mode protocol errors to an RCEC rather than consume 
>>> in the root port's AER driver and forward to CXL error handler? 
>>>
>> I agree that is simpler if only root port handle VH protocol errors,
>> but I think that software has no chance to choose if VH protocol
>> errors reported to RCEC or root port, it depends on platform
>> implementation. So I think we should support both cases.
> 
> The question is whether the CXL spec RDPAS behavior causes any problems
> for platforms that follow PCIe rather than CXL reporting flows for
> root-port errors. I.e. does it cause problems if Linux starts scanning
> root ports on RCEC notifications?
> 
> I do think the lookup needs to change to be based on CXL host-bridge
> detection and not CXL-type-3 endpoint detection, but otherwise it looks
> like CXL spec wants to invalidate PCIe spec expectations.

Hi Dan, if my understanding is correct, the CXL host-bridge detection you mentioned is that iterating all root ports under RCEC associated bus range for RCEC reported VH protocol errors case, and the CXL-type-3 detection is that iterating all CXL-type-3 endpoint under RCEC associated bus range. is it right?