Received-SPF: pass (google.com: domain of linux-kernel+bounces-152747-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <611a79db-4c4c-4538-a67e-370a777387ab@siemens.com>
Date: Mon, 22 Apr 2024 07:36:40 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC][PATCH] watchdog: rti-wdt: Provide set_timeout handler to
 make existing userspace happy
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
 linux-watchdog@vger.kernel.org,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Tero Kristo <t-kristo@ti.com>,
 "Su, Bao Cheng (RC-CN DF FA R&D)" <baocheng.su@siemens.com>
References: <4d82b8ce-bc34-e4b2-c5fe-9e883b0db59d@siemens.com>
 <e6e3f905-3de5-469c-a47e-179fe23c66df@roeck-us.net>
From: Jan Kiszka <jan.kiszka@siemens.com>
Content-Language: en-US
In-Reply-To: <e6e3f905-3de5-469c-a47e-179fe23c66df@roeck-us.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEplZTU2eGE4VkV2eVN2RmNkTU05VnFpN0hpckxjZTBQTUZaVDFDQWtwamhJ?=
 =?utf-8?B?ZkIyQlBJK1RPaU1XL2RRSXRzaUh1MDE4bWFZQmRBcENUWkoxbHhMYStQRTll?=
 =?utf-8?B?SU1TWTcySVNEMmhQMGp1ZjFkeXRlUmNvM1FKV2FMK0Z5Q2NnRk0wUHA4cHNI?=
 =?utf-8?B?VWlyY1UvZWpZSmtkUU5PRG00U2JGb1ArZ1p1YnE0ZThVYVUvRlBqTlpvNzc1?=
 =?utf-8?B?ekZReUVYYWpDTUY1Wkl2VnA5eDJpbWZraWhESml1OHp1eXJEeTJUVUFQQ1Nw?=
 =?utf-8?B?a0s3OUhvTU83Z0lhM3QraCtZQmZoL0dWS2daZWpVMDlOeDVQeTUxV1RSeHFm?=
 =?utf-8?B?K0hLdXk2SVZqVXM4ankyaWJEcWFScDZaMitpQldpbXFOMFY1U0dOWkU0c0xV?=
 =?utf-8?B?WGlxYUFVT091cklsZGRya1hXL285b3UxVzg2RjdkaUVSL3U0bTV0dWVjeUZC?=
 =?utf-8?B?UEhzYXhOZStpdk1VMlhKbHE4dExiT3Z6bExiNDFOUWlINFFkN2VKb1dVOXZk?=
 =?utf-8?B?MTBWOUNJbkhZWFVUR1oxSi9YcnJTRzduNzBqZ2pTc3hLdE9YS2FCdnRkZ2dX?=
 =?utf-8?B?ZHVnOHdnVHBqTHYvbGNrcVZsWHFZU3hJMDhtd2p3aGh1a3FtLzFHUnl4eWQ4?=
 =?utf-8?B?aG5qQUdJQ25taFRKaDZwK2dkVnF6VE1EZ25TRGxhT0xValVadnhuaWJkai9x?=
 =?utf-8?B?Z3JjSEIrMXQ2Vm9yeXJTM0FsMXBWN2ZpSlJ0bTRPVmFoOCt0UVRiczgvVm1Y?=
 =?utf-8?B?b1pHZ1ZZTkNxektOeUwwM1M2Z2Q0RkI0VnhFZEp6WER6Rmo2ajNZOHM4UDRp?=
 =?utf-8?B?ZVNmeVpEcm1hQktYcHN0bFVqOTF5THkycTUxNUxFVmN6RitZNDh4dHlSWGdy?=
 =?utf-8?B?blYyS0VicitBbnJEOEIzc3VlVnI2NjZWOXU5MENwZ2IwZ2hDZHl6ci9nZlBx?=
 =?utf-8?B?TVhyUmxIVm9BWVRwM2h3RVZDM29WdXgzS05WSi8xNnNYQjUwckNVZlJidjQ5?=
 =?utf-8?B?bE1IRGttRElnZkxvbTBoL2FoVk9PNnBGcEpMaUViYitSeHpRZHM4OUtFaEhk?=
 =?utf-8?B?TWk3TGo1MGtKMTd4Zk1DbTk2WkgyUmc3V3BVNXV6VFN3d2VvSUxweTRzK0lz?=
 =?utf-8?B?MitWSzVMQ01mTytlL1dldDVmZDIzVDIzcWdPYlg0RTNwTHpJWVVxL1BZOU52?=
 =?utf-8?B?RXBWSkNRZEFnRDFaMHo5WXNHNlNWRmZQVXJLNDMzaERrTnViaGFGUm0zTWJC?=
 =?utf-8?B?ckRGeXpidFFkYURHNFVzZ0pmdmZqZlB6TllPdnpqSUNIdS83N3JPckNEODNt?=
 =?utf-8?B?bkZMTUdYTnYvTUpUUlNpMUpyMERLT2ZrUHI2SUR1b081bnFwYmlDU3Baa0Mw?=
 =?utf-8?B?OUdaVkdKTWh0cTRVL0VmRXlhdXpMNDlZYzRNMHVUemtrNnQ5ZnJQWkczQjhL?=
 =?utf-8?B?a0c5WkFNbXYvak85MVZvT2dUVmp6dGxnaHF0bUg3dnFrSjB2M01HbmhGK2pK?=
 =?utf-8?B?RVNrdGcwUVBrVnluSnQ0VER5UTR0SUhramdwT0JhK0FieStCUGdtekt6bDc4?=
 =?utf-8?B?ejI0eVlpKyt6WHdydEQvNTdwTGt6dDNIN0xTUXJsY29xSzh5TlQrMFNvd3U1?=
 =?utf-8?B?Rm56M2grNUJlckVaNU0vZjc3bXpwNllMTFZtaUJqUW5KdjhkakF4N3lCaTNC?=
 =?utf-8?B?NHZINkNrOVRMd0w2UkthOGpydTJzVHd3N0cwQnN6ZFFSZVVLTVIwWVZZSUpK?=
 =?utf-8?B?Q0Mxb25hRk9GcUZ3TlNWSE44dEF3c0Q0dmZKUlE1Z2YvUW5IRVNyTjNoSDlr?=
 =?utf-8?B?WHdSZzJjd3hiQWJ2SzFtc0FZNjlpYkFGb1lraDRLWm9sSDEzVjdWRlE4SU5v?=
 =?utf-8?B?cEc1OWJRZ0V5WTlFemozWHdUUzl3dHhSQ0sxdFpXKzVhd2djOGhJUTBkTWMw?=
 =?utf-8?B?MXZrTXgxRGJNUFRoTnJaR1BEL1N4NXZpNHR5L3ltTUF5OXhPMGFsYk1SVW01?=
 =?utf-8?B?TVFEOVcxaUNwTU9nREVzZFhRVERSMlVYQzhFYzc5WTBsL1hGN2U5bXVtVmZy?=
 =?utf-8?B?YnZQSWw2UzZaOWxSTFY0NjhsYThibm9heitoNEtvYnhwM2ExZWpXZUxrOTF6?=
 =?utf-8?Q?ZJeBRdSG4lMV+HRnW3GGsI9jo?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52486aea-e74f-4ed4-eaf3-08dc628e30ff
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 05:36:42.7678
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 01d8S19zvc6voGVkF6k81hYtEyRwe3kyko6ZpJfHHHhvC3JrEO1G5znt9yyXniz8iV7zn77tsnSEsDozGNHd8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR10MB5622

On 22.04.24 01:50, Guenter Roeck wrote:
> On Mon, Sep 13, 2021 at 01:41:43PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Prominent userspace - systemd - cannot handle watchdogs without
>> WDIOF_SETTIMEOUT, even if it was configured to the same time as the
>> driver selected or was used by firmware to start the watchdog. To avoid
>> failing in this case, implement a handler that only fails if a deviating
>> set_timeout is requested.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> NACK.
> 
> This will need to be fixed in systemd. set_timeout is and will remain
> optional.

Err, this patch was sent in 2021, and even systemd is long fixed (since
v250).

Jan

-- 
Siemens AG, Technology
Linux Expert Center