Received-SPF: pass (google.com: domain of linux-kernel+bounces-152780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Subject: Re: Re: [PATCH v2] net: phy: marvell-88q2xxx: add support for Rev B1 and B2
Date: Mon, 22 Apr 2024 08:24:07 +0200
From: Gregor Herburger <gregor.herburger@ew.tq-group.com>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Stefan Eichenberger <eichest@gmail.com>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux@ew.tq-group.com,
	alexander.stein@ew.tq-group.com
Message-ID: <ZiYCh4MbI9kly1mh@herburgerg-w2>
References: <20240417-mv88q222x-revb1-b2-init-v2-1-7ef41f87722a@ew.tq-group.com>
 <20240418123155.GA248236@debian>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240418123155.GA248236@debian>

On Thu, Apr 18, 2024 at 02:31:55PM +0200, Dimitri Fedrau wrote:
> > +static const struct mmd_val mv88q222x_revb1_revb2_init_seq1[] = {
> > +	{ MDIO_MMD_PCS, 0xFE07, 0x125A },
> > +	{ MDIO_MMD_PCS, 0xFE09, 0x1288 },
> > +	{ MDIO_MMD_PCS, 0xFE08, 0x2588 },
> > +	{ MDIO_MMD_PCS, 0xFE72, 0x042C },
> > +	{ MDIO_MMD_PCS, 0xFFE4, 0x0071 },
> > +	{ MDIO_MMD_PCS, 0xFFE4, 0x0001 },
> > +	{ MDIO_MMD_PCS, 0xFE1B, 0x0048 },
> > +	{ MDIO_MMD_PMAPMD, 0x0000, 0x0000 },
> > +	{ MDIO_MMD_PCS, 0x0000, 0x0000 },
> > +	{ MDIO_MMD_PCS, 0xFFDB, 0xFC10 },
> > +	{ MDIO_MMD_PCS, 0xFE1B, 0x58 },
> > +	{ MDIO_MMD_PCS, 0xFCAD, 0x030C },
> > +	{ MDIO_MMD_PCS, 0x8032, 0x6001 },
> > +	{ MDIO_MMD_PCS, 0xFDFF, 0x05A5 },
> > +	{ MDIO_MMD_PCS, 0xFDEC, 0xDBAF },
> > +	{ MDIO_MMD_PCS, 0xFCAB, 0x1054 },
> > +	{ MDIO_MMD_PCS, 0xFCAC, 0x1483 },
> > +	{ MDIO_MMD_PCS, 0x8033, 0xC801 },
> > +	{ MDIO_MMD_AN, 0x8032, 0x2020 },
> > +	{ MDIO_MMD_AN, 0x8031, 0xA28 },
> > +	{ MDIO_MMD_AN, 0x8031, 0xC28 },
> > +	{ MDIO_MMD_PCS, 0xFBBA, 0x0CB2 },
> > +	{ MDIO_MMD_PCS, 0xFBBB, 0x0C4A },
> > +	{ MDIO_MMD_PCS, 0xFE5F, 0xE8 },
> > +	{ MDIO_MMD_PCS, 0xFE05, 0x755C },
> > +	{ MDIO_MMD_PCS, 0xFA20, 0x002A },
> > +	{ MDIO_MMD_PCS, 0xFE11, 0x1105 },
> > +};
> > +
> nit: use small letters for hex values.
> 

Ok, will update in next version.

> Hi Gregor,
> 
> tested it for rev. B0 and it works as expected.
> 
> Tested-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> 
> Best regards,
> Dimitri Fedrau

Hi Dimitri,

thanks for testing!