Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2067672lqt; Sun, 21 Apr 2024 23:34:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXoljikh1H0rHFuB2G7WIv5FKV8ROnYgN+ghsxgG3oPCersRjkyRSnkmxhD1/9gPjFa7SUbBVkfRTc/yzvjml1pardArTWVuqBBacHf3g== X-Google-Smtp-Source: AGHT+IHQc2nW0n3d5OHbNHEwS8mrgKdqLOYghV/6tqo9+W81S+4Ey3U8HuQMKH+1sDWqRJy2pNBy X-Received: by 2002:a17:906:618:b0:a46:bfe2:521f with SMTP id s24-20020a170906061800b00a46bfe2521fmr5510374ejb.24.1713767698876; Sun, 21 Apr 2024 23:34:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713767698; cv=pass; d=google.com; s=arc-20160816; b=RoVdQjWcAbuy3C26NbkMoOc42MSOmaLEeIje2L42lUEAhpHa1fE/YB59Rg9mnQTlSm TDs1t2PGa13qKHcJdJJmzYchx7EeDrtDgzvmBzARgExgAryTNrDKK50pTOhSJctsCPLp uW9qdAMCt7xdmCTMuSQ5PaN3mOF145yfhwjpRvbNxjSr1aNeQpK9r/3rcebuQKhDqUcP rqNSOc/XdL6KXZGP7CxqDNgjbpkydKXZxjfnrqfNPJXpVnIrj3CcUv+9+e0rm7FkZAAH 1Hh9EUghL9kG4F8GHoMxvh/eprz4XK2OlfXnEx1O2DmVv+bj4nl00RsWMPCnFvidZQWz wlLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=O5Tvvb96m7+SKcvBMlaFTAjiOhoMrHTJ45G4XuK0fIc=; fh=EfmapE99FlbvxscN+HpFeOkbmp/mY4f8nAgjriFWGuE=; b=JS5fOTsWOkmXYXgx8HhoWEupjkeMHw/BamqzzLMmiXPcwzjP5Sv94XPp6mX32pNqWt VgHFcsZDH79+zwXEjAju4XsdETIHXjs/05q8QqmB8bR9owGaKk73/fjiPOdejKzXvS7g 78kOIv2RgG0UBxOoWagLZN3vLyd8IdCAc6QXvS0lluHU2Tk7qlnylBapOBOwopbTFALw I54cISIQ/ZJDOmoSd+abnbro4J+lZed0Mv8j9GyxiqXLHfwTJgEimnGzGS7K1eHy/VZ+ BX3h47VafCaEGbdPbhMHkqI1CRFZgr8GGtBc6k3AsgrOxtJooSxv51whHMWZ4qnAeRXn n3jQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-152791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152791-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z13-20020a170906240d00b00a52385938b6si5501724eja.70.2024.04.21.23.34.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 23:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-152791-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152791-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 710671F2152D for ; Mon, 22 Apr 2024 06:34:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E8A1D481B3; Mon, 22 Apr 2024 06:34:50 +0000 (UTC) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D03971391; Mon, 22 Apr 2024 06:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713767690; cv=none; b=n+1nzDuoLmIsKnJKOB78XaDiYd99rEqSFrTJ6W8/vtvT8xQ7XtCWkDFN+ONFTZya8cWhTYvsk6JiKSvLxI9nR3EG3AXdd+mQJqp6xJ7Bag4wi56szPkc3aeJI/H2T2UwGE5kwqizxjtHICo5ynf2mz+qVYEtUoD9EobBHcPPsR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713767690; c=relaxed/simple; bh=6iZAc1tIa1xnK8gdGWezPsViVb+BuSu8Iz8NpY6Sl5I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TeqtKSZEqldg+b9Y+EO9DdK6oDkuWXKpjfX3tJHmHfrcTOBqRKR09KiMOMfmMojriPLpFrvGlVl0HBjTEKCJ8NZVhS945BzJmTuVYIxRg2Q6VnR9FWfpyp7Z/shD4oO4RijY1DTaO1wU7p4WhzIZX96FZW3iziQewOjpsHuDVQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a52582ecde4so361725566b.0; Sun, 21 Apr 2024 23:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713767687; x=1714372487; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O5Tvvb96m7+SKcvBMlaFTAjiOhoMrHTJ45G4XuK0fIc=; b=j+clLixNBKlUKFPzjQUKKxHJ4LD3UWSaYQ4rkGSM6YrDQi/t+BYbML49xM11hzXoNX IDvEw0RzbedwE3tfra4TUG0+CtTSrFZTsE/0cfj3wwliuczqI43MdJ7gR2RDmJ2knHOh lrPhiQyJgtnFjiYnQEkSys7vgwVVg/RIVzGEB9rUd05TLrQNp0ThuzUvmnWy5qkFSwz9 PNAnuAnkhqHto6UBO9fey7XivvjAw529fGrESc4V52Iet4gn0gR5yswicce1CM2e+LI/ iOrpLX9E6K8ITfyJhgUDnl8aVLF/aypyqRe8AG+20T+N4/FErNbkZm8iVdtAqzigHMzP qUsQ== X-Forwarded-Encrypted: i=1; AJvYcCVDrMxzM5yDyxJvUWZBcmX4+n8nVlvXeiwtIyrwYBgLTkQ2/xZUqSoZ+7446CVMUHb3D/0dG6vNWuJiq8igLZcYzlzb/GBEnzq+NtgILuxuWUPmks+GKVzXdFhBldatK0aiLWmN5F0kKhb5 X-Gm-Message-State: AOJu0YxhO2ai3dVZNAr75dLnYu0pe0SumKagMV/TsmYwQUtxqur1gy79 oLfEx7b+ny8xFNpcLqLp8S1EBukINsezRqz07jBGT870INzuRf6nl5iibuArJro= X-Received: by 2002:a17:906:1786:b0:a52:3eff:13f1 with SMTP id t6-20020a170906178600b00a523eff13f1mr5662000eje.2.1713767686928; Sun, 21 Apr 2024 23:34:46 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:69? ([2a0b:e7c0:0:107::aaaa:69]) by smtp.gmail.com with ESMTPSA id s24-20020a170906355800b00a524e3f2f9esm5357249eja.98.2024.04.21.23.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Apr 2024 23:34:46 -0700 (PDT) Message-ID: <2f505724-4b2c-48ee-90af-52f5d5fa95d7@kernel.org> Date: Mon, 22 Apr 2024 08:34:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] serial: exar: remove ternaries from cti_get_port_type_xr17c15x_xr17v25x() To: Parker Newman , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Parker Newman References: Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19. 04. 24, 16:17, Parker Newman wrote: > From: Parker Newman > > Remove ternary operators from cti_get_port_type_xr17c15x_xr17v25x() for > better readability. > > Signed-off-by: Parker Newman Much better. Reviewed-by: Jiri Slaby > --- a/drivers/tty/serial/8250/8250_exar.c > +++ b/drivers/tty/serial/8250/8250_exar.c > @@ -726,7 +726,7 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p > struct pci_dev *pcidev, > unsigned int port_num) > { > - enum cti_port_type port_type; > + enum cti_port_type port_type = CTI_PORT_TYPE_RS232; > > switch (pcidev->subsystem_device) { > // RS232 only cards Unrelated to this one, but // comments are discouraged in the kernel, IMO? thanks, -- js suse labs