Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2080195lqt; Mon, 22 Apr 2024 00:10:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUNazqHe8f1TUAJK8mXw7+T5kk1YcFTCLsVDRSsqkGtfzFzKAi7TivKJdKUFW4tE5UdWNVQav3ewHv9ckmAuvwB+70eqgvDM0d4HzVaKA== X-Google-Smtp-Source: AGHT+IF5SiOMQwIEI56rKayCFAMPjaphjjcJ0ddFr6V+duL9RbL8D+IkEsnFeNAjXepNUYqExlSV X-Received: by 2002:a17:906:39d0:b0:a52:3adb:e407 with SMTP id i16-20020a17090639d000b00a523adbe407mr4878842eje.37.1713769849102; Mon, 22 Apr 2024 00:10:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713769849; cv=pass; d=google.com; s=arc-20160816; b=DY1wx8grSIYHlggw3Dw0avKnqjQM+CUbPEbcVLzaopDk7ihCPNhv2KawvIOtMwErPW dgn5PWw/v480bDZjauvc70a51Qb+FzlsNkoJb+VVV8VDEaESpmDdT0HkkBmoaLHPB4Pd UM2UQIDMeQ1cIMzCe+gsjJaGwRHDiBLyi/D7ez16qmt7wpDNqEtzqAAnYGUHBDwWcb0Q pVu8DxKCL5H4q+phcBeOKwrBl1gG/uH87MJNGvdaNoR64aVHND+X2SwNjE9K/0M9Is0+ 6wFMl2yS1prZRaT+FoV2FhR33E6qAAei7KS5HB3AMGABMcLb2hed2hxc36JbQG1ggeek xXzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Z3YxL2BgDSBDJvO5eIKnjaWuRfoH+ejDqyVLxZ4obDs=; fh=g5Vs1VxAx2X8vmiL10fG4wDuSmQozck6+rQBLp7+mS0=; b=TFiP0lpamIhjhox7fTSaXf+mH5p0OJelbaNeHn5/y2qPYxYVbekf9r15DphRwn7R2d hPpGK9PB1zTZNWR1Bi97PJVmDE02Rb1YABTIufTgg3N80WvFG4MtqKegWOPASNqgwdOm 1jrHKi9GNT052eWxYNDLBflwvDyc/tcIGoLHYPYh1ZD4exJxCI5893t5gQqr8jsBtSqQ AWjwMlSsE41XpgJ3njWyXiswMMevCUjf/RP0LNtkspmhz7fVpXc2Xfoq68jQchybVCK1 tNc9Nj6DYdLIMXlbl+lZNK3qkwNJyIR6FcG4/bsNO8ukS7KDhmZDywsQ4cXt0YRpfk52 uyKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-152831-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152831-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z8-20020a17090665c800b00a46b8687eadsi5314452ejn.672.2024.04.22.00.10.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 00:10:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152831-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-152831-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152831-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CEF301F22037 for ; Mon, 22 Apr 2024 07:10:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1B5D84CB28; Mon, 22 Apr 2024 07:10:21 +0000 (UTC) Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADDA248787; Mon, 22 Apr 2024 07:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713769820; cv=none; b=P5DPxMb8jqJX2wdpAVW2YqoPaRsiL7Ol/BT+aezCYwQw0yurRufTR2DolE2CYuAUX2kJWXTVNoAKLLpWUFO+KfbI1rpiJqoHGae5dHznYOuXEAtW/ePiETStmCGQo4Yn7SuBdZ5lsZZ1PGfSm76fz2TNOWMSzSCRGCbysNi8UH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713769820; c=relaxed/simple; bh=iHcNO1X3e6+vWDzcfcynCoD9g0kl/l0PFPnGja/xXPQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K2mQsSF0XW37VCVtSejD31HNU7djf6xSfsyH/iJ7BZ7i7G1wTwLiQrFkoE+Drw/TiBeTP+tq6TIliCijFecHz5bYZHLdv64jEBS2YOSeIYnSilphEXfie6X59KrT6vIPijEbJEgpSQ6JYa8bFSnDC4HqXHDXsflg42XYi7ybr30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VNGbf33tFz4f3mHy; Mon, 22 Apr 2024 15:10:06 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 874851A0C79; Mon, 22 Apr 2024 15:10:15 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP2 (Coremail) with SMTP id Syh0CgAHdwpTDSZmt5eIKw--.7343S6; Mon, 22 Apr 2024 15:10:15 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org Cc: dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [ATCH v3 4/4] writeback: rename nr_reclaimable to nr_dirty in balance_dirty_pages Date: Tue, 23 Apr 2024 00:05:39 +0800 Message-Id: <20240422160539.3340-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240422160539.3340-1-shikemeng@huaweicloud.com> References: <20240422160539.3340-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:Syh0CgAHdwpTDSZmt5eIKw--.7343S6 X-Coremail-Antispam: 1UD129KBjvJXoW7WFyxZr1fGF17CrW8WFWkXrb_yoW8Cr15pF ZrGw4jkF4Iyayavrn3CFWq9rZxtw4xtF4fJry7Cw4avanrWF1UKFyI9ry0vF1xAa4fJrWa qws0qrykXw4vkrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPmb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAv FVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3w A2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE 3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr2 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lFIxGxcIEc7 CjxVA2Y2ka0xkIwI1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2Iq xVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r 1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY 6xkF7I0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aV AFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZE Xa7IU0TqcUUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Commit 8d92890bd6b85 ("mm/writeback: discard NR_UNSTABLE_NFS, use NR_WRITEBACK instead") removed NR_UNSTABLE_NFS and nr_reclaimable only contains dirty page now. Rename nr_reclaimable to nr_dirty properly. Signed-off-by: Kemeng Shi Reviewed-by: Jan Kara --- mm/page-writeback.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 38f143195bcb..f2c0237be602 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1694,7 +1694,7 @@ static int balance_dirty_pages(struct bdi_writeback *wb, struct dirty_throttle_control * const mdtc = mdtc_valid(&mdtc_stor) ? &mdtc_stor : NULL; struct dirty_throttle_control *sdtc; - unsigned long nr_reclaimable; /* = file_dirty */ + unsigned long nr_dirty; long period; long pause; long max_pause; @@ -1715,9 +1715,9 @@ static int balance_dirty_pages(struct bdi_writeback *wb, unsigned long m_thresh = 0; unsigned long m_bg_thresh = 0; - nr_reclaimable = global_node_page_state(NR_FILE_DIRTY); + nr_dirty = global_node_page_state(NR_FILE_DIRTY); gdtc->avail = global_dirtyable_memory(); - gdtc->dirty = nr_reclaimable + global_node_page_state(NR_WRITEBACK); + gdtc->dirty = nr_dirty + global_node_page_state(NR_WRITEBACK); domain_dirty_limits(gdtc); @@ -1768,7 +1768,7 @@ static int balance_dirty_pages(struct bdi_writeback *wb, * In normal mode, we start background writeout at the lower * background_thresh, to keep the amount of dirty memory low. */ - if (!laptop_mode && nr_reclaimable > gdtc->bg_thresh && + if (!laptop_mode && nr_dirty > gdtc->bg_thresh && !writeback_in_progress(wb)) wb_start_background_writeback(wb); -- 2.30.0