Received-SPF: pass (google.com: domain of linux-kernel+bounces-152864-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a00c375a9e96ea28f5d8cb0d0eaeb750ba462b17.camel@gmail.com>
Subject: Re: [PATCH v2 2/2] hwmon: pmbus: adm1275: add adm1281 support
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com>, 
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, 
	linux-i2c@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, 
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>,  Jonathan Corbet <corbet@lwn.net>,
 Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
Date: Mon, 22 Apr 2024 09:20:37 +0200
In-Reply-To: <20240422025123.29770-3-jose.sanbuenaventura@analog.com>
References: <20240422025123.29770-1-jose.sanbuenaventura@analog.com>
	 <20240422025123.29770-3-jose.sanbuenaventura@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Jose,

On Mon, 2024-04-22 at 10:51 +0800, Jose Ramon San Buenaventura wrote:
> Adding support for adm1281 which is similar to adm1275
>=20
> Removed extra case for STATUS_CML in adm1275_read_byte_data function.
>=20

Remove the above line. As nothing to do with supporting the new device. Thi=
s is what
it should be in your v2 changelog :)

> Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.c=
om>
> ---
> =C2=A0Documentation/hwmon/adm1275.rst | 14 +++++++++++---
> =C2=A0drivers/hwmon/pmbus/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 4 ++--
> =C2=A0drivers/hwmon/pmbus/adm1275.c=C2=A0=C2=A0 | 11 +++++++++--
> =C2=A03 files changed, 22 insertions(+), 7 deletions(-)
>=20
> diff --git a/Documentation/hwmon/adm1275.rst b/Documentation/hwmon/adm127=
5.rst
> index 804590eea..467daf8ce 100644
> --- a/Documentation/hwmon/adm1275.rst
> +++ b/Documentation/hwmon/adm1275.rst
> @@ -43,6 +43,14 @@ Supported chips:
> =C2=A0
> =C2=A0=C2=A0=C2=A0=C2=A0 Datasheet: www.analog.com/static/imported-files/=
data_sheets/ADM1278.pdf
> =C2=A0
> +=C2=A0 * Analog Devices ADM1281
> +
> +=C2=A0=C2=A0=C2=A0 Prefix: 'adm1281'
> +
> +=C2=A0=C2=A0=C2=A0 Addresses scanned: -
> +
> +=C2=A0=C2=A0=C2=A0 Datasheet:
> https://www.analog.com/media/en/technical-documentation/data-sheets/adm12=
81.pdf
> +
> =C2=A0=C2=A0 * Analog Devices ADM1293/ADM1294
> =C2=A0
> =C2=A0=C2=A0=C2=A0=C2=A0 Prefix: 'adm1293', 'adm1294'
> @@ -58,10 +66,10 @@ Description
> =C2=A0-----------
> =C2=A0
> =C2=A0This driver supports hardware monitoring for Analog Devices ADM1075=
, ADM1272,
> -ADM1275, ADM1276, ADM1278, ADM1293, and ADM1294 Hot-Swap Controller and
> +ADM1275, ADM1276, ADM1278, ADM1281, ADM1293, and ADM1294 Hot-Swap Contro=
ller and
> =C2=A0Digital Power Monitors.
> =C2=A0
> -ADM1075, ADM1272, ADM1275, ADM1276, ADM1278, ADM1293, and ADM1294 are ho=
t-swap
> +ADM1075, ADM1272, ADM1275, ADM1276, ADM1278, ADM1281, ADM1293, and ADM12=
94 are
> hot-swap
> =C2=A0controllers that allow a circuit board to be removed from or insert=
ed into
> =C2=A0a live backplane. They also feature current and voltage readback vi=
a an
> =C2=A0integrated 12 bit analog-to-digital converter (ADC), accessed using=
 a
> @@ -144,5 +152,5 @@ temp1_highest		Highest observed temperature.
> =C2=A0temp1_reset_history	Write any value to reset history.
> =C2=A0
> =C2=A0			Temperature attributes are supported on ADM1272 and
> -			ADM1278.
> +			ADM1278, and ADM1281.
> =C2=A0=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 557ae0c41..9c1d0d7d5 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -51,8 +51,8 @@ config SENSORS_ADM1275
> =C2=A0	tristate "Analog Devices ADM1275 and compatibles"
> =C2=A0	help
> =C2=A0	=C2=A0 If you say yes here you get hardware monitoring support for=
 Analog
> -	=C2=A0 Devices ADM1075, ADM1272, ADM1275, ADM1276, ADM1278, ADM1293,
> -	=C2=A0 and ADM1294 Hot-Swap Controller and Digital Power Monitors.
> +	=C2=A0 Devices ADM1075, ADM1272, ADM1275, ADM1276, ADM1278, ADM1281,
> +	=C2=A0 ADM1293, and ADM1294 Hot-Swap Controller and Digital Power Monit=
ors.
> =C2=A0
> =C2=A0	=C2=A0 This driver can also be built as a module. If so, the modul=
e will
> =C2=A0	=C2=A0 be called adm1275.
> diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.=
c
> index e2c61d6fa..2baeee8be 100644
> --- a/drivers/hwmon/pmbus/adm1275.c
> +++ b/drivers/hwmon/pmbus/adm1275.c
> @@ -18,7 +18,7 @@
> =C2=A0#include <linux/log2.h>
> =C2=A0#include "pmbus.h"
> =C2=A0
> -enum chips { adm1075, adm1272, adm1275, adm1276, adm1278, adm1293, adm12=
94 };
> +enum chips { adm1075, adm1272, adm1275, adm1276, adm1278, adm1281, adm12=
93,
> adm1294 };
> =C2=A0
> =C2=A0#define ADM1275_MFR_STATUS_IOUT_WARN2	BIT(0)
> =C2=A0#define ADM1293_MFR_STATUS_VAUX_UV_WARN	BIT(5)
> @@ -101,6 +101,7 @@ struct adm1275_data {
> =C2=A0	bool have_pin_max;
> =C2=A0	bool have_temp_max;
> =C2=A0	bool have_power_sampling;
> +	bool have_status_cml;

don't think we need this...

> =C2=A0	struct pmbus_driver_info info;
> =C2=A0};
> =C2=A0
> @@ -482,6 +483,7 @@ static const struct i2c_device_id adm1275_id[] =3D {
> =C2=A0	{ "adm1275", adm1275 },
> =C2=A0	{ "adm1276", adm1276 },
> =C2=A0	{ "adm1278", adm1278 },
> +	{ "adm1281", adm1281 },
> =C2=A0	{ "adm1293", adm1293 },
> =C2=A0	{ "adm1294", adm1294 },
> =C2=A0	{ }
> @@ -555,7 +557,8 @@ static int adm1275_probe(struct i2c_client *client)
> =C2=A0			=C2=A0=C2=A0 client->name, mid->name);
> =C2=A0
> =C2=A0	if (mid->driver_data =3D=3D adm1272 || mid->driver_data =3D=3D adm=
1278 ||
> -	=C2=A0=C2=A0=C2=A0 mid->driver_data =3D=3D adm1293 || mid->driver_data =
=3D=3D adm1294)
> +	=C2=A0=C2=A0=C2=A0 mid->driver_data =3D=3D adm1281 || mid->driver_data =
=3D=3D adm1293 ||
> +	=C2=A0=C2=A0=C2=A0 mid->driver_data =3D=3D adm1294)
> =C2=A0		config_read_fn =3D i2c_smbus_read_word_data;
> =C2=A0	else
> =C2=A0		config_read_fn =3D i2c_smbus_read_byte_data;
> @@ -703,6 +706,10 @@ static int adm1275_probe(struct i2c_client *client)
> =C2=A0			=C2=A0 PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT;
> =C2=A0		break;
> =C2=A0	case adm1278:
> +	case adm1281:
> +		if (data->id =3D=3D adm1281)
> +			data->have_status_cml =3D true;
> +

and this...

- Nuno S=C3=A1