Received-SPF: pass (google.com: domain of linux-kernel+bounces-152877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: <yuji2.ishikawa@toshiba.co.jp>
To: <sakari.ailus@iki.fi>
CC: <hverkuil@xs4all.nl>, <laurent.pinchart@ideasonboard.com>,
        <mchehab@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <nobuhiro1.iwamatsu@toshiba.co.jp>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v9 4/5] documentation: media: add documentation for
 Toshiba Visconti Video Input Interface driver
Thread-Topic: [PATCH v9 4/5] documentation: media: add documentation for
 Toshiba Visconti Video Input Interface driver
Thread-Index: AQHZ/NvaHbXU7u9nIUCLRWdm6z8y6rCGd6iAgBJieMCAXnQjAIB9uHig
Date: Mon, 22 Apr 2024 06:45:20 +0000
Message-ID: 
 <TYCPR01MB10196F6969BDAE599FF536E4F92122@TYCPR01MB10196.jpnprd01.prod.outlook.com>
References: <20231012071329.2542003-1-yuji2.ishikawa@toshiba.co.jp>
 <20231012071329.2542003-5-yuji2.ishikawa@toshiba.co.jp>
 <ZV3oq0szH8JjSNsc@valkosipuli.retiisi.eu>
 <TYAPR01MB620180FF82B8993B45FF6E0A9286A@TYAPR01MB6201.jpnprd01.prod.outlook.com>
 <ZbyQgkGicrnP-XZL@valkosipuli.retiisi.eu>
In-Reply-To: <ZbyQgkGicrnP-XZL@valkosipuli.retiisi.eu>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-2022-jp?B?NUw5R1M3Vmc1QUhMSmYrdzFSOTY5Q3JzMUxRZmlWaXNjU1hKZkt3ZFEx?=
 =?iso-2022-jp?B?YWpLZUsvS1JjK0gzcVJEQXU4bEpZS1JyZ2l5UWhjaVNLY1Z4S0dhZmM0?=
 =?iso-2022-jp?B?bWRoMjV0T09wbWZERUgzNzZCVUtKUjRrQkJnMWxxZktJdEtRTUpQMDkv?=
 =?iso-2022-jp?B?WTJ4cE5ma0NWOXRMVEtJZ0dCNyt2TXphZ3dybUFhZUtpNS8vUytHc1lz?=
 =?iso-2022-jp?B?cnVtLzlob3FEZU5XL2h5SjdBMHp4WHZmL0I1WkxTMGd3VWw2VGNvUm9y?=
 =?iso-2022-jp?B?cGFnd2pvQ3JhaTdhQVQwYXJWaURNS3NUVWkyT3hFdmhRMG4wNmVzYWFZ?=
 =?iso-2022-jp?B?WHY2MDZlVnNkQnRzWTZJTTI0YmxMVHdWdVpaWko5Wm9DV3ZmbFJUeGJs?=
 =?iso-2022-jp?B?Zm5vQUlkSDkxRmM3VlovRFV4RWg3Rno5U21oRTlXazBuZStHeVVSdGZk?=
 =?iso-2022-jp?B?OVlMQlJZREpjTm8zdnNhVVdPWVJucnFVR05BSFdPYk80Sll1YUF2MGsz?=
 =?iso-2022-jp?B?WStUb3JsL2FXYmxHWVltbWc2TFB3NkpkeEE4NkZrUjNHLzByN3R5R1hr?=
 =?iso-2022-jp?B?bjFwZ3ZYWG5iNGk1VVFjZVlyN3BXZW5abDI5eHpCL0l3bGRyb0grT05P?=
 =?iso-2022-jp?B?WlU3dWYvU2oyemR3Q01MUlQzaHBrclQ1bVQ1U0pJV2x1ekRZVjdIbVl6?=
 =?iso-2022-jp?B?aE5ZMzB6RjRFd3o2TFZzb2kwbEx6ODVuM2p1NFdyOHcwYkVYTGZnb084?=
 =?iso-2022-jp?B?K0ZsdE5pQXVNWHB5R1UyRTR5eThZYVpyZFJISFlIb091UDhxWkdyUFoy?=
 =?iso-2022-jp?B?ZldrTHRNa0RUSkdWU2QxNEJXRmltOUovaFR6MlBSYzQyOWRmUnR3UVlQ?=
 =?iso-2022-jp?B?VEk1dFdVWjBKZTJOa0FUVTVSK2VyZDIreWZBcE4rekRwckNkK2lYZWp1?=
 =?iso-2022-jp?B?UHpoOHgzOUk4Qm5DTUgvNXZBdm5zbGNtZWdEdjRGQVkxQTZFRDB1NFg0?=
 =?iso-2022-jp?B?VWprZ0xMandaNGtRMkYxdzBiWmlwcktYR29lMVdjdEFyMEpjZkVnUmZr?=
 =?iso-2022-jp?B?eGNXMms5YlpRdlpPeEg4VkVTYW12UnR4QmpXaEl1NnRlUUtzVVVVblFv?=
 =?iso-2022-jp?B?V1ZLZk9xaFdrZmUwRnRjSW56UnJhb1NmZXlCSng4b1p0NWdvSndmRWNX?=
 =?iso-2022-jp?B?Wmc0aENBc2NhQzEvSnFTRzdjbnFTTFR3eEZPbkpqSXBPZXgwMUNvaGJW?=
 =?iso-2022-jp?B?NkRHZVJjb050VUdNSFBjSWIwQ1d6eDVQNzRQVXZ0NDJaNm4wZE5iNHVa?=
 =?iso-2022-jp?B?amtNQmtzYzRkQkd0Nk5MdlNsUFU3azJ2UUt4ZVRNTVg4Z2Zpakg0M3g5?=
 =?iso-2022-jp?B?c3pZazQ0OXBSd2tGYTFrSUNUUklyRWpaTGJ3SGh3U0FCV1p3TjlUT1Vu?=
 =?iso-2022-jp?B?emlKOUxhb3FPeVJyVE9HenhtYTdDNDl4ZXpEczU0KzBVaWFLVCtUOFdB?=
 =?iso-2022-jp?B?djJyNnIxWmdPcTNIRHpKdXdQZUtCeXg5RGtGQXdXVjFJNXFUMzZrRFFr?=
 =?iso-2022-jp?B?OGVVTUZoN0twZHR4TlZNZUlWOW5LSk9vS3dkMEI1aytKeFRWeWpJcFhH?=
 =?iso-2022-jp?B?bnhVZTJoTGhiUFpBaWhoUTJNRWprWUpjZ01qRGcxUy82cUpxRzhqSDZl?=
 =?iso-2022-jp?B?OWp4YkJzbnhYOS9NUFc1RnVqTzNaZGx6bE1EZjhlVk4xbEd1L3AvdmNs?=
 =?iso-2022-jp?B?NStGS0tQSEVua2IrQkNmeEErSnQzc1p3UFhjSjROZ1pIUEJCdVh1MlR2?=
 =?iso-2022-jp?B?WEdWL3lubHdnQXowS2F4VXVkckwxQTdPQjAyK05aZG5GanFlbnBHQW9r?=
 =?iso-2022-jp?B?S0FhUGFjQmRNOEZuR082RGpyZDBjNWhTK2lyK1BXcG8rdXl0eFVhMkN1?=
 =?iso-2022-jp?B?dEJreWV4cEhTSUNzY0Y5cFJwM2JwcStQUlNyR01KQis5bHB4clgySFVL?=
 =?iso-2022-jp?B?ejB6cktmOVRneE9UQWhZNnBnZEYzOFRCNTB2WDdCYkNDZFpYRkpkUkJ6?=
 =?iso-2022-jp?B?Q2FWV3kvMHgrNmxidDJQV1MzdkFyL25aY0FNSEI3NDk4N0lCd3R2UVVN?=
 =?iso-2022-jp?B?eVZ1WVExdmNIdVB4MG5YbnRSVU5hYW12RmhUa3RMK2NTUnkzTHBWK1p5?=
 =?iso-2022-jp?B?cjQxNi9wbVRXL0NrOVJrMlJSSzZTOUp1NGtDSkMyOElIMC85cGdaU25s?=
 =?iso-2022-jp?B?Z1QzVDNFTCtXSXNicTBZVHBjenQ1ajZQNC92dkZmZUhGOW9IN0c1TVY4?=
 =?iso-2022-jp?B?ejNOeTF1SFJOUXlqNkdYajJ5WGMwbGQ1UXc9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: toshiba.co.jp
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10196.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f8605a5-0dd4-4805-683a-08dc6297c7ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2024 06:45:20.9195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nziLOOFZ4RCqwE+yKY0lTJ8MHiV6pHNgDS8u/+k4DLup7O2NNIPZ+L8N3dwT4R0W3645wd4EyU0Eh4CVNHxCC7a/f1kzXlHcL6HKUZsUG1o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8549

Hello Sakari,

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: Friday, February 2, 2024 3:50 PM
> To: ishikawa yuji(=1B$B@P@n=1B(B =1B$BM*;J=1B(B =1B$B!{#R#D#C""#A#I#T#C!{=
#E#A3+=1B(B)
> <yuji2.ishikawa@toshiba.co.jp>
> Cc: hverkuil@xs4all.nl; laurent.pinchart@ideasonboard.com;
> mchehab@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org=
;
> conor+dt@kernel.org; iwamatsu nobuhiro(=1B$B4d>>=1B(B =1B$B?.MN=1B(B =1B$=
B!{#D#I#T#C""#D#I#T!{#O=1B(B
> =1B$B#S#T=1B(B) <nobuhiro1.iwamatsu@toshiba.co.jp>; linux-media@vger.kern=
el.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v9 4/5] documentation: media: add documentation for
> Toshiba Visconti Video Input Interface driver
>=20
> Hi Yuji,
>=20
> On Mon, Dec 04, 2023 at 04:32:40AM +0000, yuji2.ishikawa@toshiba.co.jp
> wrote:
> > > > +Vendor specific v4l2 controls
> > > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D
> > > > +
> > > > +.. _V4L2_CID_VISCONTI_VIIF_MAIN_SET_RAWPACK_MODE:
> > > > +
> > > > +V4L2_CID_VISCONTI_VIIF_MAIN_SET_RAWPACK_MODE
> > > > +--------------------------------------------
> > > > +
> > > > +This control sets the format to pack multiple RAW pixel values int=
o a
> word.
> > > > +
> > > > +This control accepts a __u32 value defined as `enum
> viif_rawpack_mode`.
> > > > +
> > > > +This control should be set before ioctl(S_FMT) and should not be
> > > > +changed
> > > after that.
> > >
> > > Why do you need this? Doesn't the V4L2 pixelformat already
> > > explicitly define the format, including packing?
> > >
> >
> > This control value affects the unpacker between CSI2 receiver and ISP.
> > The rawpack mode is an option to receive from Wide-Dynamic-Range image
> > sensors, whose output bit width is larger than standard format (RAW20,
> > RAW24). For example, some WDR image sensors split 20 bit value into
> > upper/lower 10bit values, then put them into consective pixels to make
> > a double-width RAW10 format image.
>=20
> Do you have a sensor that really does this? Which one is it?

Our HW specialist has indicated that the VIIF HDR input expects some SONY H=
DR sensors as its source.

Because the VIIF was developed prior to the official release of RAW20 and R=
AW24 formats in the MIPI CSI2 specification,
its HDR RAW input feature is controlled by a vendor specific "rawpack" regi=
ster.
Also, the proprietary software stack has "rawpack" flag.
The expected bitstream formats associated with "rawpack" align with the off=
icial RAW20 and RAW24 formats.

I now understand that rawpack flag is not used for non-standard pixel forma=
ts.
I'll remove rawpack flag in the v10 patch of the driver.=20
HDR RAW input feature should be controlled by V4L2 pixelformat or media bus=
 format.
However, RAW20, RAW24 support will be dropped in the v10 patch because modi=
fied part is not fully tested.

>=20
> >
> > This option is only related to the interpretation of CSI2 input data.
> > Therefore, I think V4L2 pixel format (for resulting image) is not
> > related to it. The media bus format seems more relevant, but there is
> > no corresponding definition to this case.
>=20
> --
> Regards,
>=20
> Sakari Ailus

Regards,

Yuji Ishikawa