Received-SPF: pass (google.com: domain of linux-kernel+bounces-152881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <142380d5-27bd-4ddc-8c33-03a2f8701fa2@intel.com>
Date: Mon, 22 Apr 2024 00:35:45 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 15/14] x86/gds: Lock GDS mitigation when keylocker feature
 is present
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	<linux-kernel@vger.kernel.org>
CC: <x86@kernel.org>, <dan.j.williams@intel.com>, <bernie.keany@intel.com>,
	<charishma1.gairuboyina@intel.com>, Josh Poimboeuf <jpoimboe@kernel.org>,
	<daniel.sneddon@linux.intel.com>, <antonio.gomez.iglesias@linux.intel.com>
References: <20240407230432.912290-1-chang.seok.bae@intel.com>
 <20240419-gds-lock-v1-1-adcbef6ce24b@linux.intel.com>
Content-Language: en-US
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20240419-gds-lock-v1-1-adcbef6ce24b@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDdxaTZrUTEzTlR2YlljUFFJb0cxeHB5ajZmdmduTlVKby9ueDc3Yk1lWFV1?=
 =?utf-8?B?YWZQcDM2SDhiR1FyYjN5MzZZWWFSZ1JUVW10UEJGYlBPVUZqQldORkp6QThE?=
 =?utf-8?B?dXFoeDNpMitaWkdLMm1uVzl3a1pXOGJ4cXJyRFNJMDY0SnJZMkRFWUdkYm5L?=
 =?utf-8?B?OVZnYkUwa0xUUUoyRlprdDEwU3ZmK2dKSXdRbGdCK1R0eVlEY043MDN3VTRm?=
 =?utf-8?B?QWFTYjFTVU43aWVvaTZ6QkJkNEZIcy9vMm52bTRCdWREQUlQaExBY3lEWllY?=
 =?utf-8?B?NVRQQUFpd0ticVNEL2FYYnd0MGhWN2JVY0lvajU1VHJKZzY1UkNKU2puaGVs?=
 =?utf-8?B?NHlrSXN6QWxRcFhpV3N6Z2dYN0RvMVdVL09kQkYzYzRvdTJaaDZzU3BEcVdO?=
 =?utf-8?B?UFk4dzlIRmJIMklCMEpLRHBTZW1VQlN6SjdXdHNBOEJoNXUzWHV0VGhGaWNo?=
 =?utf-8?B?dHl0TTlmd3VSeFJ3RXBUZjlaMHV6dVozT015NXY4Y3FGSnhoanpYTWRqcTEv?=
 =?utf-8?B?VVd2ZU82Z3RXa2kvSXhsd2Y0b0hvQTFVcW9XODk2YjRETk9peWpyc0VzU2xq?=
 =?utf-8?B?MXpNU0s2R2FiUFR0Wm5UYWdzTVJVMENmTWxiWEo0ZGF1S3JRdHlUK2dUSFlY?=
 =?utf-8?B?RG1ZOGsrN3ZRTjBUOVNKaXJaVmltL25hdG5rTGlpZFVicUxjMFZKWDVkamVs?=
 =?utf-8?B?a1V3MFRxOExBYmpwSDVRbldUSktwY0pWWUlKMHVXK2lMNCtwMXZuWml2d1Ba?=
 =?utf-8?B?T2FReEdGMXhreGYrbmhMWWprc3VzSGZIa1FDM0FmaVRTMThpQllxYlByUmdJ?=
 =?utf-8?B?T2M1VFBQTUlRbGtMNVA1VzlSM0F2eUErOU9NaDVHd3JFbUZLWUdUNUx5NmNR?=
 =?utf-8?B?Y0p3Z0dqUmJ0Tm1OMGVEays3QXJOVm5PV2d4Z0h5V0ViQ1licGxCaWVZNEt2?=
 =?utf-8?B?RDg2WjFteDB6NTdvUkUrMXhJT0szL0YrdTR3bThYUVd0UWtBeUdud0hlQ3FZ?=
 =?utf-8?B?SmNFdkh5TlowdGc0ZHB0RWx6TWppNGdEdGNpQTBWbm1tVGF0KzBQU0ZiTkUw?=
 =?utf-8?B?VE9SNlorNFVvN1ZvZmhhcW1WdEUvWEM3N2VaRFVVcjVIcWlVNWMzbHJkbTNT?=
 =?utf-8?B?MTQ5MndPODN1SFljaERhZzVnQ05FdkMzNVFCTlNpSEkraWU3eUVTRVE3S212?=
 =?utf-8?B?TllyeFh5MkUrWU5aTEpOWWQyQnhsMTJ3b0RMVTBIemdrTEFZOGNNQ003OURR?=
 =?utf-8?B?RjlrY2JVVEVXWlVwOC9PMmw1ZUx1YWdubk03RzQvTFlUd3JENkRQSmpBWWt0?=
 =?utf-8?B?Tk5xSXZkQXpmRHFFaVk3cHhPcTdjcUhhVHRCcVc5WXlzQldZTnE0eWpsOG5N?=
 =?utf-8?B?R1hrNTFsNHRwSno4UHNkeXhQdHQwczlSTmxGTU9sa0xhMDZiQ2VGR0lZMDRu?=
 =?utf-8?B?VVFMR0lRWjhGYTFxUjRDYVhseWZKRlNrSTBqL05yY2RFV0xHYVkvQ2Q3aWEx?=
 =?utf-8?B?LzgxMllDa3RGdWluWUhQYlFVb09iNlJKNi9Jb2pReWZMb0ltVGtIL1MvRm1q?=
 =?utf-8?B?ZVJhWVJuNnU5ODZ5RDZ3c1pSamFpRXBLNDhMNHNyVDlXVmlNN0ptRk4wZGlC?=
 =?utf-8?B?MmtDb0VhUy9sRjdmc05LN3doWDFoVWwwbUJxZDE1cGpwRnF6SEJuVmQzd2FL?=
 =?utf-8?B?ampkYi9rb3gzRlZZbmRuVGk4OVlENUp4aUZ6Q0tOOUlHQXZPalB1NTJOT0lp?=
 =?utf-8?B?bDBiak9JeFh0ZDJRcGRJc01mcU1scDBnSEYxUUU5VlB3YzFwNXVsaU9Kd2Zq?=
 =?utf-8?B?NlBOb1BMRUIzbFEvOG15Y2YwbnM0Y29MWGtmVzBRQVRxOWJkMnVLQkhEdmpj?=
 =?utf-8?B?MzZqaXVtTXdDdUlGNThoeG5hMEl5Um03V1ZOdGxtTWZqRVFEa3plSklGaVhV?=
 =?utf-8?B?d3Z1bUozdjAwSXJuT1FuS0JrdEdYUmNMUmxYZWtkY1dsazQ0YWVoQjU1L1Uz?=
 =?utf-8?B?YUY5MGFiOStXZUtRYmZyWllKOHN3S1ZGZXZtODVkSmRIZktMamhCOWs5VGcx?=
 =?utf-8?B?eWMzSTVJWkNjdi90dDUzZWFEMHE5eHpCbUlITFpQYUVUbU1nWXJwNzNHaW9q?=
 =?utf-8?B?b1Q2Uk90bmZrZU0vN3JMYzlwd3h4VDBDU09zcDBIZXIrUzladnV0aUdvVHU4?=
 =?utf-8?B?WXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4778c130-0e12-401c-9ef7-08dc629ed37d
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 07:35:47.3759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YaLYQQ/jHA9gPYPONs/oI17WfL/KeBNzPiZuH9QD/okD/wiL48UXYTsTKtBmBy4snF/XeqMJTdHjm2Q0eJ51r8XisnHaYdm9htijmIxj01M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5180
X-OriginatorOrg: intel.com

On 4/19/2024 10:47 AM, Pawan Gupta wrote:
>   
>   	/*
> @@ -840,6 +843,11 @@ static void __init gds_select_mitigation(void)
>   		gds_mitigation = GDS_MITIGATION_FULL_LOCKED;
>   	}
>   
> +	/* Keylocker can only be enabled when GDS mitigation is locked */
> +	if (boot_cpu_has(X86_FEATURE_KEYLOCKER) &&
> +	    gds_mitigation == GDS_MITIGATION_FULL)
> +		gds_mitigation = GDS_MITIGATION_FULL_LOCKED;
> +

I'm having trouble understanding this change:

gds_select_mitigation()
{
	...
	if (gds_mitigation == GDS_MITIGATION_FORCE)
		gds_mitigation = GDS_MITIGATION_FULL;

	rdmsrl(MSR_IA32_MCU_OPT_CTRL, mcu_ctrl);
	if (mcu_ctrl & GDS_MITG_LOCKED) {
		...
		gds_mitigation = GDS_MITIGATION_FULL_LOCKED;
	}

	if (boot_cpu_has(X86_FEATURE_KEYLOCKER) &&
	    gds_mitigation == GDS_MITIGATION_FULL)
		gds_mitigation = GDS_MITIGATION_FULL_LOCKED;

As I understand it, gds_mitigation is set to GDS_MITIGATION_FULL only if 
the gds force option is enabled but IA32_MCU_OPT_CTRL[GDS_MITG_LOCK] is 
not set.

Then, if the CPU has Key Locker, this code sets gds_mitigation to 
GDS_MITIGATION_FULL_LOCKED, which seems contradictory. I'm not sure why 
this change is necessary.

I'm also not convinced that the Key Locker series needs to modify this 
function. The Key Locker setup code should simply check the current 
mitigation status and enable the feature only if proper mitigation is in 
place. Am I missing something here?

Thanks,
Chang