Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2093311lqt; Mon, 22 Apr 2024 00:44:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWYmA5sw5t97dam0Bic48CZovZ2nvdxloXmlyLSLiiByTT11ap66d8PZzB//vRvx8ZOW2PWJBk+vmiwmqulkaY5gkatz2RzPU9yXhxdqA== X-Google-Smtp-Source: AGHT+IHz6CevayENjT/9Er9xWxcIrC3u0CI/Eh4h2efASYB4m0YFAJjbeekNa945zhXTHU+X4tqA X-Received: by 2002:a05:622a:1a11:b0:437:9b1b:263c with SMTP id f17-20020a05622a1a1100b004379b1b263cmr11269178qtb.11.1713771858404; Mon, 22 Apr 2024 00:44:18 -0700 (PDT) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ff10-20020a05622a4d8a00b00437c0121802si8394190qtb.446.2024.04.22.00.44.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 00:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152890-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-152890-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152890-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 273F11C210E3 for ; Mon, 22 Apr 2024 07:44:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A213C502B4; Mon, 22 Apr 2024 07:43:13 +0000 (UTC) Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86E4B50283 for ; Mon, 22 Apr 2024 07:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713771793; cv=none; b=nABE89S1Yeb+v37/6XQnWTv1Tadjs8PoPGQOdPe3neG3erW0YxZXrhPxvDa3VcpMHqSaL39oM/En92fsHClbOfwBO9j4Og/T9hsgKbDRkoMlljYaR24xhwjNVQDSGieiupoMcoRkQROk8hYCqjk/NojBulDatMJQxnp4hmlccXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713771793; c=relaxed/simple; bh=ew5dSgQMfS9IwbBwrIa9E4pKL0iPTREwTY8/gbHfluY=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fjtJNnJta4xiUnqJKhUUYykBXiIljo8/UlFZfrU6Ig0xlkManTioTSQz4p2tnb0EAiCKUgbD8FZr8xSvjCpOJLAnoWDlqO3zXmFCdgkoMGaCC5c3rDNL701IlhFQXQ2p0ST2sgir/NXfwE1cngpmAvH+Z2KO14bjsFd+DgCCt1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id f64f7c0a-007b-11ef-a9de-005056bdf889; Mon, 22 Apr 2024 10:43:09 +0300 (EEST) From: Andy Shevchenko Date: Mon, 22 Apr 2024 10:43:08 +0300 To: Bjorn Helgaas Cc: Vidya Sagar , "Rafael J . Wysocki" , Len Brown , Will Deacon , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Frank Rowand , Thierry Reding , Jonathan Hunter , Krishna Thota , Manikanta Maddireddy , Vidya Sagar , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH v7-incomplete 3/3] PCI: Unify ACPI and DT 'preserve config' support Message-ID: References: <20240418174043.3750240-1-vidyas@nvidia.com> <20240421190914.374399-1-helgaas@kernel.org> <20240421190914.374399-4-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240421190914.374399-4-helgaas@kernel.org> Sun, Apr 21, 2024 at 02:09:14PM -0500, Bjorn Helgaas kirjoitti: .. > + if (host_bridge->dev.parent && host_bridge->dev.parent->of_node) > + return of_pci_preserve_config(host_bridge->dev.parent->of_node); If you need fwnode or of_node from struct device, please avoid direct dereference, we have dev_fwnode() of_fwnode_handle() dev_of_node() -- With Best Regards, Andy Shevchenko