Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2094370lqt; Mon, 22 Apr 2024 00:47:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWPB0El2Bwi331IbdoU2zeL7pfjNrtzc0DgQKvotVzGwX6BcR4l+rnrK9V3Tve6CjeEgt+5Vl0Z9Mx8ZIb4rJnwXbrv1xZ22xWLK3gO+Q== X-Google-Smtp-Source: AGHT+IHapRaXYq+ok5sx1qplbDyN8w/3x9yVdzJwOBb2GWowo0IyT7jW1GJ3J37NUD92Xvrg7eQ6 X-Received: by 2002:a17:906:4fcc:b0:a55:6f2e:b87f with SMTP id i12-20020a1709064fcc00b00a556f2eb87fmr8008119ejw.8.1713772039938; Mon, 22 Apr 2024 00:47:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713772039; cv=pass; d=google.com; s=arc-20160816; b=YcHycULpIxBoLTHCRusc4sMGWUnV4sqqOioGkhdR7eZOcTLGZR47iYkoDeH+pIQ7m0 Ji9qPrLPQFkpMvg4/UGsWkRWVVyMkBfXt6DLV3LukyzcrNwjnoM4HQJ55dngKNn5G5LU dzH1b1IgWS4ZCbExZT4oEeLQf8NeNFiIbyMoUOgjRNVdKCv+xeepkpaPbGRQPj+bwepU bld+VogBY+aD1QPP4W+gB+tdVQnDGBGNgKvy6cWBgJFH+gwZN9Vgf6OVTG0SYJOROqm4 PJ1gWQ1u1YsWcXiJbwlH56jaHH+WxbRVoGC3xW0UBHsBozXqsVQWTXrlLsf7JKFaDEcE u7PA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=tAe+40gLKBnN7tnSK2raXsnb43veTPVq2GfkuOlipxU=; fh=k4AMVoRlNTZoICULjfxzki5iyloEog4c0YPUz9KkUzc=; b=UAtBuRprU/FuaVUVGpvb4GJzV6JbCaJuEkN/fZgcOqAOKQwAUdIT2tBkAPhz4WYnJw oHYo5D6ohWVEzo7fUi55tjs7koUxNy7PJX3cihFDKI12x0vGZvyr0f/swkx+Hv8Jo05E vBEKxA1QyKVZgwUdyDh4RXVwJLjfCBIiFtuTtaV+u9T8CZtU+3D5s1+Me3fhLTpefZV4 w7NPhm9DHlwnoC8dNu4/dDKdQCCkcAnA1ewobiYh6bSMvo1EJVl42rNgnWprsS8GWlz+ NOcK4jtNsNQEeQRPrAJRo75J9+mF7zg+CZ2PfhJrJDbA/WhfWIdkzfSv6quOgEy9LAru mhdg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dFlBmh58; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-152899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id c8-20020a170906170800b00a55bc088f5fsi534329eje.290.2024.04.22.00.47.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 00:47:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dFlBmh58; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-152899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7F48A1F20FB2 for ; Mon, 22 Apr 2024 07:47:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADD394D9E7; Mon, 22 Apr 2024 07:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dFlBmh58" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FCD74CDEC for ; Mon, 22 Apr 2024 07:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713772028; cv=none; b=EQ8vwnuLH9C9gtdwtLvvkG5OzdkhF9tY4tNdWsAuuyWl/9wFhpFmEZcoQy8BhiS5w7FOSlCdqXSRkQL/RfkAqgjJy+iN5HmtSuIaZcUo0jXF4wmUQxAd5QmCpD2kvJbriRH5REx4FRrNMnGGxgECvDdC2MbbxMXPfjurph6MEeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713772028; c=relaxed/simple; bh=A/M54EsLbdpEhtTAZGHPIjfGvTW/Os6fVYqjTxlwATg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cr/D3mSyaxdkA0Ct4RP9f0NWDG/Q2MJ7xpwjeDkBYiVklC1SXQ/sGzZisi9uA82yQENrJiGdWer9dkexzdsVuwIiMtGm7Ju6WxvLSMkw0WglM2S3M7M9M6CNmq5IG5xEOeYUI2HEkZPWX38SkU82LOm831srZQ5ddo+sn5AX0Xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dFlBmh58; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713772026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tAe+40gLKBnN7tnSK2raXsnb43veTPVq2GfkuOlipxU=; b=dFlBmh58Oav49QhgdmmMAPmZmVo4mUQ29lHFsfduTIYpyknQo3Cywa1AW0XvFkh1u6AO9/ Chx4MegT8f6uZL+ZcYmlSDOiHDD3qJZEPcGaq1TqT81BtPrH7RKx2ORbCa4IgWXOPYisRl nDb5mQQpJGf+hA3TMni+EkqjHdIJhGk= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-xo18L82BPbyH82ef4b6j-w-1; Mon, 22 Apr 2024 03:47:04 -0400 X-MC-Unique: xo18L82BPbyH82ef4b6j-w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d87d146022so34895621fa.3 for ; Mon, 22 Apr 2024 00:47:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713772023; x=1714376823; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tAe+40gLKBnN7tnSK2raXsnb43veTPVq2GfkuOlipxU=; b=RTuP7BvWGfWYNTgPWJlAIcAsPVvvmg5bPNYUD4SAAvgedeiq7De2E3FthIn6+zhzTV tEdop2T8yb67jshZrW/O8ZZhADuE4CsN7iA3m/RWt3DXE1ytUNkxreFRCvrwwqD/g1LG dikTXdhwN32B/pqxGsAJYGHiw4LgncHKI6HD5sP1MXusea4xnlYo2dN/kf+rA8GZTynu m5e6NnRgto3RVYj/g3cxnqtKzZO1eOLyB2mKxYHaSgmZAWmCwR0NL9Xv+eKX1uZ+NHNX sSRCPkQ4QOrErZoTFrJnbjeq5b2lt7ir9EHj10EK8W/SrDE7HDNA6Memca11QrVoJYMb Guhw== X-Forwarded-Encrypted: i=1; AJvYcCVBVJdsk3qkCjMkdWZEDmaNBbd0l6IzP13xkNeKq71WXIvrsp+o8Y6bs+OE6niXqFURnXiYsK/K64R6yYkkqAFniaUsw84FIXTUChg/ X-Gm-Message-State: AOJu0YzifAiClUB15ztLdILw8iD4nQ69pWQBlnZgvpLRUBTrtJaRilFC AmzjeNkilCKUiWg2awKNvhcVEw7IbIQA37/oklV5gddwq0WBjfj4334VtuceOICGTOhG0fWcDIG tBjOi6R0MJwjDjUhOHwkTd8JH5h9Nsh8+vyy3ueUn2V2tHW2exWkW1ChXGVxD9g== X-Received: by 2002:a2e:b5ac:0:b0:2dc:bd75:41ba with SMTP id f12-20020a2eb5ac000000b002dcbd7541bamr5950598ljn.27.1713772022973; Mon, 22 Apr 2024 00:47:02 -0700 (PDT) X-Received: by 2002:a2e:b5ac:0:b0:2dc:bd75:41ba with SMTP id f12-20020a2eb5ac000000b002dcbd7541bamr5950582ljn.27.1713772022432; Mon, 22 Apr 2024 00:47:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:600:d2fb:3a8a:9944:7910? (p200300cbc7390600d2fb3a8a99447910.dip0.t-ipconnect.de. [2003:cb:c739:600:d2fb:3a8a:9944:7910]) by smtp.gmail.com with ESMTPSA id j10-20020a05600c190a00b00418a9961c47sm15670401wmq.47.2024.04.22.00.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 00:47:01 -0700 (PDT) Message-ID: <6a182645-1f7f-4b7d-a16a-36e9b1684c58@redhat.com> Date: Mon, 22 Apr 2024 09:47:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] virtio_balloon: separate vm events into a function To: zhenwei pi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org References: <20240422074254.1440457-1-pizhenwei@bytedance.com> <20240422074254.1440457-2-pizhenwei@bytedance.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240422074254.1440457-2-pizhenwei@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.04.24 09:42, zhenwei pi wrote: > All the VM events related statistics have dependence on > 'CONFIG_VM_EVENT_COUNTERS', once any stack variable is required by any > VM events in future, we would have codes like: > #ifdef CONFIG_VM_EVENT_COUNTERS > unsigned long foo; > #endif > ... > #ifdef CONFIG_VM_EVENT_COUNTERS > foo = events[XXX] + events[YYY]; > update_stat(vb, idx++, VIRTIO_BALLOON_S_XXX, foo); > #endif > > Separate vm events into a single function, also remove Why not simply use __maybe_unused for that variable? -- Cheers, David / dhildenb