Received-SPF: pass (google.com: domain of linux-kernel+bounces-152950-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 22 Apr 2024 16:09:33 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>, Linus Torvalds
	<torvalds@linux-foundation.org>, Daniel Sneddon
	<daniel.sneddon@linux.intel.com>, Pawan Gupta
	<pawan.kumar.gupta@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Alexandre Chartre <alexandre.chartre@oracle.com>, Konrad Rzeszutek Wilk
	<konrad.wilk@oracle.com>, Peter Zijlstra <peterz@infradead.org>, "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>, Sean Christopherson
	<seanjc@google.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Dave Hansen
	<dave.hansen@linux.intel.com>, Nikolay Borisov <nik.borisov@suse.com>, "KP
 Singh" <kpsingh@kernel.org>, Waiman Long <longman@redhat.com>, "Borislav
 Petkov" <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4 1/5] x86/bugs: Only harden syscalls when needed
Message-ID: <ZiYbPZ1biNCEndKZ@yujie-X299>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <982d05a2f669140f26500bee643011896d661094.1713559768.git.jpoimboe@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FZzSqId8q/Nu1b7Ials9mue7N44OzFnhbeCjwRfiar0Q1ZnTFfJ6J69o8ee0?=
 =?us-ascii?Q?tPrqK5nSFJvqP9OsIgdoZjZHQApalMTmseHxR7QdVPnv57spFQ0vyQvS8ugI?=
 =?us-ascii?Q?djq++w3ubVztX/Fg4lBw7MUcEX7bh69ATK/NOt3tcEiK29ExAWwqPRXxP20k?=
 =?us-ascii?Q?4K5fmLzdEbvUPqPPoD2iO/rWIbr1NgpVku5pqX15KisPEn+pYl7/pEB7KbgO?=
 =?us-ascii?Q?RvxQYdfMO83wT+tqxc70itF3N42ktO82+Fwo6No/e8hCi6s3iYt3RBFLZTwi?=
 =?us-ascii?Q?BklLy4oUnLNJkLC4FbCccRzyGnTRDNv8XKEfGNYtrKxob6rlueqG6qHhW+y9?=
 =?us-ascii?Q?56mqe41PsZs0EDrh4YisXB32gs5+Q3l+OjFpHcJ+h+zqYjvquJm2cFFpDXQJ?=
 =?us-ascii?Q?9OhKYYPvqrjBQfsVuyOx5u+BcLSRXx3W3bbcfsQIlC6osLvYrWK4A5NsmrNF?=
 =?us-ascii?Q?woA2WzOAjEeW9d0Ut21fWc3dY/1jN5/GyrHTPURn/APMvDlVVB+JFRPYq/Ij?=
 =?us-ascii?Q?VJz6pxYtAGILG+ZqBJ+asAvzhxkqoQQM7/9WV+70Pd/88uTm3tCh6Q7ZTmr3?=
 =?us-ascii?Q?tS8TnjGhAgKy+dnAhAhJJf3lZMjhag2GZi/uErqBDY73af5+nrRSCTNk1trR?=
 =?us-ascii?Q?UBKvR683UnvjevswH9UoAroU5vLTV1MPh910K4VfnDIbTN11zZ0XSNl0d0PE?=
 =?us-ascii?Q?+db0by7bij+MVQKSMR3mBIbY4F/x90M/08CiRkT03f5CTlzsZJTf941Ut4aE?=
 =?us-ascii?Q?JZESokxPQJBnUmhjrJ3P9rRXyvQuSZO5Am0qXPUYLtMA9ZBmEEMoIXhLcOm+?=
 =?us-ascii?Q?B75lUwvlj3WTBVqEGQPyVLaYHYtXLQH4dbG6quglH3HdhJGTltI977likDqa?=
 =?us-ascii?Q?druxsnwf7tVkrEv/wp9ZFmh0DbtCTuaWinW8b0WMkb1QylGyicokHISM4oFF?=
 =?us-ascii?Q?K9tgsu2QzjtLnGc+TZoJqjQXdzw02RTDCPCYWLXBU4txZjus5CO/m2dWuEB2?=
 =?us-ascii?Q?cCQvw670soFUX90OtePRjV4HIkIWgUslNgvykxooCKBYjlihOjgtkKZyB+9U?=
 =?us-ascii?Q?SiMFJrnnIkeDZSlqATb8+j1x0Uy1rSv8/cFTidSQUDJIcv8z/ZdJFQiu7TKw?=
 =?us-ascii?Q?WP8hEEpnXZIGaOP4KbymGCZ39OHN9c/cKy7Br1GdNmQ+z/Ubltzbpa/lC7Up?=
 =?us-ascii?Q?i4ldXtsDXXmlXCgaRp77S8itT6FGjZ3Riar5qpqZHRGtllp6L0WvOQ7ARy84?=
 =?us-ascii?Q?XtLksdWbpoYRwQB/vEektMa7SanFUdHsYf4+sWDqB2X0C2h8+SgED14pguT6?=
 =?us-ascii?Q?IJfg6Qon6Lvf/X8m7/9RoyxTZypF8tX7B6NfRXH60/EHEh+BvzWk2tmJVGrD?=
 =?us-ascii?Q?yQ2v98oVS+YgctJ1l4j/3/FJ4Ww+7ljQpqH1KviJwL9Pm46Sa2/motM4KbaQ?=
 =?us-ascii?Q?Sec86yFo1WIxGeDBwuYO9j+ixwPNPoExKpu5sMkEvSoXQAu7AecOup4MYC13?=
 =?us-ascii?Q?pEu+kcfkvgvnlynFd1kgKwj1R21zmJKqCGXbp32C8qInXXFJyoLaAx45byat?=
 =?us-ascii?Q?jxTJldWanCrUJ9Tk18pUkjZT/KXAlOWxiCCq/xYe?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 00cab06a-3af6-46a6-3b44-08dc62a47885
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8393.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 08:16:11.7631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a8X+fDTJx0fP/ZkLMO3OXZA268YMnhEe7BewkcdlbjU/60qlZ87D/befk+DB0ULivHFRMATDy0pf45EFSaxZTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7559
X-OriginatorOrg: intel.com

On Fri, Apr 19, 2024 at 02:09:47PM -0700, Josh Poimboeuf wrote:
> Syscall hardening (converting the syscall indirect branch to a series of
> direct branches) has shown some performance regressions:
>
> - Red Hat internal testing showed up to 12% slowdowns in database
>   benchmark testing on Sapphire Rapids when the DB was stressed with 80+
>   users to cause contention.
>
> - The kernel test robot's will-it-scale benchmarks showed significant
>   regressions on Skylake with IBRS:
>   https://lkml.kernel.org/lkml/202404191333.178a0eed-yujie.liu@intel.com

To clarify, we reported a +1.4% improvement (not regression) of
will-it-scale futex4 benchmark on Skylake. Meanwhile we did observe some
regressions by running other benchmarks on Ice Lake, such as:

    stress-ng.null.ops_per_sec -4.0% regression on Intel Xeon Gold 6346 (Ice Lake)
    unixbench.fsbuffer.throughput -1.4% regression on Intel Xeon Gold 6346 (Ice Lake)

>
> To fix those slowdowns, only use the syscall direct branches when
> indirect branches are considered to be "not OK": meaning Spectre v2+BHI
> isn't mitigated by HW and the user hasn't disabled mitigations.