Message-ID: <479A317D.6020202@goop.org>
Date: Fri, 25 Jan 2008 10:59:09 -0800
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: Yinghai Lu <Yinghai.Lu@Sun.COM>, "H. Peter Anvin" <hpa@zytor.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: trim ram need to check if mtrr is there v3
References: <47993F1A.5070408@goop.org> <200801241947.55223.yinghai.lu@sun.com> <4799930B.40006@goop.org> <200801250042.53074.yinghai.lu@sun.com> <20080125110935.GA20026@elte.hu>
In-Reply-To: <20080125110935.GA20026@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1228
Lines: 41

Ingo Molnar wrote:
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>   
>> [PATCH] x86: trim ram need to check if mtrr is there v3
>>     
>
>   
>>> H. Peter Anvin wrote:
>>> Looks like the code doesn't check that the CPU *has* MTRRs...
>>>       
>> so more strict check if mtrr is there really.
>> bail out if mtrr all blank when qemu cpu model is used
>>
>> and check if is AMD as early
>> also remove 4G less check, according to hpa.
>>     
>
> thanks, applied. Shouldnt we put in an exception for when there is MTRR 
> support, but they dont cover anything. Still emit a warning - but 
> booting up real slow is still better than losing all of RAM and crashing 
> ...
>
> i also updated the messages, they now go like this:
>
>   WARNING: strange, CPU MTRRs all blank?
>
> and:
>
>   WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 45MB of RAM.
>   

Though I don't see this form of message; have you pushed your changes 
out to the public x86.git#mm tree?

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/