Received-SPF: pass (google.com: domain of linux-kernel+bounces-153019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240421173750.3117808-1-cmllamas@google.com>
In-Reply-To: <20240421173750.3117808-1-cmllamas@google.com>
From: Alice Ryhl <aliceryhl@google.com>
Date: Mon, 22 Apr 2024 10:48:50 +0200
Message-ID: <CAH5fLggC597GVm3QQGi+VeqUNBJk6vfq2eQSKgGyUZfS6dHVqg@mail.gmail.com>
Subject: Re: [PATCH v2] binder: fix max_thread type inconsistency
To: Carlos Llamas <cmllamas@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>, 
	Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>, 
	Joel Fernandes <joel@joelfernandes.org>, Christian Brauner <brauner@kernel.org>, 
	Suren Baghdasaryan <surenb@google.com>, Serban Constantinescu <serban.constantinescu@arm.com>, 
	linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 21, 2024 at 7:44=E2=80=AFPM Carlos Llamas <cmllamas@google.com>=
 wrote:
>
> The type defined for the BINDER_SET_MAX_THREADS ioctl was changed from
> size_t to __u32 in order to avoid incompatibility issues between 32 and
> 64-bit kernels. However, the internal types used to copy from user and
> store the value were never updated. Use u32 to fix the inconsistency.
>
> Fixes: a9350fc859ae ("staging: android: binder: fix BINDER_SET_MAX_THREAD=
S declaration")
> Reported-by: Arve Hj=C3=B8nnev=C3=A5g <arve@android.com>
> Cc:  <stable@vger.kernel.org>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>