Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2122580lqt; Mon, 22 Apr 2024 01:59:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV4bby9R1RBUB9Khp5SJ/S2DMKeeD0auifIXZmwsimphkCX8olHNGr1zCy/TSYLIeTfZcPPueWjOT9mPFYbJdxR09+CQOHE6XtnQGTqUQ== X-Google-Smtp-Source: AGHT+IFK2y54Wbz0WpTg1GIs67PWe3xNHFVCuBHAVHUSH/N1zO7SopoVrQ+jFM0VmxySeOz8Yftz X-Received: by 2002:a05:6a00:1889:b0:6ea:f05d:d2e9 with SMTP id x9-20020a056a00188900b006eaf05dd2e9mr10567064pfh.15.1713776392018; Mon, 22 Apr 2024 01:59:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713776392; cv=pass; d=google.com; s=arc-20160816; b=z1xxlKk+1mlwi3uFORLXsSWcOup4iySiHLvhV3uaCxtMKrTq/VgAaNrXSSLfXtQCt7 D3dcXgui+vK8VeDAArRCbsOdrClMa+qcj8JeKackJ+OghuYHOEayjXAhm6ARR7P0iaOv AWYFDruaBEgUkenMXLtT8pCYuVs6vT2xsbo4yOKGGMUztpW1E5nfhu/0Ze3mPDybcdrH Erk40lk7DZ36jZ4SeFtglw5yX15aNcHZJbCedkLR/6ipSGMTiiTH8DkKqn+EWRUpDyFH ZjJ/KmE5tViZ+u+3frCjk8n/ApyV4foikeJjWbcDHj8vX8ZgX78lDUkE5RENz9skt8fl smrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=4gJcZxq06/54EIVNvP+HKDhC0R5HKhA2ic01BvjnljY=; fh=jsUa5otwDnngFueBLV9h/1opIqpaiKyP+aKDIncMlC4=; b=rJlTrEjBsyEP57Y4JNBwURjfpxyjodmoXyaLEdEQMK4KB2MPQVYpQG4slVgruv3gU1 jw4jTCHiQ7uOfptk7OC6mSFhLzopo5sO/X7GK2+A7ZC1NYhjsr3JXo59XrRRpLRZWKW/ uzRapx8lKzBiHRN/IocDD1ilYmEF/rl2A270CSAhIRWWZGyN8KdMed/+j9vUfpD+IyOj cmi3nlB4XPxAUB9duwjSkOcCQIhCMITR1U9bfvYXU8g129BEbWvUltq4HHKp171cZjMe Vu2NKTEG4hop6MVqi7N3vsEI1LkAWPie3IZaBbsK1yrAycmlRYJjDU0f/7058kL59bzl SzrA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-152980-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152980-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id lp13-20020a056a003d4d00b006e6a17088e1si7685190pfb.46.2024.04.22.01.59.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 01:59:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-152980-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-152980-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-152980-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6C807B20B3E for ; Mon, 22 Apr 2024 08:32:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95C5C502A9; Mon, 22 Apr 2024 08:32:44 +0000 (UTC) Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EDD5433C2 for ; Mon, 22 Apr 2024 08:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713774764; cv=none; b=XWAz1BP8GWCDSqIpyzPtjr/dJhJG1aZVYdLnZjFGwiXRekeHdN7Xy7rPUIlKqtykkuY5iOWh58gWXK6tDesL3cqXnAnGXaoYqsz4ioyxW3sM8jpc6lcYiSLNjVVYfxGwDx5if/L0sSoyk1JT9HJaojnppP72KHAZG4zbjQAP8ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713774764; c=relaxed/simple; bh=psC1NXyYFFU81tuyqjnY6lvR07j1XHlE3uIZYen4cbM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G9mrfluke6nrUWU3IDuY/vqQrz5PqXe1ZDPCVzWmdFsaKy1E3bWIxL1CqNFNvPMqMNEgC/3REMRkQAw0LJoX2msM5iGkknr36/tcZ/LY+B/XVMyv6vldH3WV5rJkK5jzRusfR5oUfjDNwl4F7FeUX1eesiigycwYM8jFPSIukcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id e0d47807-0082-11ef-a9de-005056bdf889; Mon, 22 Apr 2024 11:32:39 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Guanbing Huang , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Subject: [PATCH v1 1/1] serial: 8250_pnp: Switch to DEFINE_SIMPLE_DEV_PM_OPS() Date: Mon, 22 Apr 2024 11:32:37 +0300 Message-ID: <20240422083237.207447-1-andy.shevchenko@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Andy Shevchenko The SIMPLE_DEV_PM_OPS() is deprecated, replace it with the DEFINE_SIMPLE_DEV_PM_OPS() and use pm_sleep_ptr() for setting the driver's PM routines. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_pnp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c index 8f72a7de1d1d5..9188902fa5b35 100644 --- a/drivers/tty/serial/8250/8250_pnp.c +++ b/drivers/tty/serial/8250/8250_pnp.c @@ -10,6 +10,7 @@ */ #include #include +#include #include #include #include @@ -506,7 +507,7 @@ static void serial_pnp_remove(struct pnp_dev *dev) serial8250_unregister_port(line - 1); } -static int __maybe_unused serial_pnp_suspend(struct device *dev) +static int serial_pnp_suspend(struct device *dev) { long line = (long)dev_get_drvdata(dev); @@ -516,7 +517,7 @@ static int __maybe_unused serial_pnp_suspend(struct device *dev) return 0; } -static int __maybe_unused serial_pnp_resume(struct device *dev) +static int serial_pnp_resume(struct device *dev) { long line = (long)dev_get_drvdata(dev); @@ -526,14 +527,14 @@ static int __maybe_unused serial_pnp_resume(struct device *dev) return 0; } -static SIMPLE_DEV_PM_OPS(serial_pnp_pm_ops, serial_pnp_suspend, serial_pnp_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(serial_pnp_pm_ops, serial_pnp_suspend, serial_pnp_resume); static struct pnp_driver serial_pnp_driver = { .name = "serial", .probe = serial_pnp_probe, .remove = serial_pnp_remove, .driver = { - .pm = &serial_pnp_pm_ops, + .pm = pm_sleep_ptr(&serial_pnp_pm_ops), }, .id_table = pnp_dev_table, }; -- 2.44.0