Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2128950lqt; Mon, 22 Apr 2024 02:11:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVUyvhHB2Ugu9toORnaTLTZhL0UF1kbX6P3rMG1xM3GbaSHiZ9GVETo7ufQCLrqWseMgyfg4q4dsMJ3XUzO5t/8mzyxXEB01iW9DTgmYg== X-Google-Smtp-Source: AGHT+IH0XBrojX93PThnlstIJc2d0rc3fTyNPhn9BSfBbQdag+dzXRuDdktEmAQMBUNcFd3rVZNA X-Received: by 2002:a05:6830:3b8b:b0:6eb:786a:a5a1 with SMTP id dm11-20020a0568303b8b00b006eb786aa5a1mr10097622otb.7.1713777084710; Mon, 22 Apr 2024 02:11:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713777084; cv=pass; d=google.com; s=arc-20160816; b=NW1/zAFA7dHAy+rm9nTyxJdUxGl17WXUlVrUEYIKc9Z7haEZfJ7OzbOOcrLruKzZ6h Q00ZZqThVl+U5iXECk8HR3EtXkdvoOMAKD8VIoD9I0R0T2vQsVUYRKfSZ4b3QIpvM4FU cajImfYT4IEI9JtrSSxP7/7OUEnYA2EpGCjnGybDvlLm32LdYqiwSTiRcLDCrGEkxXP9 dgrKwW6PcfZtwZoiJISCDa0eSngc6+urYfDeHb4E/VKVuOwPqWZi2eVyoBq68KYuQezU blbPY2kE7M6h1SkyDv3UaKUbFvjB4YXLYnbCdlZ5IN78KXX3cEj8+2J8wKXP4RTYEIXE 934g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=4CnDrkxxBFnWZDA6Pwu3mbT+0pyJYbjZWrLnSJVrNYQ=; fh=uMzUsWafD5qjDjyJ8genJVHJawp79w4gEmctOOUUVc8=; b=UHgGIf/NnIhgjTwWHU/FjtRY9deSdV7DJqzIEwyGb7H/NfuETSngrDwLA9NcpOOVIN OAYhYxibfSKqfKgoan96D6bQeU3DWpYwDaOoY88TO1hJxiMaAGrmA3AHlMT9o8b+c1oc H2IyQDPfXY7TsyoeQ11+4C7F5Oi1ux7e2RCTmm5Q+pKgBOQE8OVarMprNt4WlNmlcaQt Oa1BkV4AZfNt9HzJx+35uPM+p2yXNsCM4Z8a5tnFG/RN9vco1YQMJKLKVI3yFhqrERmQ I/uU/Pv8ICfZOwOPRqjH/hOWxwzOVfa0+LsaLgu9TYz5fw1ktTmLaL85ViawNePv+a2Z oLXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A1YGp4tN; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-153065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153065-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c6-20020a631c46000000b005f3ffb05f56si7395023pgm.162.2024.04.22.02.11.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 02:11:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-153065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A1YGp4tN; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-153065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-153065-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CA6CB28160F for ; Mon, 22 Apr 2024 09:11:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64E015490A; Mon, 22 Apr 2024 09:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A1YGp4tN" Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92DC5101A for ; Mon, 22 Apr 2024 09:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713777070; cv=none; b=utVWK5lVVd+Wq8iwaM5rqKTfa6ONSd8x1edZhwte2fKe8WkiiEJEib1M9ILg5nIZ/uyIo4m/8Nq5XcFo6UkR7ffzDKWBNuGQ/MxDfX/Agd6dFj7bWMXfLvZRKBpLCF9SQbnK+kvsNvvDWbRo+f7NcVIwt7ZvsPU6ws+JYazM4Hg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713777070; c=relaxed/simple; bh=cA6gH+89i3S2aDbgZe0BaKQ9KddkyoFC/iJQXRWOcCg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tICoIeZb53Rjoro4aLokdJOQQO4aWER2A0q/6dVb0a1Dth6sgqY9pgnFAvFpwwoSwWFKqo8XAIOoHwQIwi0C1GtHlfV5DZ8kVd2uelelvLkbrYIG3vjyYj2aGkAhgHyqvxPr7Vdnd4OiKZBE4qM1e8f0XTasuNpNmvMdioJES7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A1YGp4tN; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a44f2d894b7so389752466b.1 for ; Mon, 22 Apr 2024 02:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713777067; x=1714381867; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4CnDrkxxBFnWZDA6Pwu3mbT+0pyJYbjZWrLnSJVrNYQ=; b=A1YGp4tN/LgO9oAyWwu3ovx9gYFqyk3T/AN4VrVoBwMOhwdPCvE6rWE7e7dAb+ON+D 8YGNdHDeTJJ3h9t31twbwVDDxsatBPDfV6y5dTBNJ7knQmQ9U0yKZQJzA/TrB3ZhN32b CbGM4pK8hroPi4oSqn58mDLCiCMGO+wHvn9V0qUSRtdhkrZUM4AfQpRTaYXXCme5UY8i xk2MJ/A4Gi+KBSZcVrDTG4ypa7OMbL+8ZiMPC4hT4L3qsG4LxARWBFp/ufgOqEnjVprU 4Dv4H6Pw/tpx0obyDzx6OZkYuc400qFhUcw4BLyjnL1AeCtgLoj9+tWm+BosQgH3wlau 39pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713777067; x=1714381867; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4CnDrkxxBFnWZDA6Pwu3mbT+0pyJYbjZWrLnSJVrNYQ=; b=kzVIiwPcGZEliZWvag7LK//G8xSjYKZ4XG3XGLoNPr6qXfzx4ZG13/PDMsZovAj4e0 i7EOVmn/ijlo33eYJ03zukSB+QZZKNai0grg6kdXr5bYokNfug6b8dgc8N74wYo6CPfi 6+Gd0bSkDdzIFX9XFPaxDAX/1gUAjWoy6n1+4UHt7+bgTZ0ugQQE2wY/8AGFB39unJeP DGaggftPKgmL/3BPNSvmSf7vvYLIEWaHIm/WOL3AkM0I/5/Pg5gIpQOiZGf6Wdk/yzSb odaYMgUyfuzUPDjhgj2JvaQEZFOWES+C+zQoAmivOAZfhE+ysNtAGgMLVHxl0i5PbsmQ a0wg== X-Forwarded-Encrypted: i=1; AJvYcCW+x2Jr4om7CCVey4MxT+UZjJc8B+zLrrNtZCnGXPFhGN+8gQMbkG83YaHJ1CtiL5zl/iNpfwKuwAQ0kGDEQ6rYmgf+SaWDGCGZFO4p X-Gm-Message-State: AOJu0YwivFC5P9K8u96iW4nXd7wQvb0WBY5GmGWONHI6XZYT8BxjJelE bTRUbt4pbMjFfRqgBYPkPbWF+XZfNEsS0UD8PWEuGokxS+GzLVAwpVSLSVLsmbo= X-Received: by 2002:a17:907:724b:b0:a55:b021:c0b1 with SMTP id ds11-20020a170907724b00b00a55b021c0b1mr2895842ejc.9.1713777067211; Mon, 22 Apr 2024 02:11:07 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id q26-20020a1709066b1a00b00a53c746b499sm5491547ejr.137.2024.04.22.02.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 02:11:06 -0700 (PDT) Message-ID: <40856e22-e5e2-4030-8ddf-89c02efc9514@linaro.org> Date: Mon, 22 Apr 2024 11:11:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: net: mx93: add enet_clk_sel binding To: Steffen Trumtrar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Clark Wang , Linux Team , Alexandre Torgue , Jose Abreu , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20240422-v6-9-topic-imx93-eqos-rmii-v1-0-30151fca43d2@pengutronix.de> <20240422-v6-9-topic-imx93-eqos-rmii-v1-1-30151fca43d2@pengutronix.de> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240422-v6-9-topic-imx93-eqos-rmii-v1-1-30151fca43d2@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/04/2024 10:46, Steffen Trumtrar wrote: > When the eQOS on the i.MX93 is used in RMII mode, the TX_CLK must be set > to output mode. To do this, the ENET_CLK_SEL register must be accessed. > This register is located in a GPR register space. > > Signed-off-by: Steffen Trumtrar > --- > Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml > index 4c01cae7c93a7..1d1c8b90da871 100644 > --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml > +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml > @@ -56,6 +56,16 @@ properties: > - tx > - mem > > + enet_clk_sel: Except what Sasha wrote, also missing vendor prefix. That's not a generic property. > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to the GPR syscon > + - description: the offset of the GPR register > + description: > + Should be phandle/offset pair. The phandle to the syscon node which > + encompases the GPR register, and the offset of the GPR register. That's redundant. Provide full description in the items. You can say here what is the purpose of this phandle. Best regards, Krzysztof