Received-SPF: pass (google.com: domain of linux-kernel+bounces-153058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <74f2bd5b-8e2a-4915-a60b-f4f9d04981a4@theobroma-systems.com>
Date: Mon, 22 Apr 2024 11:06:55 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add dual-role usb3 hosts to
 rk3588 Tiger-Haikou
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org, Heiko Stuebner <heiko.stuebner@cherry.de>
References: <20240418210332.2394871-1-heiko@sntech.de>
 <20240418210332.2394871-3-heiko@sntech.de>
Content-Language: en-US
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <20240418210332.2394871-3-heiko@sntech.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dzNNWlc0T2NJRU5yK2x5YnNQWVBWMFk4Tzlta0ZkVWNGeXBGSFFGWDJkdWFi?=
 =?utf-8?B?NlpmNUxlVk5SM09yVmJ2U2xZZGV4SW1qeHVwK05rdzVkWU45ZmZ4M1pMMDFD?=
 =?utf-8?B?aG5LRmUxbmVEaVlRcnErNStsd1FIL1Bsc24vVzlvMzFzZmIrcDE0Nythd3c4?=
 =?utf-8?B?ZUQxRzMvMnZ0bjVJZkJkSEpTTkVCZ3VEQm81c2dVZUZWaVpKaEZvVk9CdGFF?=
 =?utf-8?B?eW1LQUNpbU5pL1VDeW9LOE5YQWhYT2NIeXoxdjFwZkhHbytrYnBOZDdjR0tM?=
 =?utf-8?B?UkJHekE1d21IM0RLeGhCWlJuUG13aFdUQWNtT0RHbkxxbXNvWmJoYUREK29M?=
 =?utf-8?B?aGhtUlh4ZzczL0cxYS9yMEl0cDdINW84SkpuM0pGSVBEamlQNXJ4N29aVmt4?=
 =?utf-8?B?NkVrQ3c5NkFVZ1RNUk5FbnMzdkhITWZ4SWowclpjTVdQbnhMa29TSzQ2bEdY?=
 =?utf-8?B?VUVOcmh5clMrVVpEbzQ2M3ZXeTNpbnlKRkxaSU1PSDJOSkhZV3I5MUtid1dW?=
 =?utf-8?B?ODQ4Rk9NN09KWEtybVdmTXByOXBqT0xYN3htMWROR3RHdjY1MnlaV01TU0pk?=
 =?utf-8?B?TDY3SHFzMldEVU45ck9JUTVxVmxwamJyNWo5N1liNHZvUHNzZE8vZ3EzWlJ3?=
 =?utf-8?B?dXFPTnBrUCtBOHlYY3pjU0FHZUhWQXhLWWJaTkpoQmlmckpYUnd5Z1l0Z3Ri?=
 =?utf-8?B?MHBCeWRYZW1UWTJrWUxDc1ZkMEFmY2dxUkR5QXlvODdpZHE0ZDhwUHhDdEZl?=
 =?utf-8?B?U1hQRStpbWZ3QXpMOUFHWHR4Umt6R1habC9mbTdER1ZxZnhKYS9nUHcxMTNR?=
 =?utf-8?B?N0pMODRRNml1a0w3cTRCYTRoN3RZQkZZWG93QUZxSTNoR2p5aEV1U2hjT0pT?=
 =?utf-8?B?SmdycVJmNEtqcjk4SnJ3NzN4dThOc0crZmZac1dSMnJMT0VFV29lZm5oc21B?=
 =?utf-8?B?NnkyTVREaTA2NmIzVnpmbGFtRDFMTGpzS3hTd01BS1FCQ1VFNHIvUFpKMHVQ?=
 =?utf-8?B?NUFKTVVCMVhVcnNCN3ZjVnBkNGt0MUNEeXJTSUs4Ym0zR2dCeWpTd2J1bWpt?=
 =?utf-8?B?RWEvS0hJeExRcXc5bjFyVkttU1duUTBPdml2Wm02TjhzVW1aeVE2L1VtYnJX?=
 =?utf-8?B?d2VPSEFLYlkvSXE2MjEySS9JMnZ6WGlLZzFtdFNkY1U0Wi9aTThCMEZSV3ZE?=
 =?utf-8?B?M1Q2YytBRmhLTkRlT09oa0x2Q0JkdnhFS3k2QnVvdklXd09CNUwwYXZtRFJF?=
 =?utf-8?B?NkFPWnI3QTVOcUYwUkMzcld5dWJCVyt3RXhVZlczWjhWMk1DZG1vbTUrdzg2?=
 =?utf-8?B?YkUwdStzZVpEYXdQcERMN3Z1SzZJR0phM2s2N0QxVU4xUXcvNUxZNlN4aUYx?=
 =?utf-8?B?S1ZibW53QjJOYXQ4eDFRYmNKdzdQdzdnWFBKMVJuNzl0cVlWVy9IQzZRZ2ZU?=
 =?utf-8?B?bEs4dmJSd3BvV0taZGxzbTI4U2kyU0Zkck1pMzk3TVJGUVNKMHhxTXlKVzFG?=
 =?utf-8?B?UFYwaTRjengvM1ZpdWpRVjJuNVJGYWtxVVZORWVXT0lmOFZJUUlBOGE0T1pE?=
 =?utf-8?B?V3c1aVNPZFBxM3lDYk56cW1tMUgzZmMxTExsSHRlVTVBbDVQK2RYTHBzR2du?=
 =?utf-8?B?RUR5MnlZd0hLR3FJSjNzSWMzeDl5d0tRVTBNNS95VUFaeUplS3V5My9aL2Ji?=
 =?utf-8?B?SEg0Y293d3Rhc1E4UlovME1mWTd5YjJnZFBrSWJZVUU3T09mb3lIek9nMlhB?=
 =?utf-8?B?dVZIQk8yM0t6S0VtekFMQnBxRjZ0YXBrZ2lTVFAvRHNwelBNTUpKUXMyWkds?=
 =?utf-8?B?YTkrNGhNeUdPT2Z1VWF2Rk5HYXZJQkI1bHd4bFJUQll4RVZESTBxbkpjUm8x?=
 =?utf-8?B?a0x5Y28yNEFBRFJUMFBjNHNsdlB1aG1sc3VyVzl5bmFncHo2OHE4ei9yWFVK?=
 =?utf-8?B?QjlzV2hqVEpKaW14RXVlWGNrT1Z1UkRKT2x3L05rbW0wczViLzY4d3M0OXo0?=
 =?utf-8?B?ZEhMRFhCemk5bDZRNTZQck54Sm5wOEt4NGFKdUpObXVaL3d6VHVyek1vOC9Q?=
 =?utf-8?B?MmVhajlYU1B3ajIydHlLemJUell5YnpvTFBXbDlHMjVydnVEUE5VREJHNGJm?=
 =?utf-8?B?VzR0a3VGRkR5Skl6UCtheTBDT0EwNC8vZW0rQ25MdUViSkdPQmtsNU9WY3Zw?=
 =?utf-8?Q?nJW8qNKb064mZQTGDlxouuM=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac46bf3c-3f19-42bf-c9df-08dc62ab8ff1
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4842.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 09:06:57.5331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OeUveV2iLgTDFlW/bzJg+di3kunPkBE4fMiijH0cHcxvPz18jt99EjsKSG+VOc/VwfXdr+E2X72WmxhGmmqH0Xxq5XvHYpVcJ7LbXUqgrVqulSwICSKEMxJbna+QhvJ5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8613

Hi Heiko,

On 4/18/24 23:03, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> Apart from the host-only usb3 controller (host2) the rk3588 also provides
> two dual-role controllers. On the Tiger-Haikou combination these are
> connected to the lower usb3-host port in host-only mode and the micro-usb3
> port for dual-role operation.
> 
> Add the necessary controllers, phys and usb-id extcon to the Tiger-Haikou
> board. The Q7 standard defines the pin as usb-id, but it will only ever
> get used if the baseboard actually provides an OTG port. So the extcon
> stays disabled in the dtsi and only gets enabled in the haikou dts.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>

Would have preferred two separate commits but the content is fine and 
it's not that difficult to review, so

Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Thanks,
Quentin