Received-SPF: pass (google.com: domain of linux-kernel+bounces-153128-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Content-Type: multipart/signed;
 boundary=cb134ca7a9f8e269b067b74597d138b5ec5c5ba6f747c56adefe89ccdc46;
 micalg=pgp-sha384; protocol="application/pgp-signature"
Date: Mon, 22 Apr 2024 11:53:35 +0200
Message-Id: <D0QK66M6GGD7.2ESAAEDMDOUUO@kernel.org>
Cc: "Ricardo Ribalda" <ribalda@kernel.org>, <linux-kernel@vger.kernel.org>,
 <linux-mtd@lists.infradead.org>
From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>, "Pratyush Yadav"
 <pratyush@kernel.org>, "Miquel Raynal" <miquel.raynal@bootlin.com>,
 "Richard Weinberger" <richard@nod.at>, "Vignesh Raghavendra"
 <vigneshr@ti.com>
Subject: Re: [PATCH v2 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()
References: <20240419141249.609534-1-mwalle@kernel.org>
 <20240419141249.609534-6-mwalle@kernel.org>
 <ea3b32a8-7a1c-4a32-beb5-acc6f6435954@linaro.org>
In-Reply-To: <ea3b32a8-7a1c-4a32-beb5-acc6f6435954@linaro.org>
Precedence: bulk

--cb134ca7a9f8e269b067b74597d138b5ec5c5ba6f747c56adefe89ccdc46
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi,

> 	if (name)
> 		info =3D spi_nor_match_name(nor, name);
>
> 	if (!info || info->id) {
> 		jinfo =3D spi_nor_detect(nor);
> 		if (IS_ERR(jinfo))
> 			return jinfo;
> 	=09
> 		if (jinfo !=3D info)

info could be NULL here. So "info &&", apart from that looks good.

> 			dev_warn(();
> 		info =3D jinfo;
> 	}

Pratyush, should I'll drop your Rb tag then.

-michael

--cb134ca7a9f8e269b067b74597d138b5ec5c5ba6f747c56adefe89ccdc46
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZiYzoRIcbXdhbGxlQGtl
cm5lbC5vcmcACgkQEic87j4CH/hq0QF/W5w0LJO/Tlly9UKjiQWmjTnpkfEPgTaQ
Tp+tPIGsjpj72mnmkuBX4/JHyRKMGEelAXwOghOr7t3XVLc8EW+UQdr3cd4WmZET
4jwa6114y252B2D2XwB3Xr0k8qnU+QELAQs=
=AUVn
-----END PGP SIGNATURE-----

--cb134ca7a9f8e269b067b74597d138b5ec5c5ba6f747c56adefe89ccdc46--