Received-SPF: pass (google.com: domain of linux-kernel+bounces-153155-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 22 Apr 2024 11:09:34 +0100
From: Catalin Marinas <catalin.marinas@arm.com>
To: Shiqi Liu <shiqiliu@hust.edu.cn>
Cc: will@kernel.org, broonie@kernel.org, anshuman.khandual@arm.com,
	maz@kernel.org, suzuki.poulose@arm.com, miguel.luis@oracle.com,
	joey.gouly@arm.com, oliver.upton@linux.dev, jingzhangos@google.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/sysreg: Update PIE permission encodings
Message-ID: <ZiY3Xhcg5hH5ZTB4@arm.com>
References: <20240421063328.29710-1-shiqiliu@hust.edu.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240421063328.29710-1-shiqiliu@hust.edu.cn>

On Sun, Apr 21, 2024 at 02:33:28PM +0800, Shiqi Liu wrote:
> Fix left shift overflow issue when the parameter idx is greater than or
> equal to 8 in the calculation of perm in PIRx_ELx_PERM macro.
> 
> Fix this by modifying the encoding to use a long integer type.
> 
> Signed-off-by: Shiqi Liu <shiqiliu@hust.edu.cn>
> ---
>  arch/arm64/include/asm/sysreg.h       | 24 ++++++++++++------------
>  tools/arch/arm64/include/asm/sysreg.h | 24 ++++++++++++------------
>  2 files changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 9e8999592f3a..af3b206fa423 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -1036,18 +1036,18 @@
>   * Permission Indirection Extension (PIE) permission encodings.
>   * Encodings with the _O suffix, have overlays applied (Permission Overlay Extension).
>   */
> -#define PIE_NONE_O	0x0
> -#define PIE_R_O		0x1
> -#define PIE_X_O		0x2
> -#define PIE_RX_O	0x3
> -#define PIE_RW_O	0x5
> -#define PIE_RWnX_O	0x6
> -#define PIE_RWX_O	0x7
> -#define PIE_R		0x8
> -#define PIE_GCS		0x9
> -#define PIE_RX		0xa
> -#define PIE_RW		0xc
> -#define PIE_RWX		0xe
> +#define PIE_NONE_O	UL(0x0)
> +#define PIE_R_O		UL(0x1)
> +#define PIE_X_O		UL(0x2)
> +#define PIE_RX_O	UL(0x3)
> +#define PIE_RW_O	UL(0x5)
> +#define PIE_RWnX_O	UL(0x6)
> +#define PIE_RWX_O	UL(0x7)
> +#define PIE_R		UL(0x8)
> +#define PIE_GCS		UL(0x9)
> +#define PIE_RX		UL(0xa)
> +#define PIE_RW		UL(0xc)
> +#define PIE_RWX		UL(0xe)
>  
>  #define PIRx_ELx_PERM(idx, perm)	((perm) << ((idx) * 4))

Thanks. That's indeed the better way to write these constants, they also
match the POE_* macros further down in this file.

Currently nothing is broken since the PIE_E0 and PIE_E1 macros are only
used in assembly where the UL() doesn't have any effect but we may
change it in the future. I'll leave it with Will to pick up.

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>