Received-SPF: pass (google.com: domain of linux-kernel+bounces-153270-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <68372695-78d9-4036-8d59-fbf1d1261470@amd.com>
Date: Mon, 22 Apr 2024 16:42:36 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 0/1] Fix lb_imbalance reporting in /proc/schedstat
To: linux-kernel@vger.kernel.org, mingo@redhat.com
Cc: peterz@infradead.org, torvalds@linux-foundation.org,
 juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org,
 mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
 vincent.guittot@linaro.org, gautham.shenoy@amd.com, sshegde@linux.ibm.com,
 kprateek.nayak@amd.com
References: <20240318092433.1791798-1-swapnil.sapkal@amd.com>
Content-Language: en-US
From: Swapnil Sapkal <Swapnil.Sapkal@amd.com>
In-Reply-To: <20240318092433.1791798-1-swapnil.sapkal@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K05JMkdZRTBVV1BsS2F1c2o4TUJ0bjdnaEJrZ24rTGVHeWRNVjNPM2FROEU2?=
 =?utf-8?B?NVRtQkdOT2FaNFBacE1EcnNVNi8zemZVOGR1RVl6dHE3SnZJWTc0ak9jT3I2?=
 =?utf-8?B?NkVMUWFNR2F6M3g3cUJtUnllemF4dFhRME9zUkpyVEEyTzBobm1qKzNjYmJX?=
 =?utf-8?B?UEtTTVYzYmE1aDFHMDlvZ2dlczNBRnZRSitoWnZ6ZjAzTG1QR0NwbDhSbDdt?=
 =?utf-8?B?MHBzTlptZWR3OE8zZG1zMytjY0NsSDM0MmRFMXdkeFpqLzRsTUtzdSt1ZVRQ?=
 =?utf-8?B?RkorV2lvV1N6QUp1UmNXNldobmlyMHdQTUI4aG5BRmo4V3pyb1VFMVBFTktX?=
 =?utf-8?B?Y0JhVjVTSWFWTUZncFphb0l0WXdzZkdPc3pMd3drK1cwaENaalVsWjFLNDIw?=
 =?utf-8?B?SXNVS083Vi9PZUZjRVVNNFdHQjlGVW9DQjZrOW5lSlM1UUE3Qm1nYjlnSEFU?=
 =?utf-8?B?ekpPalY1S0Z6endGekRNQ3ZtNHZ2SjJzdFFQK0lpNzd3RDJzeUtnSEZ0bS9F?=
 =?utf-8?B?dkN6dFlTaDBtUDRId3o0bUhSNEFKL1l3STRCRTFJTUs2dlc2ZjRud2JQWk9i?=
 =?utf-8?B?TllIQWt2UjVVVHV5cGxuQ21zMkphUytjZHJjNlpaa2F5eGdrVDNUaGV2dGdv?=
 =?utf-8?B?V1hTY2NPRW8yZXh3M01NMWpDUEp3ZTRIWTE0SkNrYWZRVTExU0hQV3Fqd2hU?=
 =?utf-8?B?bzl3NDR1cENxaWdVTmkzZDFxdFZWc1p5ZzR0cTRkZDdVK2R4S1JQMFpvdDNV?=
 =?utf-8?B?MHJMbFhLOCtjVFJhblo3Vis1SWdhSHZ5aW41T2tjQ2QvamV5cjUxSmFkTWg3?=
 =?utf-8?B?dFZEZndMNENSYTVEeEg3RHRqbVc1NXh3MWMxTW1ISEFXT0ZKbHdzNXRzaXdT?=
 =?utf-8?B?S3RORDlkMlpaUFgrdDFGYUY0K2kzOVJFV0dpZ2xpaWdsRE5oMkxLdXRWdWJR?=
 =?utf-8?B?V29WUlRIOEVyVm1zQ01wQ2RjWjdyUjhTTFJWNnlCVWZCZERrbFhzRzVSOHR4?=
 =?utf-8?B?VnV3cldtaS8yY1YxdlVsSURtU0I1b0dHOElhZWtmWkFqTHBOb25oeUJNbDBN?=
 =?utf-8?B?TjdESFIrTnZRZUdOTDdzTUNaVzBZdDhkRlE4ZlRVNlZhNmpxUFBpT3VmZ2s0?=
 =?utf-8?B?NXowZDc4VVB4Wmd6OFJZK3ZYRE9zM0RmSFBIL2FQR0Q3WWlLOGNTRUxBZW5T?=
 =?utf-8?B?aktwbFlObWZhT0o3UTBjZWNGanYwYzJXMlV3aERGZTZKdXgrOEFvYnlLS083?=
 =?utf-8?B?VFlaSWtmSEcrM2QyK3N5OGJQOWlxVnEybnE1WDFlVndqa3lvdXBNNzRIYzkv?=
 =?utf-8?B?enljWHJJOEJQRERRK3NmMmgzQUNaMHBaWlB6NFVpVnhuYnBncXVabktObnBv?=
 =?utf-8?B?RnluNUFuRWdEdDkxaUVJTHl5WjZmdkFpWHIrQUV6Wk95Wk5yamIxT05QeUxj?=
 =?utf-8?B?T2VPN0NsaVRiVHNKaUJpWDlGMmhOQWxML3Q4bHU3ditEVU42NGcwalNJUU9Q?=
 =?utf-8?B?bk1XclN4VWcxT2p0NUFXTG4rUGFEN1FwNjNQN2JBenV0RHNTRURUeUl3Z3ZZ?=
 =?utf-8?B?SE8zVmpxSXovN3ZrUFYycldwcmVYQVlJT01jUjBla0dVajBuNnlZM1QvV3FL?=
 =?utf-8?B?TjFkU2d0MFRoQ3pzYXhBQ1ZhZTFHMUdLdS92TEswcEc1dXBjRkpmUzBieGdW?=
 =?utf-8?B?Z1daN1VHZWRqRGZwajNLaXcrNW1rUzVFWDBKZ1llRjErZkVjUWdNUDVLcUJW?=
 =?utf-8?B?TnJyTjBhMFNicmszaUZ6MUFHTERjYmc3dHJNMVVVQVNNb1grSkxCSjV1cmtG?=
 =?utf-8?B?ajZneUFqVzhRREhiNTNOSnQ4M3FFaGZBMFNxcE5KaC9QOWJ1aVZVVWNvdmJt?=
 =?utf-8?B?OUpBOVp6enFaelBrem9iYWF1NE5jdlBsS3hxMTJ2d3JmYk92bTBZaytSNzlx?=
 =?utf-8?B?RnBhR0thTDg1RWZIVjNqdm1WMTd0NVlZOVA0bXpVcVY0eERqTTB3M1l1aFNj?=
 =?utf-8?B?bUNzeUlmZGdNNU5iWUtqc3VOUWlLSWxCTXVJS0NCL3dpK0hCYlF2N1JKT2ZX?=
 =?utf-8?B?OWNwQ2RmWm5OQkRhbldUY1VEOEQvbjhmLyszMm9LdVczekxRd1NNU2ZaaTE2?=
 =?utf-8?Q?ttzsiKFx8gnh5CGMuFOj454II?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd6433f8-8801-43e7-5004-08dc62bd2456
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6165.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 11:12:48.2255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5VzC0W75pXwU49oVNRZ3HbkY+e3Dse7K1sICzf0MlWFLMkIjIXPHoiOtn3DgXoBn9KKB7oeQaqJz1apn3uJl0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8978

Hello Ingo,

On 3/18/2024 2:54 PM, Swapnil Sapkal wrote:
> This patch adds new fields to /proc/schdstat. First version of
> the patch is sent here [1]. This patch goes on top of the
> commit d72cf62438d6 ("sched/balancing: Fix a couple of outdated function names in comments")
> from tip/sched/core. This change is intended to be a part of v16 of
> /proc/schedstat.
> 
> v2 --> v3 change:
>    - Incorporated review comment by Shrikanth Hegde
>    - Added reviewed by.
> 
> v1 --> v2 change:
>    - Added links to previous schedstat documentation
>    - Incorporated review comments by Shrikanth Hegde
> 
> Motivation:
> 
> In /proc/schedstat, lb_imbalance reports the sum of imbalances
> discovered in sched domains with each call to sched_balance_rq(), which is
> not very useful because lb_imbalance does not mention whether the imbalance
> is due to load, utilization, nr_tasks or misfit_tasks. Remove this field
> from /proc/schedstat.
> 
> Currently there is no field in /proc/schedstat to report different types
> of imbalances. Introduce new fields in /proc/schedstat to report the
> total imbalances in load, utilization, nr_tasks or misfit_tasks.
> 
> [1] https://lore.kernel.org/lkml/66f1e42c-9035-4f9b-8c77-976ab50638bd@amd.com/
> 
> Swapnil Sapkal (1):
>    sched: Report the different kinds of imbalances in /proc/schedstat
> 
>   Documentation/scheduler/sched-stats.rst | 121 ++++++++++++++----------
>   include/linux/sched/topology.h          |   5 +-
>   kernel/sched/fair.c                     |  21 +++-
>   kernel/sched/stats.c                    |   7 +-
>   4 files changed, 99 insertions(+), 55 deletions(-)
> 
Gentle ping. Can you please consider this for v6.10? If anything needs to be changed please let me know.

Thanks and Regards,
Swapnil