Received-SPF: pass (google.com: domain of linux-kernel+bounces-153302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <67c7f423-18ce-4804-8be9-cc4521733cd2@ti.com>
Date: Mon, 22 Apr 2024 17:09:41 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v8 0/2] Enable RX HW timestamp for PTP packets
 using CPTS FIFO
Content-Language: en-US
To: Julien Panis <jpanis@baylibre.com>, Arnd Bergmann <arnd@arndb.de>,
        Dan
 Carpenter <dan.carpenter@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Andrew Lunn <andrew@lunn.ch>, Roger Quadros <rogerq@kernel.org>,
        Richard Cochran
	<richardcochran@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski
	<kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller"
	<davem@davemloft.net>, <s-vadapalli@ti.com>
CC: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
References: <20240419082626.57225-1-c-vankar@ti.com>
From: Chintan Vankar <c-vankar@ti.com>
In-Reply-To: <20240419082626.57225-1-c-vankar@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 19/04/24 13:56, Chintan Vankar wrote:
> The CPSW offers two mechanisms for communicating packet ingress timestamp
> information to the host.
> 
> The first mechanism is via the CPTS Event FIFO which records timestamp
> when triggered by certain events. One such event is the reception of an
> Ethernet packet with a specified EtherType field. This is used to capture
> ingress timestamps for PTP packets. With this mechanism the host must
> read the timestamp (from the CPTS FIFO) separately from the packet payload
> which is delivered via DMA.
> 
> In the second mechanism of timestamping, CPSW driver enables hardware
> timestamping for all received packets by setting the TSTAMP_EN bit in
> CPTS_CONTROL register, which directs the CPTS module to timestamp all
> received packets, followed by passing timestamp via DMA descriptors.
> This mechanism is responsible for triggering errata i2401:
> "CPSW: Host Timestamps Cause CPSW Port to Lock up."
> 
> The errata affects all K3 SoCs. Link to errata for AM64x:
> https://www.ti.com/lit/er/sprz457h/sprz457h.pdf
> 
> As a workaround we can use first mechanism to timestamp received
> packets.
> 
> Series is based on linux-next tagged next-20240419.
> 
> Link to v7:
> https://lore.kernel.org/r/20240417120913.3811519-1-c-vankar@ti.com/
> 
> Changes from v7 to v8:
> - Removed empty lines between trailers in [PATCH v7 2/2] as suggested
>    by Jakub.
> 

Is it possible to merge this series if no further comment ?

> Chintan Vankar (2):
>    net: ethernet: ti: am65-cpts: Enable RX HW timestamp for PTP packets
>      using CPTS FIFO
>    net: ethernet: ti: am65-cpsw/ethtool: Enable RX HW timestamp only for
>      PTP packets
> 
>   drivers/net/ethernet/ti/am65-cpsw-ethtool.c |  13 ++-
>   drivers/net/ethernet/ti/am65-cpsw-nuss.c    |  51 +++++-----
>   drivers/net/ethernet/ti/am65-cpts.c         | 107 ++++++++++++++------
>   drivers/net/ethernet/ti/am65-cpts.h         |  11 +-
>   4 files changed, 118 insertions(+), 64 deletions(-)
>