Received-SPF: pass (google.com: domain of linux-kernel+bounces-153371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240416-bcachefs-fix-format-specifier-validate_bset_keys-v1-1-3ea2cdf28b12@kernel.org>
 <xznpzlnjcf3goexunm6azwercgwz7ikgum3i4gpdyxwykb4e4l@ascd3uztphq3>
In-Reply-To: <xznpzlnjcf3goexunm6azwercgwz7ikgum3i4gpdyxwykb4e4l@ascd3uztphq3>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 22 Apr 2024 14:47:32 +0200
Message-ID: <CAMuHMdV9wMO2E=xNezs5FiDK_F3XKaVPaFbhh9+7djd26KkgMA@mail.gmail.com>
Subject: Re: [PATCH] bcachefs: Fix format specifier in validate_bset_keys()
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Nathan Chancellor <nathan@kernel.org>, bfoster@redhat.com, linux-bcachefs@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Kent,

On Wed, Apr 17, 2024 at 12:09=E2=80=AFAM Kent Overstreet
<kent.overstreet@linux.dev> wrote:
> On Tue, Apr 16, 2024 at 08:16:02AM -0700, Nathan Chancellor wrote:
> > When building for 32-bit platforms, for which size_t is 'unsigned int',
> > there is a warning from a format string in validate_bset_keys():
> >
> >   fs/bcachefs/btree_io.c: In function 'validate_bset_keys':
> >   fs/bcachefs/btree_io.c:891:34: error: format '%lu' expects argument o=
f type 'long unsigned int', but argument 12 has type 'unsigned int' [-Werro=
r=3Dformat=3D]
> >     891 |                                  "bad k->u64s %u (min %u max =
%lu)", k->u64s,
> >         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~~~~~
> >   fs/bcachefs/btree_io.c:603:32: note: in definition of macro 'btree_er=
r'
> >     603 |                                msg, ##__VA_ARGS__);          =
           \
> >         |                                ^~~
> >   fs/bcachefs/btree_io.c:887:21: note: in expansion of macro 'btree_err=
_on'
> >     887 |                 if (btree_err_on(!bkeyp_u64s_valid(&b->format=
, k),
> >         |                     ^~~~~~~~~~~~
> >   fs/bcachefs/btree_io.c:891:64: note: format string is defined here
> >     891 |                                  "bad k->u64s %u (min %u max =
%lu)", k->u64s,
> >         |                                                              =
~~^
> >         |                                                              =
  |
> >         |                                                              =
  long unsigned int
> >         |                                                              =
%u
> >   cc1: all warnings being treated as errors
> >
> > BKEY_U64s is size_t so the entire expression is promoted to size_t. Use
> > the '%zu' specifier so that there is no warning regardless of the width
> > of size_t.
> >
> > Fixes: 031ad9e7dbd1 ("bcachefs: Check for packed bkeys that are too big=
")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404130747.wH6Dd23p-lkp=
@intel.com/
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404131536.HdAMBOVc-lkp=
@intel.com/
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Thanks, applied

This is still not fixed in today's linux-next, while the issue is now
causing breakage on several 32-bit defconfs in v6.9-rc5.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds