Received-SPF: pass (google.com: domain of linux-kernel+bounces-153394-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 22 Apr 2024 14:51:54 +0200
From: Johan Hovold <johan@kernel.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Zhengping Jiang <jiangzp@google.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Bluetooth: qca: fix NULL-deref on non-serdev setup
Message-ID: <ZiZdag8fw8H1haCb@hovoldconsulting.com>
References: <20240319154611.2492-1-johan+linaro@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240319154611.2492-1-johan+linaro@kernel.org>

Hi Luiz,

On Tue, Mar 19, 2024 at 04:46:09PM +0100, Johan Hovold wrote:
> Qualcomm Bluetooth controllers can be registered either from a serdev
> driver or from the Bluetooth line discipline. In the latter case, the
> HCI UART serdev pointer is NULL, something which the driver needs to
> handle without crashing.
> 
> This series fixes one such issue at setup() time which incidentally
> masked a similar crash at suspend. Fix this in two separate patches so
> that the latter issue is address in pre-6.2 stable kernels.

> Johan Hovold (2):
>   Bluetooth: qca: fix NULL-deref on non-serdev suspend
>   Bluetooth: qca: fix NULL-deref on non-serdev setup

Could you pick these up for 6.9 or 6.10?

The patches are marked for stable backport and only privileged users can
set the N_HCI line discipline these days (even if I'm not sure about
pre-5.14 kernels...) so it may be fine to wait for 6.10 if you prefer.

Johan