Received-SPF: pass (google.com: domain of linux-kernel+bounces-153419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <509e2bb2-54c2-4156-9bb8-4541c87ea2f2@gaisler.com>
Date: Mon, 22 Apr 2024 15:11:49 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 00/10] sparc64: Fix CPU online bug and warning fixes
To: Sam Ravnborg <sam@ravnborg.org>, Arnd Bergmann <arnd@arndb.de>
Cc: "David S . Miller" <davem@davemloft.net>, sparclinux@vger.kernel.org,
 Nick Bowler <nbowler@draconx.ca>, linux-kernel@vger.kernel.org,
 Atish Patra <atish.patra@oracle.com>, stable@vger.kernel.org,
 Bob Picco <bob.picco@oracle.com>, Vijay Kumar <vijay.ac.kumar@oracle.com>
References: <20240330-sparc64-warnings-v1-0-37201023ee2f@ravnborg.org>
 <4e57929b-1539-4a25-ab05-a2a9e04ecc1d@app.fastmail.com>
 <20240330183937.GA191882@ravnborg.org>
Content-Language: en-US
From: Andreas Larsson <andreas@gaisler.com>
In-Reply-To: <20240330183937.GA191882@ravnborg.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2024-03-30 19:39, Sam Ravnborg wrote:
> Hi Arnd,
> 
> On Sat, Mar 30, 2024 at 11:19:37AM +0100, Arnd Bergmann wrote:
>> On Sat, Mar 30, 2024, at 10:57, Sam Ravnborg via B4 Relay wrote:
>>> Nick Bowler reported that sparc64 failed to bring all his CPU's online,
>>> and that turned out to be an easy fix.
>>>
>>> The sparc64 build was rather noisy with a lot of warnings which had
>>> irritated me enough to go ahead and fix them.
>>> With this set of patches my arch/sparc/ is almost warning free for
>>> all{no,yes,mod}config + defconfig builds.
>>
>> Patches 1-9 look good to me,
>>
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Thanks!

Picking up patches 1-8 to my for-next with

Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Tested-by: Andreas Larsson <andreas@gaisler.com>

and, having run it only on single core qemu, patch 9 with

Reviewed-by: Andreas Larsson <andreas@gaisler.com>

>>
>>> There is one warning about "clone3 not implemented", which I have ignored.
>>>
>>> The warning fixes hides the fact that sparc64 is not yet y2038 prepared,
>>> and it would be preferable if someone knowledgeable would fix this
>>> poperly.
>>
>> The clone3 bug has been around for ages, it's probably not even that
>> hard to fix and just needs a little bit of testing.
> I looked briefly and it involves a better understanding of the window
> register manipulation than what I have today.
> 
>>
>> If anyone wants to work on the time64 support for the vdso, I can
>> explain the details for how it's done.
>
> I am happy to type the patches but need to rely on others for testing.
> Anything to help me get started would be super.

I'm not picking up patch 10 at the moment, but it would be really nice
to get allmodconfig builds to not fail due to prototype Werrors.

Thanks,
Andreas