Received-SPF: pass (google.com: domain of linux-kernel+bounces-153445-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Subject: Re: [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support
Message-ID: <ba8e850c-756f-4839-b3d7-db8873f83392@amazon.es>
Date: Mon, 22 Apr 2024 15:29:59 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, <tytso@mit.edu>,
	<robh@kernel.org>, <krzk@kernel.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<sudanl@amazon.com>, <graf@amazon.com>, <dwmw@amazon.co.uk>,
	<krzysztof.kozlowski@linaro.org>
References: <20240419224020.780377-1-Jason@zx2c4.com>
Content-Language: en-US
From: Babis Chalios <bchalios@amazon.es>
In-Reply-To: <20240419224020.780377-1-Jason@zx2c4.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 4/20/24 00:39, Jason A. Donenfeld wrote:
> Changes v7->v8:
> - Remove Kconfig depends statement entirely, instead of ACPI||OF.
> - Check platform_get_irq() return value against < 0 rather than !0.
>
> This is a cleanup of Sudan's OF vmgenid patches, simplified a bit, but
> still with the same intent and mostly unchanged. I'll take this via my
> random tree, but Krzysztof, I would appreciate having your ack/review on
> it.
>
> Sudan - if I've mangled something here, please let me know. I verified
> this still works with ACPI in QEMU, but I don't know about your private
> firecracker OF branch, so please pipe up if something is amiss. It's
> basically the same thing, though, so I suspect it'll be fine.

Hi Jason,

I also verified that this still works with ACPI on Firecracker.
I also verified that the OF part of the patch works with this:
https://github.com/sudanl0/firecracker/commit/f382e09a9b1e4453d2b231232d89bcb85296ac87
patch on top of Firecracker.

Tested-by: Babis Chalios <bchalios@amazon.es>

Cheers,
Babis