Received-SPF: pass (google.com: domain of linux-kernel+bounces-153488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240422133219.2710061-1-ria.freelander@gmail.com> <e2989aa1-7f2b-4ac3-8fd8-822c87d61a1e@kernel.org>
In-Reply-To: <e2989aa1-7f2b-4ac3-8fd8-822c87d61a1e@kernel.org>
From: "Konstantin P." <ria.freelander@gmail.com>
Date: Mon, 22 Apr 2024 16:50:53 +0300
Message-ID: <CAF1WSuzqLxpxwYuNYfHyvXLDMBE-ZU69YLXwBdQokZzhs49xzw@mail.gmail.com>
Subject: Re: [PATCH v7 0/3] add support for EXAR XR20M1172 UART
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: conor@kernel.org, lkp@intel.com, vz@mleia.com, robh@kernel.org, 
	jcmvbkbc@gmail.com, nicolas.ferre@microchip.com, manikanta.guntupalli@amd.com, 
	corbet@lwn.net, ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de, 
	Maarten.Brock@sttls.nl, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Jiri Slaby <jirislaby@kernel.org>, Hugo Villeneuve <hvilleneuve@dimonoff.com>, 
	Andy Shevchenko <andy@kernel.org>, Lech Perczak <lech.perczak@camlingroup.com>, 
	=?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 4:45=E2=80=AFPM Krzysztof Kozlowski <krzk@kernel.or=
g> wrote:
>
> On 22/04/2024 15:32, Konstantin Pugin wrote:
> > EXAR XR20M1172 UART is mostly SC16IS762-compatible, but
> > it has additional register which can change UART multiplier
> > to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this
> > flag to guard access to its specific DLD register. It seems than
> > other EXAR SPI UART modules also have this register, but I tested
> > only XR20M1172.
> > Yes, in datasheet this register is called "DLD - Divisor Fractional"
> > or "DLD - Divisor Fractional Register", calling depends on datasheet
> > version.
> >
> > I am sorry about too many submissions and top post reply. About second =
-
> > I do not know how to reply properly to this ML from GMail phone app. Ab=
out first - I just
> > get very good feedback from Andy Shevchenko, and want to fix his review=
 picks ASAP.
> >
>
> One patchset per 24h.
>
> Plus, you already got such review comment:
>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/su=
bmitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
>
> Just start using b4.

There is not only for tag. I submit fixes for version 4 by mistake,
so, repost to 7 was necessary, because v6 was not work (as v4). But v7
should be based on v5, and v5 is tested better around tty-next.

> Best regards,
> Krzysztof
>