Received-SPF: pass (google.com: domain of linux-kernel+bounces-153514-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <64ce1c2e-4771-42d9-8ffe-9d03b09a61d2@gmx.de>
Date: Mon, 22 Apr 2024 16:06:49 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 1/3] serial: sc16is7xx: announce support of
 SER_RS485_RTS_ON_SEND
Content-Language: en-US
To: "Konstantin P." <ria.freelander@gmail.com>,
 Andy Shevchenko <andy@kernel.org>
Cc: Konstantin Pugin <rilian.la.te@ya.ru>, krzk@kernel.org, conor@kernel.org,
 lkp@intel.com, vz@mleia.com, robh@kernel.org, jcmvbkbc@gmail.com,
 nicolas.ferre@microchip.com, manikanta.guntupalli@amd.com, corbet@lwn.net,
 ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de,
 Maarten.Brock@sttls.nl, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>, Hugo Villeneuve
 <hvilleneuve@dimonoff.com>, Lech Perczak <lech.perczak@camlingroup.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
References: <20240422123801.2695129-1-rilian.la.te@ya.ru>
 <20240422123801.2695129-2-rilian.la.te@ya.ru>
 <ZiZcyhoKRgfteO5d@smile.fi.intel.com>
 <CAF1WSuxPmzWYhCQU3tiA_GYMLowxMuvEJWRv83atithv8NCRxg@mail.gmail.com>
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
In-Reply-To: <CAF1WSuxPmzWYhCQU3tiA_GYMLowxMuvEJWRv83atithv8NCRxg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:E0kV41HQXSw=;yFfTPRk3CsiuWltp8fUOsYrIhQu
 8gcC2Ao++R+zzBLGcDiuhWqrTsuiwyd+iASW6VnCMgTJX3wNAbZopbfqviHc42hdZceck6y4X
 6iWxOLWB58FfEEmEZ7kYl1TSEzBb3gPrG6IEdwuYsXukGL6uSOXsCQihaJdjQ2j37hr6FXG2P
 WODmapJ13KTCDZ5dlSfzRw7/0D/ySqeSerBRS86Qngxc3zTbKf4dmKszuuh28/9VwlfxlGMhE
 KwKZSsldkEp6iYFPva3zZVS46+98US0Zcl3lLhBLAqbRXaZ6OS0eKvLxeVGPV1itAnhkN8Jik
 vFfmlODUwVEYF2AggUsvHrT57jsQbGxbMnZiLypsushgnaFS5s2IZp+X5Wc92etEJ66CC2rHE
 dlnixO548jD9d23HebysuGcgEIuCWXzBIC91lqNvSNuhm2tafuhq4RRtWbVMmeGjqW63FRR4V
 tg896Z20qMN90+hrDL6wGS8Yk3SxpLvW5E/M4GwreOZneyedw1s4Uwfw/X3ukrtwF53z0CWx5
 ntb9SXISLa3uqa3LGItL0v+U25pFI4jGp/cdgOisu/cpqBev7cNvq7txMhRByMGrJmhw15roL
 21oQEL7u51TIKFrT++6QPINv3CJZVUgCYY/JP0D/ZpR6zL9wVV0DptKwsnmuMtO8GLZvzc3/b
 0n9Yi+HD3xFEgPsQGCffUSYikZdT/6ou0jds4yXanQpUyeyVAFJ03mfNtzLdadVXFWCIiIAlE
 f1AgCdqtRSGWpJfgGImxWCir7E1LdqVBjD+yrQMsfD6PbHQxGjmD7D4kyElxNPTjE3tqDhKak
 ihfuivw9MJkYIJZzKB77buRUQ5UHkBRN1FJ4LvUuYa5Zg=

Hi,

On 22.04.24 15:20, Konstantin P. wrote:
> On Mon, Apr 22, 2024 at 3:56=E2=80=AFPM Andy Shevchenko <andy@kernel.org=
> wrote:
>>
>> On Mon, Apr 22, 2024 at 03:37:55PM +0300, Konstantin Pugin wrote:
>>> From: Konstantin Pugin <ria.freelander@gmail.com>
>>>
>>> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, but
>>> after the commit 4afeced55baa ("serial: core: fix sanitizing check for
>>> RTS settings") we always end up with SER_RS485_RTS_AFTER_SEND set and
>>> always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, whic=
h
>>> breaks some hardware using these chips.
>>
>> LGTM, but I leave it to Hugo for testing and other comments, if any,
>> as I don't have a HW.
>>
>> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
>>
>
> Andy, I need to do v7 (because there is a missed fix), but Yandex do
> not allow me to send more mail( So, can it be sent next day?
>

Please add at least the linux-serial mailing list the next time. As far as=
 I am
concerned, I was only aware of this issue because of Andys response which =
added
linux-serial. Furthermore shouldnt this also got to stable?

Regards,
Lino