Date: Fri, 25 Jan 2008 22:05:57 +0100 (CET)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Cyrill Gorcunov <gorcunov@gmail.com>
cc: LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] driver: tcm825x - fix logical typo error
In-Reply-To: <20080125202720.GD7233@cvg>
Message-ID: <Pine.LNX.4.64.0801252159140.9538@axis700.grange>
References: <20080125202720.GD7233@cvg>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1382
Lines: 38

On Fri, 25 Jan 2008, Cyrill Gorcunov wrote:

> This patch does fix potential NULL pointer dereference
> due to logical typo error.
> 
> The issue is pointed out by
> Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> 
> Index: linux-2.6.git/drivers/media/video/tcm825x.c
> ===================================================================
> --- linux-2.6.git.orig/drivers/media/video/tcm825x.c	2008-01-23 19:01:47.000000000 +0300
> +++ linux-2.6.git/drivers/media/video/tcm825x.c	2008-01-25 23:13:15.000000000 +0300
> @@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
>  	sensor->platform_data = client->dev.platform_data;
>  
>  	if (sensor->platform_data == NULL
> -	    && !sensor->platform_data->is_okay())
> +	    || !sensor->platform_data->is_okay())
>  		return -ENODEV;
>  
>  	sensor->v4l2_int_device = &tcm825x_int_device;

Now that it missed 2.6.24, you probably want to send it to -stable too. 
Even though the patch is trivial, it might be a good idea to cc: v4l2 
maintainer and / or driver author.

Thanks
Guennadi
---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/