Received-SPF: pass (google.com: domain of linux-kernel+bounces-153556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>,
 Nathan Chancellor <nathan@kernel.org>,
 Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling <morbo@google.com>,
 Justin Stitt <justinstitt@google.com>, kernel@collabora.com,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] selftests: mm: fix unused and uninitialized variable
 warning
Date: Mon, 22 Apr 2024 09:59:08 -0400
Message-ID: <CC621D9C-2D1B-4CB7-A5E0-ACE0850E6B0D@nvidia.com>
In-Reply-To: <20240416162658.3353622-1-usama.anjum@collabora.com>
References: <20240416162658.3353622-1-usama.anjum@collabora.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_48CB3BC0-7E89-479D-988D-8B56AF4CB946_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5cMXCA2IJL/hW/Wc6rz7nIt8nlQnTj3FDLj6VQlguvkw9/gU4GVD8RUo/yEe?=
 =?us-ascii?Q?Gop+X/xMrXomCOfm8hSlwgjzQSruilZVlRjTnAYrFx1hK476h7Wac6Hkz6FK?=
 =?us-ascii?Q?qASLiHCwE/dfdfTUEV+nP/Af9MsLB3qGDI3A2xTkBZlLxnguGG9wygH6cwb3?=
 =?us-ascii?Q?f7dAuEWLingzxQ90DrBMHaBbinZtZEqjenaia7/RfdasudgGOUzgjjcSVaa6?=
 =?us-ascii?Q?9tESVwaKkt9sHF1jCPaJz2wFpbLSlH7aHFlAPxMK9jRAMbrFK73kNn4zKSJV?=
 =?us-ascii?Q?zdGUbDFiU9QXQWZc+kHXmAPuDl09PhhuRE7ySilUzf7d7bfwCN+vcPo8SmBQ?=
 =?us-ascii?Q?wZeZtU1+MF9a4tG4qJAb6heGIN1hdPsE+as8T9fw3criFNB5OKtxw4T5vjVp?=
 =?us-ascii?Q?UbXnAFvP+POpS6w6I4mzCUYZVneID3h6OMScqnpXP6eFOApla3SU7nZHNp8K?=
 =?us-ascii?Q?2gBSNw4xtl7krOAwzIIiWc56UShk1daISgtI+2/2PIm+uuMvJxpXXirzLf4C?=
 =?us-ascii?Q?Bqlnl6lVt06s63In31gr526RJKaF/TWoxCVW7RZLdflQR9KVLun13d3+EzX+?=
 =?us-ascii?Q?7zP1Qz6uc+vCtXsmRqCxmea525es/YSJJXSJS+iDX+tZChZ5xQ5+jF6DnV7O?=
 =?us-ascii?Q?Tlc3XQCM3eG0KDRhWMmZxmxRrLrUEbB8DcMswv+FzOUb1vO+FVHFoHUMfeFm?=
 =?us-ascii?Q?ttGTBjYIMXqhoIY70KFrpornPws6w7IBDUBi0lPPLqN4inIGDHTsypMqQu21?=
 =?us-ascii?Q?vNukcb9aEqY6jd27hS0wThsBJjKVaeHWZQuWvPLKy97LlW2dBO46Wi/RbG91?=
 =?us-ascii?Q?dsXntDCt3Ne1SWhpG4klAbo5Y1YDy7q/Ew/eqtoWsz5i8SQzLyHAVU4AofWT?=
 =?us-ascii?Q?JMb371bfA5QinkAQcvPDiJ+VrSHUqBQBjuWvtpUsig72dAfhaEj2xmnXBlHi?=
 =?us-ascii?Q?0bVfsaHdWNt04HpjCVBMD8SDcszwRbAAM2k2CUxwqRygRDEpk6Zojl1r6u7g?=
 =?us-ascii?Q?NF1zl9SKx2wRbLPHR2gdbB708D8tPmJcxXDPR07mWfP3pPaCy6bk3bxPtUQU?=
 =?us-ascii?Q?7isLAMInaDm1D8W6AUaKONf0wkt9wTzFZ91VVlHrlcXwRHphdqLO0djj/yix?=
 =?us-ascii?Q?orD3I9LulVq9L4dSNO45SP+2+MVoM0sv6gjNJlShI6DUbwfqyv6MGGnLGpR0?=
 =?us-ascii?Q?u1aM/CAa/Xxf+fhIXQoaA0dLsVyrhEkHVo/1jkdQz+KzVMAIBuzW8LoJBQwA?=
 =?us-ascii?Q?MuJk+JyrbnuJFdfHTntljUx3ZQC9UOZf0r9rzjxIAT9qBK+XsoJi6Nm/dCjn?=
 =?us-ascii?Q?akrpboF2a6DRddi4C6mjYbM8lOJhXn7Umedp5s0jLkRR15/sD8IzencA3FJi?=
 =?us-ascii?Q?8Vomgo0psw0p2B4ERDWay8kRbw7LI4FiThnaDF8RoywK/rDFK6dYU0SGXs/p?=
 =?us-ascii?Q?Wb20z4abSc8LcwyahaXwBC7ximBmPseNUnZOSRt58ygcBsyybDs/2MPUKnjD?=
 =?us-ascii?Q?UKQKO+KRDnOe9lKaRgjD2qRgTvuqgiopyqtKVSdg7LREP2+eB2cbN72RR0XH?=
 =?us-ascii?Q?2q3JFXutP/Hn7b9pgQQTyV7kZMNPFUfydQjA7juK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd8a434d-7101-46bc-b826-08dc62d961c7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 14:34:56.9002
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gcKYQsM3gM/aWId+q4zimMmvsx5Do2V5z/0lhy7s8ffatFXREN9H57f3cTZu33pt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8557

--=_MailMate_48CB3BC0-7E89-479D-988D-8B56AF4CB946_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 16 Apr 2024, at 12:26, Muhammad Usama Anjum wrote:

> Fix the warnings by initializing and marking the variable as unused.
> I've caught the warnings by using clang.
>
> split_huge_page_test.c:303:6: warning: variable 'dummy' set but not use=
d [-Wunused-but-set-variable]
>   303 |         int dummy;
>       |             ^
> split_huge_page_test.c:343:3: warning: variable 'dummy' is uninitialize=
d when used here [-Wuninitialized]
>   343 |                 dummy +=3D *(*addr + i);
>       |                 ^~~~~
> split_huge_page_test.c:303:11: note: initialize the variable 'dummy' to=
 silence this warning
>   303 |         int dummy;
>       |                  ^
>       |                   =3D 0
> 2 warnings generated.
>
> Fixes: fc4d182316bd ("mm: huge_memory: enable debugfs to split huge pag=
es to any order")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  tools/testing/selftests/mm/split_huge_page_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_48CB3BC0-7E89-479D-988D-8B56AF4CB946_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYmbSwPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUQ1MP/iC7xLfLjN9Qmlbjf8QP7EYroAKz7uTgH0aj
RPGQnC1e4RBMGmct5k/8U2NrqRFDs9UrbXv+Lv0bvt3vvn3R97aDAXvHRjqyOwGj
OTDsPDYsgIv26/uKQOd7N5/+3yKa+BRpiH5siGtvf/0Q3+Khhc5Krxyx9eZW2cle
9CkAxmWoE3MN8bMEWZDGxyAXnKAmNNihlwtntAkBj2VF2zL+Qb8lezHFUojtvcIG
WihNYJZbtBpcWEkaAxAYRniKflXe1dP7X9NeSctsp36XYDGeQ9JFkPSeq4qIFGo9
yYtoGz5Fj7giiKbi1wwVjflKNrQmBommm807cZh6U0pT4ZGBx1hrcW1TnNultzk3
6zewtyfZ8PAKuyMyK5U8am9x4Wx/jZN6eO3ZQ71hXR+vcZfae1ekzydb8gzLC3sI
hHbXr+jmmp5RjeaaM+q+T19YNUoKwWMriEqsZUwvBAf/hzsjJr1E02DjydQ40Bdo
gxom/vPBAc2poUCHwJB0/AA9P1wuyDzakUAiVXzszySZiUs8krxpouw2PncSQ+aN
tcRqLrwXP87rLckbayiEYyGqEiUiyS9Clcz9WlGzNAxy+JHQJs13X2aa8gd4mVWa
jRS74KM9otQ3+TKl38m6smny4xEfPBIuvWnGGQdMp5PZ8wdgB6QASEzt/XU6kR2w
9onacvIS
=yXTU
-----END PGP SIGNATURE-----

--=_MailMate_48CB3BC0-7E89-479D-988D-8B56AF4CB946_=--