Received-SPF: pass (google.com: domain of linux-kernel+bounces-153560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 22 Apr 2024 22:40:09 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: <linux-efi@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>
CC: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Vlastimil Babka
	<vbabka@suse.cz>, Nikolay Borisov <nik.borisov@suse.com>, Chao Gao
	<chao.gao@intel.com>, <linux-kernel@vger.kernel.org>, "Hossain, Md Iqbal"
	<md.iqbal.hossain@intel.com>
Subject: Re: [PATCH v2] efi/unaccepted: touch soft lockup during memory accept
Message-ID: <ZiZ2yUI09QIrYr/4@chenyu5-mobl2>
References: <20240411004907.649394-1-yu.c.chen@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240411004907.649394-1-yu.c.chen@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BArDM34FhwTE8zMOlqVoWtkVw2OJsJm5A/F+tPF3mn3qDComL2R5h9IKbPv8?=
 =?us-ascii?Q?rIJZCLZ2bhzUPJ+hQ6ioG6gwvEJ4JAwafT5ggovR4H8wOlvTZmpgOHiJIKOj?=
 =?us-ascii?Q?88x21XYFsrnnvTSec2fDEi+BuQaRPQxhkCzvxxuuZbfDLitXcK/QDJS+Fjui?=
 =?us-ascii?Q?ZAc0bikjdlITx8YTxWhWy+r4lerlUsacKya30Pt1XfZ6aDoVl14PRoWfkR1G?=
 =?us-ascii?Q?cSQfeFzJWkfnXSmbyKuSK8ng1Y01OyAQ2ne9dJNAbktL0R2QNTehCoQx2N29?=
 =?us-ascii?Q?dIkrDLKBhAp7kTbVkiWAFLYx954FwErAKs4QsO0TA9z+1o4HW5AUOfwmBQAn?=
 =?us-ascii?Q?lPLZwA2KCkBH7Ysj/rwT82ZkjlsDhwm6KbkSYFFtNZbRkHDuHte0UsAmXPWh?=
 =?us-ascii?Q?dzToDBR3TAUa9a0JghQF1Qhmh3DRo71pAIOHscvAPc5mhnbvpKlACATcmlh6?=
 =?us-ascii?Q?zz+XZIen5E3/DOYcRHWCRFrr1ZICiTDVuRgJP1UmWtX04uqq9F8aeTkUZDaj?=
 =?us-ascii?Q?dgcYEOd9H3CAJSDohiMDa3vCyfyCfRqfXcfb6rmnrHYzUXqGlP/2CWeSXyG8?=
 =?us-ascii?Q?YwB1Qk3eTQcIj7e+yNS2MEcXhV7M+Up2U0BeGyDfATvkeAcyCQspXg0o7sek?=
 =?us-ascii?Q?isXDaRRrJw2eG6far6RkFzdG3lsYFzMv54OsSA2FIywQsBPAlIplCTltKfZI?=
 =?us-ascii?Q?0mtLtuNID21LKIT1EohLv//O7RLCpJdWKA6/LAqovkuG+B42sqrnAJpoSKvJ?=
 =?us-ascii?Q?qO3cKWHCyK+7SfXq4eUeEnZ1JO20HwzVZMCkbGvpC1kLFfpJc/hl5tGW9TxX?=
 =?us-ascii?Q?U2Cq5+SMio5kI7hU0uJQIE7XkfT9ZqhK3nqI4O6HcErVYONhH+kLeZ8R0F1M?=
 =?us-ascii?Q?T+UBIsdk0A+Daz88JNjguU/q4eTEKPruTSmBSePQqPHUpKdpQLmBkN9EIED2?=
 =?us-ascii?Q?cFlMffqrGkLUasuRGfQnacuat14mqmXBPisE9/Q1cbAVzCrfU6UoFNfrx0cM?=
 =?us-ascii?Q?elz5YDSYn4iivFLBquqX0rjajSKAil1+HLElCO8urzypxnjLdmh8yB/mFFc3?=
 =?us-ascii?Q?SHWHs8Ckwo0LnOGwo7nev04fekuoVkKT2TlrDCOjbjwCoSd6jdZfkSs9wLH3?=
 =?us-ascii?Q?NEwKpvhfmtRtiDU+8NnfQ3ZHs+98pn9ntrMDy44UVkJH/KWHDxTx/5pFlxsd?=
 =?us-ascii?Q?NNVPvFBQrZYva1fGIsF8Uue7WNCRNLxW3idCATgJ2NVY6QzMoIRATzz2sBxF?=
 =?us-ascii?Q?Jj20XSzsUIOXlxqQ2F1J/wuQEZ+jbLxXbUrNfeJfyXw/akahdFi76IhPi7pr?=
 =?us-ascii?Q?CdwB7/M4jA/F+Pd595Lbd8XHFR+TiK5V/6E/FIhpFuu0D1JxRVQ+eHoy8/zc?=
 =?us-ascii?Q?+N+PA2X0iyaW92waPLXtQCoqZk2vos4BybFekIMe7f6375RuG7obQHVc/P4k?=
 =?us-ascii?Q?QykmQURE/yMFVwpxkt4wJ3toi+IdgQzwXxQcSAkMPbwTl+vFeMjDAFW1hbb7?=
 =?us-ascii?Q?sa+Q5FqOQKVvv1HaBXNkK3HrZ47wFuH1m8NdjG59llGVM+Rcc9D0g7shqiHs?=
 =?us-ascii?Q?ro+7Cf4qjgm93nKIbwtv9Bx7ck/uRCQLy3bmF8Kc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cea8e25-a372-4c60-b2b0-08dc62da20eb
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 14:40:17.6213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9PApqeY/AtjEXswrC1n4O1qP6mpua82lCqVESZzdNtrpp2khBNPv/h0+ZKhsfSuumUQG0/Pg99wiASu+2q+y8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5997
X-OriginatorOrg: intel.com

On 2024-04-11 at 08:49:07 +0800, Chen Yu wrote:
> Commit 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused
> by parallel memory acceptance") has released the spinlock so
> other CPUs can do memory acceptance in parallel and not
> triggers softlockup on other CPUs.
> 
> However the softlock up was intermittent shown up if the memory
> of the TD guest is large, and the timeout of softlockup is set
> to 1 second.
> 
> The symptom is:
> When the local irq is enabled at the end of accept_memory(),
> the softlockup detects that the watchdog on single CPU has
> not been fed for a while. That is to say, even other CPUs
> will not be blocked by spinlock, the current CPU might be
> stunk with local irq disabled for a while, which hurts not
> only nmi watchdog but also softlockup.
> 
> Chao Gao pointed out that the memory accept could be time
> costly and there was similar report before. Thus to avoid
> any softlocup detection during this stage, give the
> softlockup a flag to skip the timeout check at the end of
> accept_memory(), by invoking touch_softlockup_watchdog().
> 
> Fixes: 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused by parallel memory acceptance")
> Reported-by: "Hossain, Md Iqbal" <md.iqbal.hossain@intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
> v1 -> v2:
> 	 Refine the commit log and add fixes tag/reviewed-by tag from Kirill.

Gently pinging about this patch.

thanks,
Chenyu