Received-SPF: pass (google.com: domain of linux-kernel+bounces-153562-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: John Garry <john.g.garry@oracle.com>
To: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
        viro@zeniv.linux.org.uk, jack@suse.cz, akpm@linux-foundation.org,
        willy@infradead.org, dchinner@redhat.com, tytso@mit.edu, hch@lst.de,
        martin.petersen@oracle.com, nilay@linux.ibm.com, ritesh.list@gmail.com,
        mcgrof@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, ojaswin@linux.ibm.com, p.raghav@samsung.com,
        jbongio@google.com, okiselev@amazon.com,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH RFC 6/7] fs: xfs: buffered atomic writes statx support
Date: Mon, 22 Apr 2024 14:39:22 +0000
Message-Id: <20240422143923.3927601-7-john.g.garry@oracle.com>
In-Reply-To: <20240422143923.3927601-1-john.g.garry@oracle.com>
References: <20240422143923.3927601-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?wPW9obOt5Ddm+/RFtoq8uBTXUStdVA5vKBH3QlS32XKfGeg2R7/GoKGeD9Ov?=
 =?us-ascii?Q?eyhndDnPyWHaW5w6mqqoGR2y3Urw8ZrnjeDcvc4RDrsx4qFfwqyFicOY2QwA?=
 =?us-ascii?Q?ds99LMR02ENfJfDenEGu6gINU29Uy9SueoB+J5WowwExSNvGjIV0pGBgeSRU?=
 =?us-ascii?Q?FBJAAr79xoPcuoaSudd+C6tyqQZcY0AeGgEP/ZhvC/ZZiUuwCqwLLe4pQuHR?=
 =?us-ascii?Q?rw7vGhAFhqk7+/erWTwx8l6TLC33XhHSRj1Tiz+jZCb89mT6pXxptvVCnJVC?=
 =?us-ascii?Q?8KKNqV4ZPSL8ktFQkOgmOpgmNnjOEEbbMBEZSWxfe0EiUZJiy6vqcoPV2u4q?=
 =?us-ascii?Q?Vaw0IVxo/GEY2ur7mlmJrsFqw38XIueo5UNFTjh4pECd0iR6SNy2es0sZwEU?=
 =?us-ascii?Q?HWjycZWLGfi1ugAs+mPKr8i9paWp2Er/UCY/GxElZ+HBLHdS7SOLQPsvZ8Df?=
 =?us-ascii?Q?tZFLOF/NuslJHdEYtT498mm4/DUUqI5MJv8rsz9wE+Q7bZw3UYroejohltAJ?=
 =?us-ascii?Q?p67On7pmykabGmZPP2vu7R45xufwLJdM3he28pzHQQ9R4luYn6alcWxNxr2T?=
 =?us-ascii?Q?q0VuwaXlsblHnLPwoACwqn5mUnhxOb9K9wvpi2hYiOxCrXU/8QHbzOW0qd8k?=
 =?us-ascii?Q?W19tffzjpHwBUHBcMeJIl9WbfBrRRnFHdRlP0bd2wfTd3ALafptZnPNZd9jf?=
 =?us-ascii?Q?LFf2JztGOX/V0t68FajUBg5rKknf1N9O1j6Hxtf2L7MstVuu/2Zu5UzbBM0q?=
 =?us-ascii?Q?MBL4s2WveJTJtsZw0p8TP9wxsDYgTUDJArVMa1qHBueYUfCIXvV9tRsJ+yNL?=
 =?us-ascii?Q?XBDJmf6SteDwdxp1jig0FCNnGmpmhL+KyelBX/mTDYQlP/fP0cVBYDh0RAYE?=
 =?us-ascii?Q?gkK+/Y6jQIL6NfQTL3rN5DNzNpkGtYfoWKNPjUSAxvd+CJ2T7MRu6gMkJuVJ?=
 =?us-ascii?Q?oSBYeG9WUVzpkCdJBtZ5A4x8c0ldjFeBQSNGr8eYISsf6kkGwb0u97qBLnrD?=
 =?us-ascii?Q?8epxh+Rz/w6fucGdFPD7EWjQGsOeRerctMvjj7nAP8n/pSJM/Y4igoH6EdmX?=
 =?us-ascii?Q?veDPFXXsZHYbz7xva77zmVEjpbzEkARuNC4x4t6Zwc4tENILvWZ/mcGNsw8u?=
 =?us-ascii?Q?e1f56fLO82pyD+O4lDEXiT7yKVRLfOnwHevM+rPAxzOFHbgX2Hb6UwhE2H2V?=
 =?us-ascii?Q?Y4VuX1reyFgvZaNOxHyZBkZx4sfL4LJ4A/IbRx74+gVExf6NFABh0q+5GikJ?=
 =?us-ascii?Q?fzCY2JI/VTMdCkc0JM2VZbM6ju9HJIk0a9g5Qc7+IGPF7Spgqbt/wpedlTLC?=
 =?us-ascii?Q?pFxGSpEnoDYz0gtarwB8c24doOuw48rqtGvGmA4UP/HaIAFIg9JawyEZIofB?=
 =?us-ascii?Q?E0QyPQa7dnmp2e5+qQssEUZ1aiLbE4PdigipzogEVQVzwmXTz2fFH9NQGH3e?=
 =?us-ascii?Q?qC1aVJ0WlWvrsmQlFTwQbZ8CIMdP6/pe9RjAbCq2aBxaJ6N4kHwY8cjyzXXN?=
 =?us-ascii?Q?EFu5UR/9KoV8ZVy6KRQt38Ns7NRL/8cBKZ4A4BJn07wkfWABBTUSZmespzD1?=
 =?us-ascii?Q?CxheZWvUZc2yV2u8Ty8YukHXk6yFCucaEvath8Ikpie8PC7s594ZsB4es6Au?=
 =?us-ascii?Q?bg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	xoCdW8nECbOonv/YBN4EqjD5cTZ3lA+68/IKNn8V6rJIoCPmj/rZQ7yJUSUkKDj8/n4UNAT+akjWPBkXlbwPiCqW17hRFbnpdghgm5lzppquRW0G3rsVU/IshDAb/N9/uKvxy+vCESHp2iQhSWYwE+2B2rdU+M0XlxISKGHP/WYM8hJZXqz2XINVrCPbzq16bbjAF6ZCpsiusPn8iF3FcUA+8VZXJMU/5fNB8+7hc2VMxdz1+smnevtE/ET/+LOj36JqvZx4mz7fYOU2p7Hr3DNpss1AKrAYFLK+6apE7f3Nx2B+16Vf5B1fAuqQlunCv4UBqiQsY+LJziHXcRyVw4PMr7qXmd2E1/UZba7SJqXKv0a4a88E7iAyTaZKxBwf4EnztvH2UZCgavUbfXmx2pUPwBTJw8LVvkJLeFxb81gLPyUIbz6Q730gNRqyhwmAm3oc/YJnuGp3Zx1jdZ2Q+3WJF8MZ7G4X7xwq+XloBt46lOABHQLMXBVCnXOUuUR9QUj+rPpFgdctyX6cubLQA8wzmsvrrezodEAkQt1KFqzlRpC1SQ2uB1cJEh9B6v3znpGX8oc9ZJO1bwrAlVwkx/Jc94+fv1ltZs3Q6S4XBBc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac170589-52dd-4bfa-e223-08dc62da26a4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 14:40:27.1687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jzmzxJlR+twt7I2VV11Sskfcz1PJ0Qem3OHz8lXSUNo/pCPnbcIrWauvgdfv2+ee+NRYwlKAyJL6xHDIIGeF1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5039
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-22_09,2024-04-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404220063
X-Proofpoint-ORIG-GUID: qPHEibSr3geO_zjDXyDw2XwNDBdWlA2G
X-Proofpoint-GUID: qPHEibSr3geO_zjDXyDw2XwNDBdWlA2G

For filling in the statx fields, we use the extent alignment as the
buffered atomic writes size. Only a single size is permitted.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/xfs_iops.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index 05b20c88ff77..d2226df567ca 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -650,12 +650,19 @@ xfs_vn_getattr(
 			stat->dio_mem_align = bdev_dma_alignment(bdev) + 1;
 			stat->dio_offset_align = bdev_logical_block_size(bdev);
 		}
-		if (request_mask & STATX_WRITE_ATOMIC_DIO) {
+		if (request_mask & STATX_WRITE_ATOMIC_DIO &&
+		    !(request_mask & STATX_WRITE_ATOMIC_BUF)) {
 			unsigned int unit_min, unit_max;
 
 			xfs_get_atomic_write_attr(ip, &unit_min, &unit_max);
 			generic_fill_statx_atomic_writes(stat,
 				unit_min, unit_max, true);
+		} else if (request_mask & STATX_WRITE_ATOMIC_BUF) {
+			unsigned int unit_min, unit_max;
+
+			xfs_get_atomic_write_attr(ip, &unit_min, &unit_max);
+			generic_fill_statx_atomic_writes(stat,
+				unit_max, unit_max, false);
 		}
 		fallthrough;
 	default:
-- 
2.31.1