Received-SPF: pass (google.com: domain of linux-kernel+bounces-153635-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240422133219.2710061-1-ria.freelander@gmail.com>
 <20240422133219.2710061-3-ria.freelander@gmail.com> <20240422-repackage-popper-8a062acf2610@spud>
In-Reply-To: <20240422-repackage-popper-8a062acf2610@spud>
From: "Konstantin P." <ria.freelander@gmail.com>
Date: Mon, 22 Apr 2024 18:31:56 +0300
Message-ID: <CAF1WSuy=zuTjDGEKGUtAb79J28FydYfuvB=OuR1yx5PtuPHz7A@mail.gmail.com>
Subject: Re: [PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for
 XR20M1172 UART
To: Conor Dooley <conor@kernel.org>
Cc: krzk@kernel.org, lkp@intel.com, vz@mleia.com, robh@kernel.org, 
	jcmvbkbc@gmail.com, nicolas.ferre@microchip.com, manikanta.guntupalli@amd.com, 
	corbet@lwn.net, ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de, 
	Maarten.Brock@sttls.nl, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Hugo Villeneuve <hvilleneuve@dimonoff.com>, Andy Shevchenko <andy@kernel.org>, 
	Lech Perczak <lech.perczak@camlingroup.com>, 
	=?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, 
	devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 6:28=E2=80=AFPM Conor Dooley <conor@kernel.org> wro=
te:
>
> On Mon, Apr 22, 2024 at 04:32:14PM +0300, Konstantin Pugin wrote:
> > Add EXAR XR20M1172 UART compatible line into devicetree documentation.
>
> I thought I had already pointed out a need for the commit message to
> explain why this exar device belongs in this file. IIRC you said it was
> in the driver commit and cover letter, but it needs to go here too.
>
> Thanks,
> Conor.
>
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
> > Signed-off-by: Konstantin Pugin <ria.freelander@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yam=
l b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> > index 5dec15b7e7c3..c4bedf23368b 100644
> > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >  properties:
> >    compatible:
> >      enum:
> > +      - exar,xr20m1172
> >        - nxp,sc16is740
> >        - nxp,sc16is741
> >        - nxp,sc16is750
> > --
> > 2.34.1
> >

Okay, will add again (another v6 missed).