Received-SPF: pass (google.com: domain of linux-kernel+bounces-153657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 22 Apr 2024 16:48:20 +0100
From: Conor Dooley <conor@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lucas Stach <l.stach@pengutronix.de>, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl,irqsteer:
 Add imx8qxp support
Message-ID: <20240422-channel-emission-d485dee6ae48@spud>
References: <20240422064949.70778-1-alexander.stein@ew.tq-group.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="cwoDUL3Q+X8/OOYa"
Content-Disposition: inline
In-Reply-To: <20240422064949.70778-1-alexander.stein@ew.tq-group.com>


--cwoDUL3Q+X8/OOYa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> compatible, which also requires a power-domain.
>=20
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Thanks for the feedback.
>=20
> Changes in v3:
> * Move 'allOf' before 'additionalProperties'
> * Remove superfluous 'minItems: 1'
>=20
>  .../interrupt-controller/fsl,irqsteer.yaml      | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,i=
rqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,i=
rqsteer.yaml
> index 20ad4ad82ad64..3d33b75d6ecfa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer=
=2Eyaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer=
=2Eyaml
> @@ -14,7 +14,9 @@ properties:
>      oneOf:
>        - const: fsl,imx-irqsteer
>        - items:
> -          - const: fsl,imx8m-irqsteer
> +          - enum:
> +              - fsl,imx8m-irqsteer
> +              - fsl,imx8qxp-irqsteer
>            - const: fsl,imx-irqsteer
> =20
>    reg:
> @@ -42,6 +44,9 @@ properties:
>    clock-names:
>      const: ipg
> =20
> +  power-domains:
> +    maxItems: 1
> +
>    interrupt-controller: true
> =20
>    "#interrupt-cells":
> @@ -70,6 +75,16 @@ required:
>    - fsl,channel
>    - fsl,num-irqs
> =20
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8qxp-irqsteer
> +    then:
> +      required:
> +        - power-domains

Provided the power domains are optional on the existing platforms,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
otherwise,
else:
  properties:
    power-domains: false

Cheers,
Conor.

> +
>  additionalProperties: false
> =20
>  examples:
> --=20
> 2.34.1
>=20

--cwoDUL3Q+X8/OOYa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZiaGxAAKCRB4tDGHoIJi
0ljpAQCpp9Iw3VLIDdfXFjPlSOS7/ujkW6weU98urQDmwD9FZwD/Q9aTwbKunV32
4LDLeaO+00Gg4CG//YU92oFBHMiXaA4=
=4im4
-----END PGP SIGNATURE-----

--cwoDUL3Q+X8/OOYa--